You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/12 15:37:24 UTC
[GitHub] [pulsar] visortelle opened a new issue, #16024: [admin] Inconsistent response in GET namespace deduplication REST API endpoint
visortelle opened a new issue, #16024:
URL: https://github.com/apache/pulsar/issues/16024
## How it works now
If deduplication wasn't set, it returns `undefined`.
After `pulsar-admin namespaces set-deduplication --enable public/default` it returns `true`.
Then after `pulsar-admin namespaces set-deduplication --disable public/default` it returns `false`.
So there are three possible values: `undefined`, `true`, and `false`.
## What I expect
I would expect `true` and `false` values here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] visortelle commented on issue #16024: [admin] Inconsistent response in GET namespace deduplication REST API endpoint
Posted by GitBox <gi...@apache.org>.
visortelle commented on issue #16024:
URL: https://github.com/apache/pulsar/issues/16024#issuecomment-1153653355
@Technoboy- Thank you for the response. It explains the reason, but probably it would be better to return something like:
```
{
"enabled": boolean,
"policyLevel": "namespace" | "topic"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on issue #16024: [admin] Inconsistent response in GET namespace deduplication REST API endpoint
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on issue #16024:
URL: https://github.com/apache/pulsar/issues/16024#issuecomment-1153642122
https://github.com/apache/pulsar/issues/9216
Since the topic-level policy is introduced, users need a specific value (null) to determine whether a policy has been set at the topic-level. Otherwise, for this boolean type of policy, if it returns false, it is difficult to determine whether it is a topic-level policy or a namespace-level policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] visortelle closed issue #16024: [admin] Inconsistent response in GET namespace deduplication REST API endpoint
Posted by GitBox <gi...@apache.org>.
visortelle closed issue #16024: [admin] Inconsistent response in GET namespace deduplication REST API endpoint
URL: https://github.com/apache/pulsar/issues/16024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org