You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/05/13 12:12:06 UTC
[GitHub] [solr] dsmiley opened a new pull request #124: source patterns: allow "var" usage
dsmiley opened a new pull request #124:
URL: https://github.com/apache/solr/pull/124
I think we should stop the blockade on Java "var" now that 8.x is only going to get one (maybe two) more releases?
FYI in #115 I started using it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #124: source patterns: allow "var" usage
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #124:
URL: https://github.com/apache/solr/pull/124#issuecomment-843507072
I removed the "var" usages in the other PR at this particular commit: https://github.com/apache/solr/pull/115/commits/8c9e262401589d15a5260d0a25cf54934507b3a8
We can keep avoiding "var" for longer if we want; I'm not passionate about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley closed pull request #124: source patterns: allow "var" usage
Posted by GitBox <gi...@apache.org>.
dsmiley closed pull request #124:
URL: https://github.com/apache/solr/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #124: source patterns: allow "var" usage
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #124:
URL: https://github.com/apache/solr/pull/124#issuecomment-843454672
I looked over through the other PR and didn't see usage of var, can you help me find use cases where you think this is helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #124: source patterns: allow "var" usage
Posted by GitBox <gi...@apache.org>.
madrob commented on pull request #124:
URL: https://github.com/apache/solr/pull/124#issuecomment-843535903
If we don't have a reason to do it, then I'd continue to avoid it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org