You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2012/04/14 00:43:35 UTC

android commit: Adding old code back, we can't access webViewClient methods without them being on the UI thread. :(

Updated Branches:
  refs/heads/CordovaWebView 8ac274cdc -> 531b8f641


Adding old code back, we can't access webViewClient methods without them being on the UI thread. :(


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/531b8f64
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/531b8f64
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/531b8f64

Branch: refs/heads/CordovaWebView
Commit: 531b8f641ff1dc9b7e4228c1a5beea457d1844ca
Parents: 8ac274c
Author: Joe Bowser <bo...@apache.org>
Authored: Fri Apr 13 15:43:17 2012 -0700
Committer: Joe Bowser <bo...@apache.org>
Committed: Fri Apr 13 15:43:17 2012 -0700

----------------------------------------------------------------------
 framework/src/org/apache/cordova/DroidGap.java |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/531b8f64/framework/src/org/apache/cordova/DroidGap.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/DroidGap.java b/framework/src/org/apache/cordova/DroidGap.java
index 04cd01d..9b77e02 100755
--- a/framework/src/org/apache/cordova/DroidGap.java
+++ b/framework/src/org/apache/cordova/DroidGap.java
@@ -407,11 +407,10 @@ public class DroidGap extends Activity implements CordovaInterface {
 
                         // If timeout, then stop loading and handle error
                         if (me.loadUrlTimeout == currentLoadUrlTimeout) {
-                            /*
-                            me.appView.stopLoading();
-                            LOG.e(TAG, "DroidGap: TIMEOUT ERROR! - calling webViewClient");
-                            me.webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
-                            */
+                           me.appView.stopLoading();
+                           LOG.e(TAG, "DroidGap: TIMEOUT ERROR! - calling webViewClient");
+                           //We need another mechanism for handling timeout errors, we can't use webViewClient.onReceivedError anymore.
+                           //me.webViewClient.onReceivedError(me.appView, -6, "The connection to the server was unsuccessful.", url);
                         }
                     }
                 };