You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by felizbear <gi...@git.apache.org> on 2016/12/02 04:43:42 UTC
[GitHub] zeppelin pull request #1714: Fe explicit arguments
GitHub user felizbear opened a pull request:
https://github.com/apache/zeppelin/pull/1714
Fe explicit arguments
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit cc2fd7b3066ae5ee2cfcca2e7970af02fefdf0c4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit f83e97d38eca0d8b9220c6bf1664a5d609b36020
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit 34ad2033425a548d4e74c229b1d77a1a0e4ca93c
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit 3a52626c8d56c644a014db85aeabb9c691c361aa
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 1bd90a11e3f8d717860927f2742a485e0db23b50
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 6adb2d8258f5dc30d400b8ddaccdc2e33a474194
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit 8eff4db67bf6c12c4a480cd42d9a7547aaae2cb5
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 9ec637b7b8055a4b9f76ab587808ce5d87b72574
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit 6fd7775a784b61f150398a17bb6fd6f1752a0e4d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit 9faf2ed1870fd6eac96b8b0c056d53c4e7bd5972
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit a9fde256f0315eb2a16eec0a328cb40cf59c3527
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit a80e5f242d3504b1cbeecadfac9c409c23afc5e8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 5d82be89305e4b39e848cd23ae67cc3e9241078c
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit e8dafbd34474bc66a512d4e99d6f2e863ae42f94
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit 349229ecb38f4716897795fc1c0f02e9c1578639
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 9157d6c8f2c43d2d1a30182efd77fff3e61e848f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 1b32d7f5c0aad152d3a05f37901ec77a9b60645c
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit 860f8c6109d4ba845f61a33e46781ad4e6a8284a
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 192f340043cda41693a0d056e5d579ca4aed95da
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 8e61c9e1df1cd18babbd2298452d542574a8aac6
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit b7ab3baee7e2c04e854e34111de8f67cbddbff85
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit 7f42a884c1e8e3b7b62de5dfe92283184f039596
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit b97d5cff5c29a7658ef793b78cea64c32fc80d3e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit 404aed5df1a2121823fec653c987febbbcbab4b5
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 83d53dcdf44fad9f3248b900643802e10819ceb1
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 46712d2152d4349487954a69796dcac8601a1cd5
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit be2ecb06440cfe7e8b1e66ef04edf68b453db5cd
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Looks great to me!
@felizbear In my experience, if the contribution author followup on CI failure - that speeds up the merge time tremendously.
It looks like at least CI is failing on `npm run test` (which fails on the `grunt test`? ), could you please double-check\digg into it?
```
ERROR]
[ERROR] npm ERR! Linux 4.8.7-040807-generic
[ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "run" "test"
[ERROR] npm ERR! node v6.9.1
[ERROR] npm ERR! npm v3.10.8
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! zeppelin-web@0.0.0 test: `grunt test`
[ERROR] npm ERR! Exit status 3
[ERROR] npm ERR!
[ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 test script 'grunt test'.
[ERROR] npm ERR! Make sure you have the latest version of node.js and npm installed.
[ERROR] npm ERR! If you do, this is most likely a problem with the zeppelin-web package,
[ERROR] npm ERR! not with npm itself.
[ERROR] npm ERR! Tell the author that this fails on your system:
[ERROR] npm ERR! grunt test
[ERROR] npm ERR! You can get information on how to open an issue for this project with:
[ERROR] npm ERR! npm bugs zeppelin-web
[ERROR] npm ERR! Or if that isn't available, you can get their info via:
[ERROR] npm ERR! npm owner ls zeppelin-web
[ERROR] npm ERR! There is likely additional logging output above.
[ERROR]
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR! /home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm test) on project zeppelin-web: Failed to run task: 'npm run test' failed. (error code 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1714
All checks have passed. Let's merge it please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1714
this backend test currently fails
```
- should provide onclick method *** FAILED ***
The code passed to eventually never returned normally. Attempted 1 times over 516.964883 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)
```
investingating why
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 4070c84a99c5e578c03e611d2e8232e52b393c1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-05T11:17:57Z
fix test
removed unsuded toggleGraphOption
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 4070c84a99c5e578c03e611d2e8232e52b393c1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-05T11:17:57Z
fix test
removed unsuded toggleGraphOption
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 4070c84a99c5e578c03e611d2e8232e52b393c1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-05T11:17:57Z
fix test
removed unsuded toggleGraphOption
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1714
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 3c4384f89e15c5308c1042ea883f17f8add824d9
Author: felizbear <il...@nflabs.com>
Date: 2016-12-05T11:17:57Z
fix test
removes unused toggleGraphOption
fixes selenium tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: Use explicit arguments in functions in paragraph.contr...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Looks great to me, thank you @felizbear for frontend code improvements!
Let's wait for CI, meanwhile, would you mind creating a JIRA issue please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1714: [ZEPPELIN-1743] Use explicit arguments in functions in...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1714
Thank you @felizbear !
Merging to master if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1714
[ZEPPELIN-1743] Use explicit arguments in functions in paragraph.controller.js
### What is this PR for?
This is `paragraph.controller.js` maintenance PR. It refactors most functions in paragraph controller to accept explicit parameters instead of getting data from `$scope`. It is a first - simple and safe - step in making paragraph controller more maintainable.
### What type of PR is it?
Refactoring
### Todos
* [x] - Call functions explicitly with parameters when makes sense
* [x] - Do minor refactoring when makes sense
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1743
### How should this be tested?
Make sure that paragraph works as expected by interacting with it;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/felizbear/zeppelin fe-explicit-arguments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1714.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1714
----
commit 13d314071de5373daa699e7eb0c50b4846f8eeba
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:04:31Z
make arguments explicit in initializeDefault
commit d25060ba1dfc299b2053f946d5f48be7405402d7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:08:06Z
make arguments explicit in isRunning
commit abe56ed8c9f849acaf18287bcca44a95df25ca4e
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:09:42Z
make arguments explicit in cancelParagraph
commit c2939d0fd21ab95e670fbfe8908deaf2b58e471b
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:18:03Z
make arguments explicit in saveParagraph
commit 20d66e565ed1effbe063b00fe5d58a2610e6c461
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:20:32Z
make arguments explicit in toggleEnableDisable
commit 99d23cf680d8bd71e777986e554d57da36d579bf
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:29:42Z
make arguments explicit in run
commit e9e584e44fb648688ebddb7a1de5b9becf5b5670
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:33:29Z
make arguments explicit for moveUp and moveDown
commit 7bbb7dc7e1801ea334ba8b2c24dc610751e88b1f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:43:40Z
make arguments explicit in insertNew
commit d807e6ee760f4cc3890877ca3b471eaa46ff68ee
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:45:47Z
make arguments explicit in removeParagraph
commit c383a2f92a1c097d66a8d0902b16f18d60f7be2f
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:46:59Z
make arguments explicit in clearParagraphOutput
commit 414fd9e7839ff2375354960109897940b43b1b22
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:50:38Z
make arguments explicit in toggleEditor
commit 62cb81a11e702347fff55b490139a267daa90a88
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:52:02Z
make arguments explicit in open / close table
commit 83f3b0f6a35d4e687725dfa95193e16f53396867
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T08:54:37Z
make arguments explicit in various open / close editor / table nonsense
functions
commit 58dcf3ab352bff5ac93a95dbcc45d997837618d8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:09:54Z
make arguments explicit in show / hide / set title
commit b44972acc57381e9b67a8e5cee2cbb9b5eb452f7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:11:29Z
make arguments explicit in show / hide lineNumbers
commit 41772acd5e71df4a1952ecc1626bc33082273021
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:22:31Z
make arguments explicit in changeColWidth
commit 569368c144245ae853f101c58fc796d9a0da2a90
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:23:17Z
remove unused function toggleGraphOption
commit ba9a429f0a669242470f972801c4217f73d381db
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:24:32Z
make arguments explicit in toggleOutput
commit 3315b3c99268081ff277d27b59295e5b3cef5e92
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:28:11Z
make arguments explicit in aceChanged
commit 40ca7d18a9a7c2873f3a169ff8182835a59aff5d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:31:24Z
make arguments explicit in getEditorSetting
commit 9af71a087aa44ff6a7bef3edb46d855d82c99eb4
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:35:58Z
make arguments explicit in autoAdjustEditorHeight
commit a9ddba6f8c3ed2843abc876b7eb0439f42530608
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:44:16Z
refactor getProgress
commit 620a6e0260d1430c524469fff81fd7416aa0a88d
Author: felizbear <il...@nflabs.com>
Date: 2016-12-01T09:48:27Z
make arguments explicit in various util functions
commit e65cc1829a308f248708c9c3dede232a06388ee8
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:38:36Z
pass whole paragraph to commitParagraph
commit 98376e48a235bd71661312e21a0ace9d485461a7
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:41:37Z
remove custom prototype string method startsWith in favor of indexOf
modifying prototypes is unreliable and can lead to bugs
commit 4e7db8d51306865067b3c8eb800415e3b8dec032
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:45:11Z
make arguments explicit in scroll up / down util functions
commit d1788482aa2a3461fb5f8d4a740d30125342c818
Author: felizbear <il...@nflabs.com>
Date: 2016-12-02T01:59:48Z
remove unused event listener runParagraph
commit 3c4384f89e15c5308c1042ea883f17f8add824d9
Author: felizbear <il...@nflabs.com>
Date: 2016-12-05T11:17:57Z
fix test
removes unused toggleGraphOption
fixes selenium tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1714: [ZEPPELIN-1743] Use explicit arguments in funct...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---