You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/08/15 04:10:15 UTC
[PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
dongjoon-hyun opened a new pull request, #47766:
URL: https://github.com/apache/spark/pull/47766
### What changes were proposed in this pull request?
This PR aims to add `OpenContainers` Annotations to docker image.
- https://specs.opencontainers.org/image-spec/annotations/
### Why are the changes needed?
**BEFORE**
```
$ docker inspect apache/spark:3.5.2 | jq '.[0].Config.Labels'
{
"org.opencontainers.image.ref.name": "ubuntu",
"org.opencontainers.image.version": "20.04"
}
```
**AFTER**
```
```
### Does this PR introduce _any_ user-facing change?
No, it's only a metadata change.
### How was this patch tested?
Manual review.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718014258
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Can it be removed if it's blank?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47766:
URL: https://github.com/apache/spark/pull/47766#issuecomment-2290712087
Thank you, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718016728
##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile:
##########
@@ -18,6 +18,10 @@
ARG base_img
FROM ${base_img:-spark}
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Python Image"
Review Comment:
PySpark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718014340
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
> Apache Spark Community?
Isn't it too broad because it include a read-only users.
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
> Apache Spark Community?
Isn't it too broad because it include a read-only users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718018541
##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile:
##########
@@ -18,6 +18,10 @@
ARG base_img
FROM ${base_img:-spark}
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Python Image"
Review Comment:
Ya, I also considered `Apache Spark PySpark Image` and `Apache Spark SparkR Image`.
But, I believe `Python` would be better because we have `Apache Spark Scala/Java Image` as a base image.
In addition, I'm not sure, but `Apache Spark Go Image` comes later. So, for consistency, language name could work extensively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718024192
##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile:
##########
@@ -18,6 +18,10 @@
ARG base_img
FROM ${base_img:-spark}
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Python Image"
Review Comment:
Also, please see our docker hub. The Docker convention in the name is languages like `scala`, `r`, `python3` instead of `SparkR` or `PySpark`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #47766: [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images
URL: https://github.com/apache/spark/pull/47766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718028585
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Got it. Thanks for the explanation.
Maybe we can add some comment here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718556684
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
Maybe, did you mean `Apache Spark` by `with others`? It's possible.
However, technically, `Apache Spark™` is a trademark and the unique name of our project while `project` is a normal noun.
[
](url)
Here is a sample example sentence according to ASF guideline. Unlike `Apache Spark`, the following normal noun like `software` is used in a lower case. You can see that the phrase, `the Apache Foo project`, in the same document as a example.
https://www.apache.org/foundation/marks/#guidelines
> "Free copies of Apache ProjectName software under the Apache License and support services for Apache ProjectName are available at my own company website."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718015469
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Without this blank, the information could be interpreted as `Apache Spark 20.04`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718072656
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
> via version detection from RELEASE
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47766:
URL: https://github.com/apache/spark/pull/47766#issuecomment-2291559549
Thank you! Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47766:
URL: https://github.com/apache/spark/pull/47766#issuecomment-2290570758
Could you review this PR, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718042773
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
> I believe it's acceptable to include read-only users because non-code contributions, such as testing and sharing use cases, should also be acknowledged. The [User](https://apache.org/foundation/how-it-works/#users) also plays a role in contributing according to 'The Apache Way'.
I got your point. It seems that there was a little misunderstanding between you and me.
- When I say `read-only users`, I embraced `read-only users` (who didn't contribute at all in all ways) as `Apache Spark Community`.
The point is that I have a broader concept on the `Community` than yours.
The next question is that
- `Contributors` are `Authors`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718076771
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
Shall we capitalize 'project' to make it consistent with others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1719203631
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
Oh, I mean 'Apache Spark ~p~Project' like 'S'cala, 'I'mage etc, but it's just a nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718054277
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
One more thing. I believe I used the term `Project` in the author in this way.
- https://apache.org/projects/#what-is-an-open-source-project
> An open source project includes all aspects of creating, maintaining, and distributing open source software including community building and mentoring, communication, the release process, and everything in between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718046321
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Sure. I will add comments, @yaooqinn .
Ya, I agree that the AS-IS is obscure.
So, I'm currently trying to improve this area including `bin/docker-image-tool.sh` via version detection from `RELEASE`. For the K8s images, I guess I can deliver a better way to fill this field. But, for this `spark-rm/Dockerfile`, I guess it's not worth to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718054277
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
One more thing. I used the term `Project` as the author in this way.
- https://apache.org/projects/#what-is-an-open-source-project
> An open source project includes all aspects of creating, maintaining, and distributing open source software including community building and mentoring, communication, the release process, and everything in between.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718015469
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Without this blank, the final information could be interpreted as `Apache Spark 20.04`.
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
> Apache Spark Community?
Isn't it too broad because it includes a read-only users?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718013796
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
Apache Spark Community?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718014996
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Release Manager Image"
+LABEL org.opencontainers.image.version=""
Review Comment:
Ya, I tried, but we should have a blank here to remove the previous OS layer version as described in the PR description.
```
$ docker inspect apache/spark:3.5.2 | jq '.[0].Config.Labels'
{
"org.opencontainers.image.ref.name": "ubuntu",
"org.opencontainers.image.version": "20.04"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718031939
##########
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile:
##########
@@ -18,6 +18,10 @@
ARG base_img
FROM ${base_img:-spark}
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
+LABEL org.opencontainers.image.licenses="Apache-2.0"
+LABEL org.opencontainers.image.ref.name="Apache Spark Python Image"
Review Comment:
I was considering whether it will conflict with the https://pypi.org/project/pyspark-connect/ or not.
But it looks fine to me now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718042773
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
> I believe it's acceptable to include read-only users because non-code contributions, such as testing and sharing use cases, should also be acknowledged. The [User](https://apache.org/foundation/how-it-works/#users) also plays a role in contributing according to 'The Apache Way'.
I got your point. It seems that there was a little misunderstanding between you and me.
- When I say `read-only users`, I embraced `read-only users` (who didn't contribute at all in all ways) as `Apache Spark Community`.
The point is that I have a broader concept on the community than yours.
The next question is that
- `Contributors` are `Authors`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on code in PR #47766:
URL: https://github.com/apache/spark/pull/47766#discussion_r1718027240
##########
dev/create-release/spark-rm/Dockerfile:
##########
@@ -17,6 +17,10 @@
# Image for building Spark releases. Based on Ubuntu 22.04.
FROM ubuntu:jammy-20240227
+LABEL org.opencontainers.image.authors="Apache Spark project <de...@spark.apache.org>"
Review Comment:
I believe it's acceptable to include read-only users because non-code contributions, such as testing and sharing use cases, should also be acknowledged.
The [User](https://apache.org/foundation/how-it-works/#users) also plays a role in contributing according to 'The Apache Way'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49243][INFRA][K8S] Add `OpenContainers` Annotations in docker images [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #47766:
URL: https://github.com/apache/spark/pull/47766#issuecomment-2290799935
Thank you for thorough review, @yaooqinn .
I addressed your comments by adding a comment line and replied for the discussion part here.
- https://github.com/apache/spark/pull/47766#discussion_r1718042773
- https://github.com/apache/spark/pull/47766#discussion_r1718054277
Please let me know your opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org