You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/12 13:03:30 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new issue #3296: Use InfinispanTestResource in the Infinispan integration tests
zbendhiba opened a new issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296
Quarkus 2.5.Final is introducing newer version of Infinispan but also the Infinispan test resource. It could be relevant to use this testing class helper in our test integration class
More information here : [](https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/infinispan-client.adoc#testing-helpers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004835692
`InfinispanTestResource` does not seem to support setting a random port. Not sure how much we want to insist on that @jamesnetherton?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004842076
> `InfinispanTestResource` does not seem to support setting a random port
Seems you can set the port via `initArgs` if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004922564
> So can we live with a fixed port
Probably in the short term. We do it for some other things out of necessity.
> propose some change to InfinispanTestResource to use a random port
I guess we should do that. Looking again at `InfinispanTestResource` I don't actually see the port arg being used at all to set up the container. I guess because [`InfinispanContainer`](https://github.com/infinispan/infinispan-test/blob/master/testcontainers/src/main/java/org/infinispan/test/testcontainers/InfinispanContainer.java#L27) hard codes the port to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1005036576
> I may be out of context and in such case, please discard my message :) , but isn't the test resource already using a random port ?
Yeah, my bad. It should work as you describe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004873014
> I can only set a constant
Yes, I think you're right...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1005004045
> I don't actually see the port arg being used at all to set up the container. I guess because [`InfinispanContainer`](https://github.com/infinispan/infinispan-test/blob/master/testcontainers/src/main/java/org/infinispan/test/testcontainers/InfinispanContainer.java#L27) hard codes the port to use.
That's interesting! We should definitely report that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1005012766
I may be out of context and in such case, please discard my message :) , but isn't the test resource already using a random port ?
My understanding is that the call to `withExposedPorts(11222);` setting the port from the point of view of the container but for the host, then it will be a random port and you can get it with `container.getMappedPort(11222)`. The test resource seems to do so here: https://github.com/quarkusio/quarkus/blob/main/test-framework/infinispan-client/src/main/java/io/quarkus/test/infinispan/client/InfinispanTestResource.java#L45-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ashwinair edited a comment on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ashwinair edited a comment on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1003908136
Hi @zbendhiba , can i work on this issue? i'm new to open source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] lburgazzoli commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1005012766
I may be out of context and in such case, please discard my message, but isn't the test resource already using a random port ?
My understanding is that the call to `withExposedPorts(11222);` setting the port from the point of view of the container but for the host, then it will be a random port and you can get it with `container.getMappedPort(11222)`. The test resource seems to do so here: https://github.com/quarkusio/quarkus/blob/main/test-framework/infinispan-client/src/main/java/io/quarkus/test/infinispan/client/InfinispanTestResource.java#L45-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004858771
> > `InfinispanTestResource` does not seem to support setting a random port
>
> Seems you can set the port via `initArgs` if needed.
I see that option, but from within Java annotation, I can only set a constant, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ashwinair commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ashwinair commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1003908136
Hi @zbendhiba , can i work on this issue i'm new to open source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on issue #3296: Use InfinispanTestResource in the Infinispan integration tests
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #3296:
URL: https://github.com/apache/camel-quarkus/issues/3296#issuecomment-1004910545
So can we live with a fixed port, or we propose some change to InfinispanTestResource to use a random port (ideally by default)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org