[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on pull request #369: [YUNIKORN-1040] add e2e test that re-starts the scheduler pod

[GitBox <gi...@apache.org>]

yangwwei commented on pull request #369:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/369#issuecomment-1055033850


   hi @anuraagnalluri  thanks for the updates.
   
   The error message is still not that informative, I am still unclear why this port-forward command would fail. Any way to get more meaningful error messages? Have you tried to run the same port forward code locally? That works perfectly fine?
   
   The code in https://gianarb.it/blog/programmatically-kube-port-forward-in-go could be another approach, I think it won't block the main process
   
   ```
   // I just wait until the readyCh tells me that the connection is up and running
   select {
   case <-readyCh:
       break
   }
   println("Port forwarding is ready to get traffic. have fun!")
   ```
   
   actually it would be good to give this approach a try, because IIUC this way we can get rid of changes in the github action:
   
   ```
   gosec:
       # To specify a set of rules to explicitly exclude.
       # Available rules: https://github.com/securego/gosec#available-rules
       excludes:
         - G204
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org