You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/01 09:03:25 UTC

[GitHub] [incubator-kvrocks] PragmaTwice opened a new pull request, #803: Fix CMake configuration error in snappy

PragmaTwice opened a new pull request, #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803

   This closes #792.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] torwig commented on pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
torwig commented on PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1234083815

   @tisonkun I can confirm that the build process goes smoothly on Fedora 35 now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1233982029

   @torwig @aleksraiden Hi, could you guys help me to check whether this PR really fixed the CMake error on Fedora? So thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun commented on pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1234088009

   @torwig Thanks for your confirmation!
   
   Merging...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1233998316

   > May you describe a bit how adding these two files helps resolve the issue?
   > 
   > I think it's about CMake resolving order while it looks like we always set `GFLAGS_FOUND` & `GTEST_FOUND` to `false`.
   
   By default, for `find_package(X)`, CMake will use the builtin `FindX.cmake` file (provided by CMake) to find the X package.
   It will try to find the package in system, e.g. installed from package manager.
   We overwrite this file to make sure CMake do not use some builtin logic to find the package, because we do not need these package in snappy.
   
   It is actually a bug in (old version of) snappy, we defined `SNAPPY__BUILD_TEST=OFF`, but snappy will always find gtest regardless of our option, and we do not need gtest in snappy since we do not build unit tests in snappy.
   
   @tisonkun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803#issuecomment-1234088258

   @tisonkun I can confirm too, that the build process on Debian 11 are OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] tisonkun merged pull request #803: Fix CMake configuration error in snappy

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #803:
URL: https://github.com/apache/incubator-kvrocks/pull/803


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org