You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2005/07/05 23:50:06 UTC
[Bug 4460] New: USERPASS false positive
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
Summary: USERPASS false positive
Product: Spamassassin
Version: 3.1.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P3
Component: Libraries
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jgmyers@proofpoint.com
The attached message incorrectly fires USERPASS in 3.1.0-pre3. This is a
regression from 3.0.4.
The cause appears to be overly aggressive URL extraction.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jm@jmason.org 2005-07-11 16:41 -------
thanks for the votes -- will apply when I get a chance later.
I should point out, btw, that there's 100 or so tests, both positive ("we want
this") and negative ("we don't want this") in the test suite -- it's really
quite extensive.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From parkerm@pobox.com 2005-07-11 15:59 -------
+1, ok I'm fine with this, it's gotta be better than what we have.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From parkerm@pobox.com 2005-07-09 09:16 -------
So, is there anything that it doesn't catch, that it should?
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jgmyers@proofpoint.com 2005-07-05 14:50 -------
Created an attachment (id=2983)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=2983&action=view)
test case
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jm@jmason.org 2005-07-08 18:44 -------
Created an attachment (id=3013)
--> (http://bugzilla.spamassassin.org/attachment.cgi?id=3013&action=view)
fix
Please vote on this. This adds that test case to uri_text.t, and fixes this
bug.
given the large number of hits I'm seeing on USERPASS that look likely to be
caused by email addresses getting picked up as http: URLs, this is a pretty big
mass-check issue, and I'd prefer to get it in if we have to do a pre4 --
otherwise USERPASS, too, and other URI rules will be way off.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jm@jmason.org 2005-07-05 17:11 -------
hi John --
is the Return-Path "header", actually part of the body in that message? just
checking.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jm@jmason.org 2005-07-11 09:48 -------
Michael: well, all tests pass. so the stuff that we previously caught, we still
catch, and the stuff we previously avoided catching, we still avoid.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From henry@stern.ca 2005-07-11 15:56 -------
Looks good to me. +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
------- Additional Comments From jgmyers@proofpoint.com 2005-07-05 17:13 -------
Part of the body, in this test case.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
Bob@Menschel.net changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.1.0
------- Additional Comments From Bob@Menschel.net 2005-07-05 19:47 -------
Triage: Confirmed. Rule itself hasn't changed, but apparently uri extraction
has. This non-http uri (should it be interpreted as a mailto instead?) is being
interpreted as an http (since the rule tests for http), and is hitting this
string when IMO it shouldn't.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 4460] USERPASS false positive
Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4460
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From jm@jmason.org 2005-07-11 18:06 -------
Sending lib/Mail/SpamAssassin/PerMsgStatus.pm
Sending lib/Mail/SpamAssassin/Util.pm
Sending t/uri_text.t
Transmitting file data ...
Committed revision 215903.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.