You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/24 18:54:01 UTC

[GitHub] [nifi] kevdoran opened a new pull request, #6155: NIFI-9810 Isolate and deprecate RocksDB repository

kevdoran opened a new pull request, #6155:
URL: https://github.com/apache/nifi/pull/6155

   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-9810](https://issues.apache.org/jira/browse/NIFI-9810) This PR extracts the RocksDBFlowFileRepository implementation to its own maven module. It is also marked as deprecated, and planned to be dropped as part of NiFi 2.0.
   
   - Bump version to 6.29.5 for arm64 compatibilty
   - Extract RocksDBFlowFileRepository and supporting code to its own module
   - Mark RocksDBFlowFileRepository as deprecated, both in code and documentation
   - Log deprecation warning at startup if RocksDBFlowFileRepository is used
   - Move native RocksDB info logs to NiFi debug level logs
   
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] joewitt commented on pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
joewitt commented on PR #6155:
URL: https://github.com/apache/nifi/pull/6155#issuecomment-1170254815

   ahh good catch.  We should flag this in the migration guidance too that this module is no longer bundled by default but is available like other nars.  We should flag that in the docs whereever this thing is referenced too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory closed pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
exceptionfactory closed pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository
URL: https://github.com/apache/nifi/pull/6155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] kevdoran commented on pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
kevdoran commented on PR #6155:
URL: https://github.com/apache/nifi/pull/6155#issuecomment-1170272091

   Thanks for the review and feedback @exceptionfactory! This is a good idea, and given the limited usage of this implementation, excluding it from the convenience binary makes sense. I've moved the implementation to its own NAR now and here are the new testing instructions:
   
   ```
   # Build full project
   
   # Copy the new nifi-rocksdb-nar to the assembly lib dir:
   > cp nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/target/nifi-rocksdb-nar-1.17.0-SNAPSHOT.nar nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/lib
   
   # Edit the assembly nifi.properties to have the following: nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.RocksDBFlowFileRepository
   
   # Start NiFi and verify it works as expected
   > ./nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/bin/nifi.sh run
   ```
   
   This is still failing at runtime when using those steps, so I need to fix something 🙂
   
   @joewitt - This PR will update the Administration Guide appropriately, and I've added a note to the JIRA about the need for special migration guidance
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] kevdoran commented on pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
kevdoran commented on PR #6155:
URL: https://github.com/apache/nifi/pull/6155#issuecomment-1165851621

   To test this, I configured this in nifi.properties and tested a simple flow is still working as expected:
   
   ```
   nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.RocksDBFlowFileRepository
   ```
   
   This PR changes very little behavior, it is mostly just maven project restructuring.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6155:
URL: https://github.com/apache/nifi/pull/6155#discussion_r910235137


##########
nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements. See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License. You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+    <parent>
+        <artifactId>nifi-rocksdb-bundle</artifactId>
+        <groupId>org.apache.nifi</groupId>
+        <version>1.17.0-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>nifi-rocksdb-nar</artifactId>
+    <packaging>nar</packaging>
+
+    <properties>
+        <maven.javadoc.skip>true</maven.javadoc.skip>
+        <source.skip>true</source.skip>
+    </properties>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>

Review Comment:
   It looks like this NAR dependency tree is missing `nifi-rocksdb-repository`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] kevdoran commented on a diff in pull request #6155: NIFI-9810 Isolate and deprecate RocksDB repository

Posted by GitBox <gi...@apache.org>.
kevdoran commented on code in PR #6155:
URL: https://github.com/apache/nifi/pull/6155#discussion_r910253814


##########
nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements. See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License. You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+    <parent>
+        <artifactId>nifi-rocksdb-bundle</artifactId>
+        <groupId>org.apache.nifi</groupId>
+        <version>1.17.0-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
+
+    <artifactId>nifi-rocksdb-nar</artifactId>
+    <packaging>nar</packaging>
+
+    <properties>
+        <maven.javadoc.skip>true</maven.javadoc.skip>
+        <source.skip>true</source.skip>
+    </properties>
+
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>

Review Comment:
   Good catch, corrected in the latest



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org