You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/05/11 00:06:08 UTC

Review Request: Implemented Incinerator abstraction to rate limit deletion of files/directories.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11061/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Ben Mahler.


Description
-------

The purpose of the incinerator is to move items to trash and empty trash in rate-limited manner. It is designed to work across slave restarts.


Diffs
-----

  src/Makefile.am 343a7c5288e83d20dc6dd4db5353499199b90cb1 
  src/slave/constants.hpp ca1124afff9ef989c05723e314ea40555303a8ff 
  src/slave/constants.cpp 6cd97f97659d68297829c67a7513a193214c9a4a 
  src/slave/incinerator.hpp PRE-CREATION 
  src/slave/incinerator.cpp PRE-CREATION 
  src/tests/gc_tests.cpp 9cd3dfb7a67e435eb31693b887451970a8b4a90b 

Diff: https://reviews.apache.org/r/11061/diff/


Testing
-------

make check


Thanks,

Vinod Kone

Re: Review Request: Implemented Incinerator abstraction to rate limit deletion of files/directories.

Posted by Benjamin Hindman <be...@berkeley.edu>.

Hey Vinod,

Want to repost this guy?

Ben.


On Fri, May 10, 2013 at 3:06 PM, Vinod Kone <vi...@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11061/
>   Review request for mesos, Benjamin Hindman and Ben Mahler.
> By Vinod Kone.
> Description
>
> The purpose of the incinerator is to move items to trash and empty trash in rate-limited manner. It is designed to work across slave restarts.
>
>   Testing
>
> make check
>
>   Diffs
>
>    - src/Makefile.am (343a7c5288e83d20dc6dd4db5353499199b90cb1)
>    - src/slave/constants.hpp (ca1124afff9ef989c05723e314ea40555303a8ff)
>    - src/slave/constants.cpp (6cd97f97659d68297829c67a7513a193214c9a4a)
>    - src/slave/incinerator.hpp (PRE-CREATION)
>    - src/slave/incinerator.cpp (PRE-CREATION)
>    - src/tests/gc_tests.cpp (9cd3dfb7a67e435eb31693b887451970a8b4a90b)
>
> View Diff <https://reviews.apache.org/r/11061/diff/>
>