You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/10/20 20:33:00 UTC
[PR] [SPARK-XXXXX][CORE] Remove BaseErrorHandler [spark]
viirya opened a new pull request, #43468:
URL: https://github.com/apache/spark/pull/43468
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch removes a workaround trait `BaseErrorHandler` which was added long time ago (SPARK-25535) for [CRYPTO-141](https://issues.apache.org/jira/browse/CRYPTO-141) which was fixed 5 years ago.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Removing unnecessary workaround code.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367687469
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
}
- /**
- * SPARK-25535. The commons-crypto library will throw InternalError if something goes
- * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
- * afterwards. This wrapper detects that situation and avoids further calls into the
- * commons-crypto code, while still allowing the underlying streams to be closed.
- *
- * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto
Review Comment:
Yea, as I said that I happened to look at this code while working on related stuff. The workaround looks out-of-dated based on the status of CRYPTO-141.
Let's wait for what @vanzin thinks about the fix of CRYPTO-141.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43468:
URL: https://github.com/apache/spark/pull/43468#issuecomment-1776541528
Merged to master. If there is any feedback from Marcelo, we can do the follow-up, @viirya . Thank you all!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367495869
##########
core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala:
##########
@@ -167,36 +164,6 @@ class CryptoStreamUtilsSuite extends SparkFunSuite {
}
}
- test("error handling wrapper") {
Review Comment:
This test only tests the wrapper class `ErrorHandlingReadableChannel`. As it is removed, this test has nothing to test (it cannot be compiled).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43468:
URL: https://github.com/apache/spark/pull/43468#issuecomment-1773432349
cc @vanzin who added this work around and also fixed CRYPTO-141 in commons-crypto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367463765
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -55,10 +55,8 @@ private[spark] object CryptoStreamUtils extends Logging {
val params = new CryptoParams(key, sparkConf)
val iv = createInitializationVector(params.conf)
os.write(iv)
- new ErrorHandlingOutputStream(
Review Comment:
While I'm using these crypto streams, I looked at these codes and seems the workaround is not necessary anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367495869
##########
core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala:
##########
@@ -167,36 +164,6 @@ class CryptoStreamUtilsSuite extends SparkFunSuite {
}
}
- test("error handling wrapper") {
Review Comment:
This test only tests the wrapper class `ErrorHandlingReadableChannel`. As it is removed, this test has nothing to test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #43468: [SPARK-45618][CORE] Remove BaseErrorHandler
URL: https://github.com/apache/spark/pull/43468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367683508
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
}
- /**
- * SPARK-25535. The commons-crypto library will throw InternalError if something goes
- * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
- * afterwards. This wrapper detects that situation and avoids further calls into the
- * commons-crypto code, while still allowing the underlying streams to be closed.
- *
- * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto
Review Comment:
cc @vanzin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-XXXXX][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367464423
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
}
- /**
- * SPARK-25535. The commons-crypto library will throw InternalError if something goes
- * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
- * afterwards. This wrapper detects that situation and avoids further calls into the
- * commons-crypto code, while still allowing the underlying streams to be closed.
- *
- * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto
Review Comment:
Fixed in 1.1.0 (https://commons.apache.org/proper/commons-crypto/changes-report.html). Currently used commons-crypto library in Spark is 1.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367496352
##########
core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala:
##########
@@ -167,36 +164,6 @@ class CryptoStreamUtilsSuite extends SparkFunSuite {
}
}
- test("error handling wrapper") {
Review Comment:
The original ticket [SPARK-25535](https://issues.apache.org/jira/browse/SPARK-25535) and the PR doesn't add test for CRYPTO-141...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367683597
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
}
- /**
- * SPARK-25535. The commons-crypto library will throw InternalError if something goes
- * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
- * afterwards. This wrapper detects that situation and avoids further calls into the
- * commons-crypto code, while still allowing the underlying streams to be closed.
- *
- * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto
Review Comment:
@vanzin left some comments at https://issues.apache.org/jira/browse/CRYPTO-141
`If I find some time I'll see whether the ASF has any infra for testing this on Win32 and MacOS, since I only have a Linux dev env available.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367464423
##########
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala:
##########
@@ -166,117 +158,6 @@ private[spark] object CryptoStreamUtils extends Logging {
}
- /**
- * SPARK-25535. The commons-crypto library will throw InternalError if something goes
- * wrong, and leave bad state behind in the Java wrappers, so it's not safe to use them
- * afterwards. This wrapper detects that situation and avoids further calls into the
- * commons-crypto code, while still allowing the underlying streams to be closed.
- *
- * This should be removed once CRYPTO-141 is fixed (and Spark upgrades its commons-crypto
Review Comment:
CRYPTO-141 is fixed in 1.1.0 (https://commons.apache.org/proper/commons-crypto/changes-report.html). Currently used commons-crypto library in Spark is 1.1.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #43468:
URL: https://github.com/apache/spark/pull/43468#issuecomment-1776555060
Thank you @HyukjinKwon @dongjoon-hyun @beliefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-45618][CORE] Remove BaseErrorHandler [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #43468:
URL: https://github.com/apache/spark/pull/43468#discussion_r1367494539
##########
core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala:
##########
@@ -167,36 +164,6 @@ class CryptoStreamUtilsSuite extends SparkFunSuite {
}
}
- test("error handling wrapper") {
Review Comment:
Do we need to remove this test case inevitably? I'm wondering if we can keep some test coverage to make it sure that CRYPTO-141 is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org