You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/10/07 02:32:20 UTC
[PR] [CELEBORN-1003][0.3][FOLLOWUP] Add missing protobuf license file into spark shaded client jars [incubator-celeborn]
pan3793 opened a new pull request, #1953:
URL: https://github.com/apache/incubator-celeborn/pull/1953
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Add missing protobuf license file into spark shaded client jars
### Why are the changes needed?
`license/LICENSE-protobuf.txt` is missing in `celeborn-client-spark-2-shaded_2.11-0.3.1-incubating.jar` and `celeborn-client-spark-3-shaded_2.12-0.3.1-incubating.jar`
Note: this is an backporting issue, it only affects `branch-0.3`, `main` is fine
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1003][0.3][FOLLOWUP] Add missing protobuf license file into spark shaded client jars [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1953:
URL: https://github.com/apache/incubator-celeborn/pull/1953#issuecomment-1751571826
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1953?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1953](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1953?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1419a01) into [branch-0.3](https://app.codecov.io/gh/apache/incubator-celeborn/commit/ba0f0ed0b3a3797dd18a4f46418f0df435608a86?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ba0f0ed) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## branch-0.3 #1953 +/- ##
==============================================
+ Coverage 46.03% 46.15% +0.12%
==============================================
Files 165 165
Lines 10363 10363
Branches 958 958
==============================================
+ Hits 4770 4782 +12
+ Misses 5277 5266 -11
+ Partials 316 315 -1
```
[see 2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1953/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1003][0.3][FOLLOWUP] Add missing protobuf license file into spark shaded client jars [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1953: [CELEBORN-1003][0.3][FOLLOWUP] Add missing protobuf license file into spark shaded client jars
URL: https://github.com/apache/incubator-celeborn/pull/1953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1003][0.3][FOLLOWUP] Add missing protobuf license file into spark shaded client jars [incubator-celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1953:
URL: https://github.com/apache/incubator-celeborn/pull/1953#issuecomment-1751890538
merged to 0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org