You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/04 11:13:56 UTC
[GitHub] [skywalking] JayeshMuley opened a new issue #6321: Skywalking supports Postgreql as storage option
JayeshMuley opened a new issue #6321:
URL: https://github.com/apache/skywalking/issues/6321
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [X ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [ ] Feature or performance improvement
___
### Question
Is there any way to use Postgresql as a storage option for Skywalking.
Thanks and Regards,
Jayesh
___
### Bug
- Which version of SkyWalking, OS, and JRE?
- Which company or project?
- What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773367777
> I would like to contribute to this issue.
Welcome, if you need any help, ping me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773365409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773365409
I would like to contribute to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-774573414
> The upstream has the e2e to cover all tests.
>
> * GitHub action control file, https://github.com/apache/skywalking/tree/master/.github/workflows
> * e2e test codes, https://github.com/apache/skywalking/tree/master/test/e2e
> * doc, https://github.com/apache/skywalking/blob/master/docs/en/guides/README.md#end-to-end-tests-e2e-for-short
>
> Please run the new tasks on local and make them passed. The upstream tests will cause more time.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773231434
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #6321:
URL: https://github.com/apache/skywalking/issues/6321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773370977
> I would like to contribute to this issue.
Please evaluate how many libs and sizes of them before you write codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-774572833
@wu-sheng .Hi, I have completed this part of the function, but how do I test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773382057
Familiar with the code, I think this part of the function should be written in the `storage-jdbc-hikaricp-plugin` module, like h2、 mysql, there may be some differences, is right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773397347
#1964
```
MySQL driver is NOT allowed in Apache official distribution and source codes.
Please download MySQL driver by yourself. Copy the connection driver jar to oap-libs
```
Postgreql have the same problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] haoyann commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
haoyann commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773410433
The PostgreSQL JDBC Driver is distributed under the BSD-2-Clause License. Should be no problem
https://jdbc.postgresql.org/about/license.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773404107
Postgreql driver should be licensed as Apache 2.0, if so, it doesn't have this issue. The MySQL driver is GPL license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-774573263
The upstream has the e2e to cover all tests.
- GitHub action control file, https://github.com/apache/skywalking/tree/master/.github/workflows
- e2e test codes, https://github.com/apache/skywalking/tree/master/test/e2e
- doc, https://github.com/apache/skywalking/blob/master/docs/en/guides/README.md#end-to-end-tests-e2e-for-short
Please run the new tasks on local and make them passed. The upstream tests will cause more time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773414919
Yes, according to ASF doc, https://www.apache.org/legal/resolved.html#category-a, it should be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773383454
> Familiar with the code, I think this part of the function should be written in the `storage-jdbc-hikaricp-plugin` module, like h2、 mysql, there may be some differences, is right?
Yes, it is. But we need to depend on the driver libs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #6321: Skywalking supports Postgreql as storage option
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #6321:
URL: https://github.com/apache/skywalking/issues/6321#issuecomment-773231434
We support H2 and MySQL today, PostgreSQL could be supported as a storage plugin.
The contribution is welcome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org