You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@dubbo.apache.org by 方银城 <fa...@apache.org> on 2020/01/18 15:51:51 UTC
[VOTE]: Release Apache dubbo-go v1.3.0 RC1
Hello Dubbo/Dubbogo Community,
This is a call for vote to release Apache dubbo-go version v1.3.0 RC1.
The release candidates:
https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0
Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
The artifacts have been signed with Key :5862908F9A627BAA, which can be
found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
The vote will be open for at least 72 hours or until necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thanks,
The Apache Dubbo-go Team
Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 binding but there a couple of minor issue that need to be fixed before next release
I checked:
- signatures and hashes are OK
- The LICENSE is missing the appendix and one copyright owner
- the year in NOTICE is incorrect
- all source files have ASF headers
- no unexpected binary files
- didn’t compile from source. The instruction on how to do this cruel be clearer in the readme.
License is missing the license/copyright owner of this file [1]
It would be better to sign with an apache.org signature rather than a gmail one.
Thanks,
Justin
1. ./protocol/grpc/protoc-gen-dubbo/examples/helloworld.proto
Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1
Posted by 方银城 <fa...@gmail.com>.
Thanks! We will solve these issues very well. A pr is
https://github.com/apache/dubbo-go/pull/336
stocks alex <al...@apache.org> 于2020年1月22日周三 下午4:59写道：
> I vote +1 (binding) to this release.
>
> I checked the following conditions:
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [v] Do the contents of the release match with what's tagged in version
> control?
> [x] Are there any unexpected binary files in the release?
> [v] Can you compile from source? Are the instruction clear?
>
> As the year in the NOTICE is not right and the appendix and owner info in
> the license do not exist, I think Mr Fang can append them in the next
> release.
>
> victory <sh...@gmail.com> 于2020年1月22日周三 下午1:26写道：
>
> > +1 binding
> >
> > I checked:
> > - signatures and hashes are OK
> > - all source files have ASF headers
> > - run go test, and all tests passed.
> >
> > Ian Luo <ia...@gmail.com> 于2020年1月22日周三 上午11:48写道：
> >
> > > I checked the following items. I vote +1 (binding) to this release.
> > >
> > > [v] Are release files in correct location?
> > > [v] Are the digital signature and hashes correct?
> > > [v] Do LICENSE and NOTICE files exists?
> > > [v] Is the LICENSE and NOTICE text correct?
> > > [v] Is the NOTICE year correct?
> > > [x] Un-included software dependencies are not mentioned in LICENSE or
> > > NOTICE?
> > > [x] License information is not mentioned in NOTICE?
> > > [x] Is there any 3rd party code contained inside the release? If so:
> > > [ ] Does the software have a compatible license?
> > > [ ] Are all software licenses mentioned in LICENSE?
> > > [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> > > Is any of this code Apache licensed? Do they have NOTICE files? If
> so:
> > > [ ] Have relevant parts of those NOTICE files been added to this
> > NOTICE
> > > file?
> > > [ ] Do all source files have ASF headers?
> > > [v] Do the contents of the release match with what's tagged in version
> > > control?
> > > [x] Are there any unexpected binary files in the release?
> > > [v] Can you compile from source? Are the instruction clear?
> > >
> > > The year in NOTICE should be 2020.
> > >
> > > Is the issue minor?
> > > [v] Yes [] No [] Unsure
> > >
> > >
> > > Could it possibly be fixed in the next release?
> > > [v] Yes [ ] No [ ] Unsure
> > >
> > > I vote with:
> > > [v] +1 release the software
> > > [ ] +0 not sure if it should be released
> > > [ ] -1 don’t release the software because..
> > >
> > > Regards,
> > > -Ian.
> > >
> > > On Sat, Jan 18, 2020 at 11:52 PM 方银城 <fa...@apache.org> wrote:
> > >
> > > > Hello Dubbo/Dubbogo Community,
> > > >
> > > > This is a call for vote to release Apache dubbo-go version v1.3.0
> > RC1.
> > > >
> > > > The release candidates:
> > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
> > > >
> > > > Git tag for the release:
> > https://github.com/apache/dubbo-go/tree/1.3.0
> > > >
> > > > Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
> > > >
> > > > Release Notes:
> https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> > > >
> > > > The artifacts have been signed with Key :5862908F9A627BAA, which
> can
> > be
> > > > found in the keys file:
> > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > > >
> > > > The vote will be open for at least 72 hours or until necessary
> number
> > > of
> > > > votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thanks,
> > > > The Apache Dubbo-go Team
> > > >
> > >
> >
> >
> > --
> >
> > Best Regard!
> > cvitory
> >
>
Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1
Posted by stocks alex <al...@apache.org>.
I vote +1 (binding) to this release.
I checked the following conditions:
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
As the year in the NOTICE is not right and the appendix and owner info in
the license do not exist, I think Mr Fang can append them in the next
release.
victory <sh...@gmail.com> 于2020年1月22日周三 下午1:26写道：
> +1 binding
>
> I checked:
> - signatures and hashes are OK
> - all source files have ASF headers
> - run go test, and all tests passed.
>
> Ian Luo <ia...@gmail.com> 于2020年1月22日周三 上午11:48写道：
>
> > I checked the following items. I vote +1 (binding) to this release.
> >
> > [v] Are release files in correct location?
> > [v] Are the digital signature and hashes correct?
> > [v] Do LICENSE and NOTICE files exists?
> > [v] Is the LICENSE and NOTICE text correct?
> > [v] Is the NOTICE year correct?
> > [x] Un-included software dependencies are not mentioned in LICENSE or
> > NOTICE?
> > [x] License information is not mentioned in NOTICE?
> > [x] Is there any 3rd party code contained inside the release? If so:
> > [ ] Does the software have a compatible license?
> > [ ] Are all software licenses mentioned in LICENSE?
> > [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> > Is any of this code Apache licensed? Do they have NOTICE files? If so:
> > [ ] Have relevant parts of those NOTICE files been added to this
> NOTICE
> > file?
> > [ ] Do all source files have ASF headers?
> > [v] Do the contents of the release match with what's tagged in version
> > control?
> > [x] Are there any unexpected binary files in the release?
> > [v] Can you compile from source? Are the instruction clear?
> >
> > The year in NOTICE should be 2020.
> >
> > Is the issue minor?
> > [v] Yes [] No [] Unsure
> >
> >
> > Could it possibly be fixed in the next release?
> > [v] Yes [ ] No [ ] Unsure
> >
> > I vote with:
> > [v] +1 release the software
> > [ ] +0 not sure if it should be released
> > [ ] -1 don’t release the software because..
> >
> > Regards,
> > -Ian.
> >
> > On Sat, Jan 18, 2020 at 11:52 PM 方银城 <fa...@apache.org> wrote:
> >
> > > Hello Dubbo/Dubbogo Community,
> > >
> > > This is a call for vote to release Apache dubbo-go version v1.3.0
> RC1.
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
> > >
> > > Git tag for the release:
> https://github.com/apache/dubbo-go/tree/1.3.0
> > >
> > > Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
> > >
> > > Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> > >
> > > The artifacts have been signed with Key :5862908F9A627BAA, which can
> be
> > > found in the keys file:
> > https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > > The vote will be open for at least 72 hours or until necessary number
> > of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Dubbo-go Team
> > >
> >
>
>
> --
>
> Best Regard!
> cvitory
>
Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1
Posted by victory <sh...@gmail.com>.
+1 binding
I checked:
- signatures and hashes are OK
- all source files have ASF headers
- run go test, and all tests passed.
Ian Luo <ia...@gmail.com> 于2020年1月22日周三 上午11:48写道：
> I checked the following items. I vote +1 (binding) to this release.
>
> [v] Are release files in correct location?
> [v] Are the digital signature and hashes correct?
> [v] Do LICENSE and NOTICE files exists?
> [v] Is the LICENSE and NOTICE text correct?
> [v] Is the NOTICE year correct?
> [x] Un-included software dependencies are not mentioned in LICENSE or
> NOTICE?
> [x] License information is not mentioned in NOTICE?
> [x] Is there any 3rd party code contained inside the release? If so:
> [ ] Does the software have a compatible license?
> [ ] Are all software licenses mentioned in LICENSE?
> [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
> Is any of this code Apache licensed? Do they have NOTICE files? If so:
> [ ] Have relevant parts of those NOTICE files been added to this NOTICE
> file?
> [ ] Do all source files have ASF headers?
> [v] Do the contents of the release match with what's tagged in version
> control?
> [x] Are there any unexpected binary files in the release?
> [v] Can you compile from source? Are the instruction clear?
>
> The year in NOTICE should be 2020.
>
> Is the issue minor?
> [v] Yes [] No [] Unsure
>
>
> Could it possibly be fixed in the next release?
> [v] Yes [ ] No [ ] Unsure
>
> I vote with:
> [v] +1 release the software
> [ ] +0 not sure if it should be released
> [ ] -1 don’t release the software because..
>
> Regards,
> -Ian.
>
> On Sat, Jan 18, 2020 at 11:52 PM 方银城 <fa...@apache.org> wrote:
>
> > Hello Dubbo/Dubbogo Community,
> >
> > This is a call for vote to release Apache dubbo-go version v1.3.0 RC1.
> >
> > The release candidates:
> > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
> >
> > Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0
> >
> > Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
> >
> > Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> >
> > The artifacts have been signed with Key :5862908F9A627BAA, which can be
> > found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >
> > The vote will be open for at least 72 hours or until necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Dubbo-go Team
> >
>
--
Best Regard!
cvitory
Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1
Posted by Ian Luo <ia...@gmail.com>.
I checked the following items. I vote +1 (binding) to this release.
[v] Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
[ ] Does the software have a compatible license?
[ ] Are all software licenses mentioned in LICENSE?
[ ] Is the full text of the licenses (or pointers to it) in LICENSE?
Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?
The year in NOTICE should be 2020.
Is the issue minor?
[v] Yes [] No [] Unsure
Could it possibly be fixed in the next release?
[v] Yes [ ] No [ ] Unsure
I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..
Regards,
-Ian.
On Sat, Jan 18, 2020 at 11:52 PM 方银城 <fa...@apache.org> wrote:
> Hello Dubbo/Dubbogo Community,
>
> This is a call for vote to release Apache dubbo-go version v1.3.0 RC1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
>
> Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0
>
> Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
>
> Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
>
> The artifacts have been signed with Key :5862908F9A627BAA, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo-go Team
>