You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/02 12:30:14 UTC
[GitHub] [shardingsphere] 291277058 opened a new pull request #7229: #7163
291277058 opened a new pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229
Fixes #7163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14386](https://coveralls.io/builds/33201330)
* **0** of **8** **(0.0%)** changed or added relevant lines in **3** files are covered.
* **17204** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-1.5%**) to **34.098%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L236) | 11 | 90.76% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementBaseVisitor.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementBaseVisitor.java#L720) | 161 | 3.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.java](https://coveralls.io/builds/33201330/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementParser.java#L657) | 17031 | 15.16% |
<!-- | **Total:** | **17204** | | -->
| Totals | [](https://coveralls.io/builds/33201330) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -1.5% |
| Covered Lines: | 35410 |
| Relevant Lines: | 103848 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r483376940
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
I mean doc like ` _index.cn.md`,not only release note
```
1. Update to 4.0.1 above.
2. Configure`allow-range-query-with-inline-sharding` to `true` (Default value is `false`).
3. A tip here: then each range query will be broadcast to every sharding table.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14449](https://coveralls.io/builds/33254266)
* **0** of **8** **(0.0%)** changed or added relevant lines in **3** files are covered.
* **17274** unchanged lines in **16** files lost coverage.
* Overall coverage decreased (**-1.5%**) to **34.132%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/datasource/DataSourceFactory.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fdatasource%2FDataSourceFactory.java#L39) | 1 | 88.89% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaData.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdql%2FEncryptAlgorithmMetaData.java#L52) | 2 | 88.24% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/admin/RDLBackendHandler.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Ftext%2Fadmin%2FRDLBackendHandler.java#L154) | 2 | 93.62% |
| [shardingsphere-governance/shardingsphere-governance-core/shardingsphere-governance-core-schema/src/main/java/org/apache/shardingsphere/governance/core/schema/GovernanceSchemaContexts.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-governance%2Fshardingsphere-governance-core%2Fshardingsphere-governance-core-schema%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Fcore%2Fschema%2FGovernanceSchemaContexts.java#L110) | 3 | 96.99% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-apollo/src/main/java/org/apache/shardingsphere/governance/repository/apollo/ApolloRepository.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fapollo%2FApolloRepository.java#L94) | 3 | 92.31% |
| [shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/DataSourceConfiguration.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-infra%2Fshardingsphere-infra-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Finfra%2Fconfig%2Fdatasource%2FDataSourceConfiguration.java#L146) | 3 | 91.67% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L117) | 3 | 0% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-nacos/src/main/java/org/apache/shardingsphere/governance/repository/nacos/NacosRepository.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fnacos%2FNacosRepository.java#L65) | 4 | 91.49% |
| [shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/datasource/DataSourceManager.java](https://coveralls.io/builds/33254266/source?filename=shardingsphere-scaling%2Fshardingsphere-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fscaling%2Fcore%2Fdatasource%2FDataSourceManager.java#L81) | 4 | 89.19% |
<!-- | **Total:** | **17274** | | -->
| Totals | [](https://coveralls.io/builds/33254266) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -1.5% |
| Covered Lines: | 35437 |
| Relevant Lines: | 103822 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482997652
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
How should i deal with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482997652
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
How should i deal witch it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r483123149
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
All .md field keep previous code form?How about after 4.1.1. or rewrite doc as `Update to 4.*.* - 4.1.1`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r483376940
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
I mean what about doc like ` _index.cn.md`,not only release note
```
1. Update to 4.0.1 above.
2. Configure`allow-range-query-with-inline-sharding` to `true` (Default value is `false`).
3. A tip here: then each range query will be broadcast to every sharding table.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482997652
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
How should i deal with it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14392](https://coveralls.io/builds/33204123)
* **0** of **8** **(0.0%)** changed or added relevant lines in **3** files are covered.
* **17204** unchanged lines in **4** files lost coverage.
* Overall coverage decreased (**-1.5%**) to **34.098%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L236) | 11 | 90.76% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementBaseVisitor.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementBaseVisitor.java#L720) | 161 | 3.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.java](https://coveralls.io/builds/33204123/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementParser.java#L657) | 17031 | 15.16% |
<!-- | **Total:** | **17204** | | -->
| Totals | [](https://coveralls.io/builds/33204123) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -1.5% |
| Covered Lines: | 35410 |
| Relevant Lines: | 103848 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686284992
Hi @291277058
Your work is better than expected, actually, thanks for your effortful contribution!
Some comments need your fixing, though, I supposed it would not take you much time.
BTW, another new PR is not necessary, just do modification in your local branch and push them to GitHub. Then, this PR will be updated accordingly.
I am expected to see this merged soon!
Trista
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14397](https://coveralls.io/builds/33207468)
* **0** of **8** **(0.0%)** changed or added relevant lines in **3** files are covered.
* **17243** unchanged lines in **9** files lost coverage.
* Overall coverage decreased (**-1.5%**) to **34.121%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaData.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdql%2FEncryptAlgorithmMetaData.java#L52) | 2 | 88.24% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-apollo/src/main/java/org/apache/shardingsphere/governance/repository/apollo/ApolloRepository.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fapollo%2FApolloRepository.java#L94) | 3 | 92.31% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L117) | 3 | 0% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-nacos/src/main/java/org/apache/shardingsphere/governance/repository/nacos/NacosRepository.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fnacos%2FNacosRepository.java#L65) | 4 | 91.49% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L236) | 11 | 90.76% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSetMetaData.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fresultset%2FShardingSphereResultSetMetaData.java#L54) | 27 | 13.51% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementBaseVisitor.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementBaseVisitor.java#L720) | 161 | 3.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.java](https://coveralls.io/builds/33207468/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementParser.java#L657) | 17031 | 15.16% |
<!-- | **Total:** | **17243** | | -->
| Totals | [](https://coveralls.io/builds/33207468) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -1.5% |
| Covered Lines: | 35432 |
| Relevant Lines: | 103842 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14383](https://coveralls.io/builds/33194798)
* **8** of **45** **(17.78%)** changed or added relevant lines in **7** files are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.008%**) to **35.594%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/algorithm/AESEncryptAlgorithm.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Falgorithm%2FAESEncryptAlgorithm.java#L64) | 4 | 5 | 80.0%
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/algorithm/RC4EncryptAlgorithm.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Falgorithm%2FRC4EncryptAlgorithm.java#L60) | 2 | 3 | 66.67%
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/UpdateClauseShardingConditionEngine.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fcondition%2Fengine%2FUpdateClauseShardingConditionEngine.java#L56) | 0 | 27 | 0.0%
<!-- | **Total:** | **8** | **45** | **17.78%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33194798/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/33194798) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -0.008% |
| Covered Lines: | 35626 |
| Relevant Lines: | 100090 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482724444
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/test/java/org/apache/shardingsphere/sharding/spring/namespace/ShardingSpringNamespaceTest.java
##########
@@ -105,141 +103,141 @@
@Test
public void assertDataSourceShardingAlgorithm() {
- assertThat(dataSourceShardingAlgorithm.getType(), is("INLINE"));
- assertThat(dataSourceShardingAlgorithm.getProps().getProperty("algorithm.expression"), is("ds_$->{order_id % 2}"));
+ Assert.assertThat(dataSourceShardingAlgorithm.getType(), CoreMatchers.is("INLINE"));
+ Assert.assertThat(dataSourceShardingAlgorithm.getProps().getProperty("algorithm-expression"), CoreMatchers.is("ds_$->{order_id % 2}"));
}
@Test
public void assertOrderTableShardingAlgorithm() {
- assertThat(orderTableShardingAlgorithm.getType(), is("INLINE"));
- assertThat(orderTableShardingAlgorithm.getProps().getProperty("algorithm.expression"), is("t_order_$->{order_id % 4}"));
+ Assert.assertThat(orderTableShardingAlgorithm.getType(), CoreMatchers.is("INLINE"));
+ Assert.assertThat(orderTableShardingAlgorithm.getProps().getProperty("algorithm-expression"), CoreMatchers.is("t_order_$->{order_id % 4}"));
}
@Test
public void assertModShardingAlgorithm() {
- assertThat(modShardingAlgorithm.getType(), is("MOD"));
- assertThat(modShardingAlgorithm.getProps().getProperty("sharding.count"), is("2"));
+ Assert.assertThat(modShardingAlgorithm.getType(), CoreMatchers.is("MOD"));
+ Assert.assertThat(modShardingAlgorithm.getProps().getProperty("sharding-count"), CoreMatchers.is("2"));
}
@Test
public void assertComplexShardingAlgorithm() {
- assertThat(complexShardingAlgorithm.getType(), is("COMPLEX_TEST"));
+ Assert.assertThat(complexShardingAlgorithm.getType(), CoreMatchers.is("COMPLEX_TEST"));
}
@Test
public void assertHintShardingAlgorithm() {
- assertThat(hintShardingAlgorithm.getType(), is("HINT_TEST"));
+ Assert.assertThat(hintShardingAlgorithm.getType(), CoreMatchers.is("HINT_TEST"));
}
@Test
public void assertDataSourceShardingStrategy() {
- assertThat(dataSourceShardingStrategy.getShardingColumn(), is("order_id"));
- assertThat(dataSourceShardingStrategy.getShardingAlgorithmName(), is("dataSourceShardingAlgorithm"));
+ Assert.assertThat(dataSourceShardingStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(dataSourceShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("dataSourceShardingAlgorithm"));
}
@Test
public void assertOrderTableShardingStrategy() {
- assertThat(orderTableShardingStrategy.getShardingColumn(), is("order_id"));
- assertThat(orderTableShardingStrategy.getShardingAlgorithmName(), is("orderTableShardingAlgorithm"));
+ Assert.assertThat(orderTableShardingStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(orderTableShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("orderTableShardingAlgorithm"));
}
@Test
public void assertModStrategy() {
- assertThat(modStrategy.getShardingColumn(), is("order_id"));
- assertThat(modStrategy.getShardingAlgorithmName(), is("modShardingAlgorithm"));
+ Assert.assertThat(modStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(modStrategy.getShardingAlgorithmName(), CoreMatchers.is("modShardingAlgorithm"));
}
@Test
public void assertComplexStrategy() {
- assertThat(complexStrategy.getShardingColumns(), is("order_id,user_id"));
- assertThat(complexStrategy.getShardingAlgorithmName(), is("complexShardingAlgorithm"));
+ Assert.assertThat(complexStrategy.getShardingColumns(), CoreMatchers.is("order_id,user_id"));
+ Assert.assertThat(complexStrategy.getShardingAlgorithmName(), CoreMatchers.is("complexShardingAlgorithm"));
}
@Test
public void assertHintStrategy() {
- assertThat(hintShardingStrategy.getShardingAlgorithmName(), is("hintShardingAlgorithm"));
+ Assert.assertThat(hintShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("hintShardingAlgorithm"));
}
@Test
public void assertNoneStrategy() {
- assertNotNull(noneStrategy);
+ Assert.assertNotNull(noneStrategy);
}
@Test
public void assertIncrementAlgorithm() {
- assertThat(incrementAlgorithm.getType(), is("INCREMENT"));
+ Assert.assertThat(incrementAlgorithm.getType(), CoreMatchers.is("INCREMENT"));
}
@Test
public void assertDefaultKeyGenerator() {
- assertThat(defaultKeyGenerator.getColumn(), is("id"));
- assertThat(defaultKeyGenerator.getKeyGeneratorName(), is("incrementAlgorithm"));
+ Assert.assertThat(defaultKeyGenerator.getColumn(), CoreMatchers.is("id"));
+ Assert.assertThat(defaultKeyGenerator.getKeyGeneratorName(), CoreMatchers.is("incrementAlgorithm"));
}
@Test
public void assertOrderKeyGenerator() {
- assertThat(orderKeyGenerator.getColumn(), is("order_id"));
- assertThat(orderKeyGenerator.getKeyGeneratorName(), is("incrementAlgorithm"));
+ Assert.assertThat(orderKeyGenerator.getColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(orderKeyGenerator.getKeyGeneratorName(), CoreMatchers.is("incrementAlgorithm"));
}
@Test
public void assertSimpleRule() {
Collection<ShardingTableRuleConfiguration> actualSimpleRuleConfigurations = simpleRule.getTables();
- assertThat(actualSimpleRuleConfigurations.size(), is(1));
+ Assert.assertThat(actualSimpleRuleConfigurations.size(), CoreMatchers.is(1));
ShardingTableRuleConfiguration actualSimpleRuleConfiguration = actualSimpleRuleConfigurations.iterator().next();
- assertThat(actualSimpleRuleConfiguration.getLogicTable(), is("t_order"));
+ Assert.assertThat(actualSimpleRuleConfiguration.getLogicTable(), CoreMatchers.is("t_order"));
}
@Test
public void assertComplexRule() {
Collection<ShardingTableRuleConfiguration> actualComplexRuleConfigurations = complexRule.getTables();
- assertThat(actualComplexRuleConfigurations.size(), is(1));
+ Assert.assertThat(actualComplexRuleConfigurations.size(), CoreMatchers.is(1));
Review comment:
Please import `CoreMatchers`, so that we can change all the `CoreMatchers.is` as `is`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r483376940
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
I mean doc like ` _index.cn.md`
```
1. Update to 4.0.1 above.
2. Configure`allow-range-query-with-inline-sharding` to `true` (Default value is `false`).
3. A tip here: then each range query will be broadcast to every sharding table.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#issuecomment-686261610
## Pull Request Test Coverage Report for [Build 14403](https://coveralls.io/builds/33214465)
* **0** of **8** **(0.0%)** changed or added relevant lines in **3** files are covered.
* **17243** unchanged lines in **9** files lost coverage.
* Overall coverage decreased (**-1.5%**) to **34.121%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Falgorithm%2Fsharding%2Finline%2FInlineShardingAlgorithm.java#L79) | 0 | 1 | 0.0%
| [shardingsphere-jdbc/shardingsphere-jdbc-spring/shardingsphere-jdbc-spring-infra/shardingsphere-jdbc-spring-boot-starter-infra/src/main/java/org/apache/shardingsphere/spring/boot/registry/AbstractAlgorithmProvidedBeanRegistry.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-spring%2Fshardingsphere-jdbc-spring-infra%2Fshardingsphere-jdbc-spring-boot-starter-infra%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fspring%2Fboot%2Fregistry%2FAbstractAlgorithmProvidedBeanRegistry.java#L51) | 0 | 3 | 0.0%
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L42) | 0 | 4 | 0.0%
<!-- | **Total:** | **0** | **8** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-rdl-parser/shardingsphere-rdl-parser-binder/src/main/java/org/apache/shardingsphere/rdl/parser/binder/util/ShardingAlgorithmPropertiesUtil.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-rdl-parser%2Fshardingsphere-rdl-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Frdl%2Fparser%2Fbinder%2Futil%2FShardingAlgorithmPropertiesUtil.java#L46) | 1 | 0% |
| [shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-merge/src/main/java/org/apache/shardingsphere/encrypt/merge/dql/EncryptAlgorithmMetaData.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-features%2Fshardingsphere-encrypt%2Fshardingsphere-encrypt-merge%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fencrypt%2Fmerge%2Fdql%2FEncryptAlgorithmMetaData.java#L52) | 2 | 88.24% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-apollo/src/main/java/org/apache/shardingsphere/governance/repository/apollo/ApolloRepository.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fapollo%2FApolloRepository.java#L94) | 3 | 92.31% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L117) | 3 | 0% |
| [shardingsphere-governance/shardingsphere-governance-repository/shardingsphere-governance-repository-provider/shardingsphere-governance-repository-nacos/src/main/java/org/apache/shardingsphere/governance/repository/nacos/NacosRepository.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-governance%2Fshardingsphere-governance-repository%2Fshardingsphere-governance-repository-provider%2Fshardingsphere-governance-repository-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fgovernance%2Frepository%2Fnacos%2FNacosRepository.java#L65) | 4 | 91.49% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/impl/PostgreSQLDDLVisitor.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fpostgresql%2Fvisitor%2Fimpl%2FPostgreSQLDDLVisitor.java#L236) | 11 | 90.76% |
| [shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/ShardingSphereResultSetMetaData.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-jdbc%2Fshardingsphere-jdbc-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdriver%2Fjdbc%2Fcore%2Fresultset%2FShardingSphereResultSetMetaData.java#L54) | 27 | 13.51% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementBaseVisitor.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementBaseVisitor.java#L720) | 161 | 3.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-postgresql/target/generated-sources/antlr4/org/apache/shardingsphere/sql/parser/autogen/PostgreSQLStatementParser.java](https://coveralls.io/builds/33214465/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-postgresql%2Ftarget%2Fgenerated-sources%2Fantlr4%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fautogen%2FPostgreSQLStatementParser.java#L657) | 17031 | 15.16% |
<!-- | **Total:** | **17243** | | -->
| Totals | [](https://coveralls.io/builds/33214465) |
| :-- | --: |
| Change from base [Build 14377](https://coveralls.io/builds/33173208): | -1.5% |
| Covered Lines: | 35432 |
| Relevant Lines: | 103842 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482945676
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
previous release notes should be reserved.
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/algorithm/sharding/inline/InlineShardingAlgorithm.java
##########
@@ -76,7 +76,7 @@ public String doSharding(final Collection<String> availableTargetNames, final Pr
if (allowRangeQuery) {
return availableTargetNames;
}
- throw new UnsupportedOperationException("Since the property of `allow.range.query.with.inline.sharding` is false, inline sharding algorithm can not tackle with range query.");
+ throw new UnsupportedOperationException("Since the property of `allow-range-query-with-inline-sharding` is false, inline sharding algorithm can not tackle with range query.");
Review comment:
replace allow-range-query-with-inline-sharding with constant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] kimmking commented on a change in pull request #7229: fix #7163 replace dot with hyphen in configuration keys
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r483364140
##########
File path: RELEASE-NOTES.md
##########
@@ -33,7 +33,7 @@
1. Optimization for Sharing Parser with ANTLR Visitor improving the parsing performance of long SQL by 100%~1000%
1. Use multiple threads to load metadata for different data sources
-1. Support `allow.range.query.with.inline.sharding` option
+1. Support `allow-range-query-with-inline-sharding` option
Review comment:
release-note is a history. just keep it original.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482727468
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/test/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidatorTest.java
##########
@@ -96,7 +96,7 @@ public void assertValidateUpdateWithShardingKeyAndShardingParameterEquals() {
new ShardingUpdateStatementValidator().preValidate(shardingRule, routeContext, mock(ShardingSphereMetaData.class));
}
- @Test(expected = ShardingSphereException.class)
Review comment:
What changes did make `ShardingSphereException` removed?
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidator.java
##########
@@ -67,7 +69,8 @@ public void preValidate(final ShardingRule shardingRule, final RouteContext rout
if (shardingColumnSetAssignmentValue.isPresent() && shardingValue.isPresent() && shardingColumnSetAssignmentValue.get().equals(shardingValue.get())) {
continue;
}
- throw new ShardingSphereException("Can not update sharding key, logic table: [%s], column: [%s].", tableName, each);
+ log.warn("should not update sharding key, logic table: {}, column: {}", tableName, each);
+// throw new ShardingSphereException("Can not update sharding key, logic table: [%s], column: [%s].", tableName, each);
Review comment:
Please rollback this change to focus on `props` issue solely.
##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/algorithm/RC4EncryptAlgorithm.java
##########
@@ -88,6 +94,7 @@ private void reset() {
/**
* Crypt given byte array. Be aware, that you must init key, before using.
+ *
Review comment:
Why did you add a new blank line?
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/test/java/org/apache/shardingsphere/sharding/spring/namespace/ShardingSpringNamespaceTest.java
##########
@@ -105,141 +103,141 @@
@Test
public void assertDataSourceShardingAlgorithm() {
- assertThat(dataSourceShardingAlgorithm.getType(), is("INLINE"));
- assertThat(dataSourceShardingAlgorithm.getProps().getProperty("algorithm.expression"), is("ds_$->{order_id % 2}"));
Review comment:
Same issue for `CoreMatchers.is`.
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/test/java/org/apache/shardingsphere/sharding/spring/namespace/ShardingSpringNamespaceTest.java
##########
@@ -9,18 +9,14 @@
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
+ * distributed under the LicenseCoreMatchers.is distributed on an "ASCoreMatchers.is" BASIS,
Review comment:
Unexpected keyword replacement.
##########
File path: shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-common/src/main/java/org/apache/shardingsphere/encrypt/algorithm/RC4EncryptAlgorithm.java
##########
@@ -34,7 +34,9 @@
*/
public final class RC4EncryptAlgorithm implements EncryptAlgorithm {
- private static final String RC4_KEY = "rc4.key.value";
+ private static final String RC4_KEY = "rc4-key-value";
+
+ private static final String RC4_KEY_COMPATIBLE = "rc4-key-value";
Review comment:
Here, we no longer need `RC4_KEY_COMPATIBLE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] 291277058 commented on a change in pull request #7229: #7163
Posted by GitBox <gi...@apache.org>.
291277058 commented on a change in pull request #7229:
URL: https://github.com/apache/shardingsphere/pull/7229#discussion_r482746296
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-spring/shardingsphere-sharding-spring-namespace/src/test/java/org/apache/shardingsphere/sharding/spring/namespace/ShardingSpringNamespaceTest.java
##########
@@ -105,141 +103,141 @@
@Test
public void assertDataSourceShardingAlgorithm() {
- assertThat(dataSourceShardingAlgorithm.getType(), is("INLINE"));
- assertThat(dataSourceShardingAlgorithm.getProps().getProperty("algorithm.expression"), is("ds_$->{order_id % 2}"));
+ Assert.assertThat(dataSourceShardingAlgorithm.getType(), CoreMatchers.is("INLINE"));
+ Assert.assertThat(dataSourceShardingAlgorithm.getProps().getProperty("algorithm-expression"), CoreMatchers.is("ds_$->{order_id % 2}"));
}
@Test
public void assertOrderTableShardingAlgorithm() {
- assertThat(orderTableShardingAlgorithm.getType(), is("INLINE"));
- assertThat(orderTableShardingAlgorithm.getProps().getProperty("algorithm.expression"), is("t_order_$->{order_id % 4}"));
+ Assert.assertThat(orderTableShardingAlgorithm.getType(), CoreMatchers.is("INLINE"));
+ Assert.assertThat(orderTableShardingAlgorithm.getProps().getProperty("algorithm-expression"), CoreMatchers.is("t_order_$->{order_id % 4}"));
}
@Test
public void assertModShardingAlgorithm() {
- assertThat(modShardingAlgorithm.getType(), is("MOD"));
- assertThat(modShardingAlgorithm.getProps().getProperty("sharding.count"), is("2"));
+ Assert.assertThat(modShardingAlgorithm.getType(), CoreMatchers.is("MOD"));
+ Assert.assertThat(modShardingAlgorithm.getProps().getProperty("sharding-count"), CoreMatchers.is("2"));
}
@Test
public void assertComplexShardingAlgorithm() {
- assertThat(complexShardingAlgorithm.getType(), is("COMPLEX_TEST"));
+ Assert.assertThat(complexShardingAlgorithm.getType(), CoreMatchers.is("COMPLEX_TEST"));
}
@Test
public void assertHintShardingAlgorithm() {
- assertThat(hintShardingAlgorithm.getType(), is("HINT_TEST"));
+ Assert.assertThat(hintShardingAlgorithm.getType(), CoreMatchers.is("HINT_TEST"));
}
@Test
public void assertDataSourceShardingStrategy() {
- assertThat(dataSourceShardingStrategy.getShardingColumn(), is("order_id"));
- assertThat(dataSourceShardingStrategy.getShardingAlgorithmName(), is("dataSourceShardingAlgorithm"));
+ Assert.assertThat(dataSourceShardingStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(dataSourceShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("dataSourceShardingAlgorithm"));
}
@Test
public void assertOrderTableShardingStrategy() {
- assertThat(orderTableShardingStrategy.getShardingColumn(), is("order_id"));
- assertThat(orderTableShardingStrategy.getShardingAlgorithmName(), is("orderTableShardingAlgorithm"));
+ Assert.assertThat(orderTableShardingStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(orderTableShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("orderTableShardingAlgorithm"));
}
@Test
public void assertModStrategy() {
- assertThat(modStrategy.getShardingColumn(), is("order_id"));
- assertThat(modStrategy.getShardingAlgorithmName(), is("modShardingAlgorithm"));
+ Assert.assertThat(modStrategy.getShardingColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(modStrategy.getShardingAlgorithmName(), CoreMatchers.is("modShardingAlgorithm"));
}
@Test
public void assertComplexStrategy() {
- assertThat(complexStrategy.getShardingColumns(), is("order_id,user_id"));
- assertThat(complexStrategy.getShardingAlgorithmName(), is("complexShardingAlgorithm"));
+ Assert.assertThat(complexStrategy.getShardingColumns(), CoreMatchers.is("order_id,user_id"));
+ Assert.assertThat(complexStrategy.getShardingAlgorithmName(), CoreMatchers.is("complexShardingAlgorithm"));
}
@Test
public void assertHintStrategy() {
- assertThat(hintShardingStrategy.getShardingAlgorithmName(), is("hintShardingAlgorithm"));
+ Assert.assertThat(hintShardingStrategy.getShardingAlgorithmName(), CoreMatchers.is("hintShardingAlgorithm"));
}
@Test
public void assertNoneStrategy() {
- assertNotNull(noneStrategy);
+ Assert.assertNotNull(noneStrategy);
}
@Test
public void assertIncrementAlgorithm() {
- assertThat(incrementAlgorithm.getType(), is("INCREMENT"));
+ Assert.assertThat(incrementAlgorithm.getType(), CoreMatchers.is("INCREMENT"));
}
@Test
public void assertDefaultKeyGenerator() {
- assertThat(defaultKeyGenerator.getColumn(), is("id"));
- assertThat(defaultKeyGenerator.getKeyGeneratorName(), is("incrementAlgorithm"));
+ Assert.assertThat(defaultKeyGenerator.getColumn(), CoreMatchers.is("id"));
+ Assert.assertThat(defaultKeyGenerator.getKeyGeneratorName(), CoreMatchers.is("incrementAlgorithm"));
}
@Test
public void assertOrderKeyGenerator() {
- assertThat(orderKeyGenerator.getColumn(), is("order_id"));
- assertThat(orderKeyGenerator.getKeyGeneratorName(), is("incrementAlgorithm"));
+ Assert.assertThat(orderKeyGenerator.getColumn(), CoreMatchers.is("order_id"));
+ Assert.assertThat(orderKeyGenerator.getKeyGeneratorName(), CoreMatchers.is("incrementAlgorithm"));
}
@Test
public void assertSimpleRule() {
Collection<ShardingTableRuleConfiguration> actualSimpleRuleConfigurations = simpleRule.getTables();
- assertThat(actualSimpleRuleConfigurations.size(), is(1));
+ Assert.assertThat(actualSimpleRuleConfigurations.size(), CoreMatchers.is(1));
ShardingTableRuleConfiguration actualSimpleRuleConfiguration = actualSimpleRuleConfigurations.iterator().next();
- assertThat(actualSimpleRuleConfiguration.getLogicTable(), is("t_order"));
+ Assert.assertThat(actualSimpleRuleConfiguration.getLogicTable(), CoreMatchers.is("t_order"));
}
@Test
public void assertComplexRule() {
Collection<ShardingTableRuleConfiguration> actualComplexRuleConfigurations = complexRule.getTables();
- assertThat(actualComplexRuleConfigurations.size(), is(1));
+ Assert.assertThat(actualComplexRuleConfigurations.size(), CoreMatchers.is(1));
Review comment:
It will cause code check error. I have be suggested to avoid startic import.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org