You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/24 20:04:49 UTC

[GitHub] [solr] epugh opened a new pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

epugh opened a new pull request #307:
URL: https://github.com/apache/solr/pull/307


   https://issues.apache.org/jira/browse/SOLR-14834
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Solr:
   
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * SOLR-####: <short description of problem or changes>
   
   SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   I am updating old links to content.
   
   # Solution
   
   I looked for everything that had `wiki.apache.org/solr` and made this list: https://docs.google.com/spreadsheets/d/1jY9ACiASNdpZbxc0FzV5i8PFAagjPp4hpfuOmQDkaWg/edit#gid=0
   
   I also updated any lucene.apache.org/solr over to the new TLP solr format of solr.apache.org
   
   
   # Tests
   
   Ran the refguide and javadoc checks.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ X] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] janhoy commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-948954732


   > I've tried to remove the whitespace, with no luck... I'm nervous about destroying my PR, so may just live with it.
   
   Not super important. It may cause more merge conflicts with other open PRs but those should be easy to resolve anyway.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-948888947


   I've tried to remove the whitespace, with no luck...   I'm nervous about destroying my PR, so may just live with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-939359741


   I searched for `lucene.apache.org/solr/guide/` and there are 291 results in 71 files, so I think maybe that should be it's own Issue!
   
   So, I think I'm done on the work on this PR, and would love more thoughts on if it can be committed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh merged pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh merged pull request #307:
URL: https://github.com/apache/solr/pull/307


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] ctargett commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
ctargett commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-926920754


   > Do we have a link checker that runs that would find these?
   
   Well, no because 9 isn't out yet. But you are proposing this change for 9 so you should use the correct file names for 9. SOLR-14444 has a list of the name changes.
   
   I do think the version is a critical part of this which is why the links haven't been updated in the 9 years since we moved off the old wiki for documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-926898957


   > There are 2 issues with this PR:
   > 
   >     * The Ref Guide URLs used will always point to the "latest" version of the Ref Guide, so when someone is using 9.0 and the "latest" Ref Guide is 9.5, they will get redirected to the 9.5 version which may be significantly wrong for them. I brought this up in the issue and believe it's a serious limitation that needs to be accounted for.
   > 
   >     * In just a short spot check I noticed at least one case where the replacement Ref Guide page has been renamed in `main` branch, but this uses the branch_8x name (`detecting-languages-during-indexing` -> `language-detection`). This leads me to believe there may be several other of these so I didn't check further.
   
   I did run into the versioning issue as well, at least one file that I swore existed, `script-update-processor.adoc` is only in Solr 9, not in Solr 8.  My goal on this was just to try and remove the old wiki links, and not try to solve the versioning problem.   I figure once we solve the versioning issue, well, then we probably would need to make all these links smarter anyway, which would mean a pass through everywhere we reference links.  
   
   As far as the links to unreleased 9 versus released 8, my workflow was to try the link, see if it redirected to a existing ref guide (I landed on a bunch of version `/6_6/` pages that way), and then if not, look in the latest Ref Guide to find something.   
   
   Do we have a link checker that runs that would find these?
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-946253499


   @ctargett sorry to ping you directly, however I'd love to get this change in, if I've resolved your concerns.  I know this doesn't solve the versioning issue, however I think it's still better then what we have, and does close out two open JIRA tickets in one go ;-)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


[GitHub] [solr] epugh commented on pull request #307: SOLR-14834: Update all public-visible links from wiki.apache.org to RefGuide or cwiki

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #307:
URL: https://github.com/apache/solr/pull/307#issuecomment-939357960


   @ctargett the spreadsheet of old versus new names was GREAT, I had seen it once, but had forgotten about it.  I've gone through and updated all the links to be Solr 9 Ref Guide links.    
   
   I hear you on the version issue, however what do you think about making solving that part of a separate issue?   I like that at least in this PR, we have proper links....     Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org