You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/06/20 04:48:22 UTC
Review Request 35685: LENS-621 : Fix seekToStart for closed
resultsets in JDBCDriver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35685/
-----------------------------------------------------------
Review request for lens and Rajat Khandelwal.
Bugs: LENS-621
https://issues.apache.org/jira/browse/LENS-621
Repository: lens
Description
-------
- Fixed seekToStart for closed results
- Also fixed callers of getResultMetadata and getResultSet - to call getResultMetadata before
Diffs
-----
lens-client/src/main/java/org/apache/lens/client/LensClient.java 7399d9e
lens-client/src/main/java/org/apache/lens/client/LensClientResultSet.java 79e8abd
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java bbcc3f1
Diff: https://reviews.apache.org/r/35685/diff/
Testing
-------
lens-shell>query execute cube select customer_city_name, store_sales from sales where time_range_in(delivery_time, '2015-04-12-00', '2015-04-13-00')
20 Jun 2015 07:53:05,061 [Spring Shell] INFO cliLogger - Query handle: a036cbe9-968c-49b1-a2a9-d6a91491838f
20 Jun 2015 07:53:06,419 [Spring Shell] INFO cliLogger - User query: 'cube select customer_city_name, store_sales from sales where time_range_in(delivery_time, '2015-04-12-00', '2015-04-13-00')' was submitted to org.apache.lens.driver.jdbc.JDBCDriver
20 Jun 2015 07:53:06,420 [Spring Shell] INFO cliLogger - Driver query: 'SELECT ( customer_city . name ), sum(( sales . store_sales )) FROM mydb_sales_aggr_fact2 sales join mydb_city_subset customer_city on sales.customer_city_id = customer_city.id WHERE (((( sales . delivery_time ) = '2015-04-12 00:00:00' ))) GROUP BY ( customer_city . name )' and Driver handle: null
20 Jun 2015 07:53:06,495 [Spring Shell] INFO cliLogger - SUCCESSFUL:Query is successful! - Result Available
NAME C2
Bangalore 5.0
Hyderabad 8.0
2 rows process in (1) seconds.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
[INFO] Lens .............................................. SUCCESS [3.177s]
[INFO] Lens API .......................................... SUCCESS [22.413s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.710s]
[INFO] Lens Cube ......................................... SUCCESS [3:32.919s]
[INFO] Lens DB storage ................................... SUCCESS [19.864s]
[INFO] Lens Query Library ................................ SUCCESS [15.311s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.811s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.411s]
[INFO] Lens Server ....................................... SUCCESS [5:40.900s]
[INFO] Lens client ....................................... SUCCESS [36.761s]
[INFO] Lens CLI .......................................... SUCCESS [2:35.102s]
[INFO] Lens Examples ..................................... SUCCESS [8.986s]
[INFO] Lens Distribution ................................. SUCCESS [8.258s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.531s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.706s]
[INFO] Lens Regression ................................... SUCCESS [11.406s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:11.611s
[INFO] Finished at: Sat Jun 20 02:46:48 UTC 2015
[INFO] Final Memory: 174M/1458M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 35685: LENS-621 : Fix seekToStart for closed
resultsets in JDBCDriver
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35685/#review88624
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On June 20, 2015, 8:18 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35685/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 8:18 a.m.)
>
>
> Review request for lens and Rajat Khandelwal.
>
>
> Bugs: LENS-621
> https://issues.apache.org/jira/browse/LENS-621
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixed seekToStart for closed results
> - Also fixed callers of getResultMetadata and getResultSet - to call getResultMetadata before
>
>
> Diffs
> -----
>
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 7399d9e
> lens-client/src/main/java/org/apache/lens/client/LensClientResultSet.java 79e8abd
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java bbcc3f1
>
> Diff: https://reviews.apache.org/r/35685/diff/
>
>
> Testing
> -------
>
> lens-shell>query execute cube select customer_city_name, store_sales from sales where time_range_in(delivery_time, '2015-04-12-00', '2015-04-13-00')
> 20 Jun 2015 07:53:05,061 [Spring Shell] INFO cliLogger - Query handle: a036cbe9-968c-49b1-a2a9-d6a91491838f
> 20 Jun 2015 07:53:06,419 [Spring Shell] INFO cliLogger - User query: 'cube select customer_city_name, store_sales from sales where time_range_in(delivery_time, '2015-04-12-00', '2015-04-13-00')' was submitted to org.apache.lens.driver.jdbc.JDBCDriver
> 20 Jun 2015 07:53:06,420 [Spring Shell] INFO cliLogger - Driver query: 'SELECT ( customer_city . name ), sum(( sales . store_sales )) FROM mydb_sales_aggr_fact2 sales join mydb_city_subset customer_city on sales.customer_city_id = customer_city.id WHERE (((( sales . delivery_time ) = '2015-04-12 00:00:00' ))) GROUP BY ( customer_city . name )' and Driver handle: null
> 20 Jun 2015 07:53:06,495 [Spring Shell] INFO cliLogger - SUCCESSFUL:Query is successful! - Result Available
> NAME C2
> Bangalore 5.0
> Hyderabad 8.0
> 2 rows process in (1) seconds.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s]
> [INFO] Lens .............................................. SUCCESS [3.177s]
> [INFO] Lens API .......................................... SUCCESS [22.413s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.710s]
> [INFO] Lens Cube ......................................... SUCCESS [3:32.919s]
> [INFO] Lens DB storage ................................... SUCCESS [19.864s]
> [INFO] Lens Query Library ................................ SUCCESS [15.311s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.811s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.411s]
> [INFO] Lens Server ....................................... SUCCESS [5:40.900s]
> [INFO] Lens client ....................................... SUCCESS [36.761s]
> [INFO] Lens CLI .......................................... SUCCESS [2:35.102s]
> [INFO] Lens Examples ..................................... SUCCESS [8.986s]
> [INFO] Lens Distribution ................................. SUCCESS [8.258s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.531s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.706s]
> [INFO] Lens Regression ................................... SUCCESS [11.406s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:11.611s
> [INFO] Finished at: Sat Jun 20 02:46:48 UTC 2015
> [INFO] Final Memory: 174M/1458M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>