[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10444: IGNITE-14350 Added distributed property to disable CDC.

[GitBox <gi...@apache.org>]

NSAmelchev commented on code in PR #10444:
URL: https://github.com/apache/ignite/pull/10444#discussion_r1052129809


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java:
##########
@@ -2118,7 +2141,7 @@ public SegmentArchiveResult archiveSegment(long absIdx) throws StorageException
 
                 Files.move(dstTmpFile.toPath(), dstFile.toPath());
 
-                if (walCdcDir != null)
+                if (walCdcDir != null && !cdcForceDisable.getOrDefault(false))

Review Comment:
   Done.



##########
modules/core/src/main/java/org/apache/ignite/internal/cluster/DistributedConfigurationUtils.java:
##########
@@ -33,8 +33,10 @@
  * Distributed configuration utilities methods.
  */
 public final class DistributedConfigurationUtils {
-    /**
-     */
+    /** Distributed property update message. */
+    public static final String PROPERTY_UPDATE_MSG = "Distributed property '%s' was changed from '%s' to '%s'.";

Review Comment:
   Done.



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java:
##########
@@ -220,6 +224,9 @@ public class FileWriteAheadLogManager extends GridCacheSharedManagerAdapter impl
     /** @see IgniteSystemProperties#IGNITE_THRESHOLD_WAIT_TIME_NEXT_WAL_SEGMENT */
     public static final long DFLT_THRESHOLD_WAIT_TIME_NEXT_WAL_SEGMENT = 1000L;
 
+    /** CDC force disable distributed property name. */
+    public static final String CDC_FORCE_DISABLE = "cdc.forceDisable";

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org