You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "wgtmac (via GitHub)" <gi...@apache.org> on 2026/05/25 08:30:07 UTC

[PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

wgtmac opened a new pull request, #3799:
URL: https://github.com/apache/avro/pull/3799

   ## What is the purpose of the change
   
   - Bump fmt to 12.1.0 to fix build under higher version of AppleClang: https://github.com/apache/iceberg-cpp/pull/670
   - Fix fmt is not exposed as an install interface.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #3799:
URL: https://github.com/apache/avro/pull/3799#discussion_r3298163667


##########
lang/c++/CMakeLists.txt:
##########
@@ -89,7 +89,7 @@ if (NOT fmt_FOUND)
     FetchContent_Declare(
             fmt
             GIT_REPOSITORY  https://github.com/fmtlib/fmt.git
-            GIT_TAG         10.2.1
+            GIT_TAG         12.1.0

Review Comment:
   Good catch! TBH, I still prefer https://github.com/apache/avro/pull/3788.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on PR #3799:
URL: https://github.com/apache/avro/pull/3799#issuecomment-4532830231

   @martin-g @thiru-mg Could you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #3799:
URL: https://github.com/apache/avro/pull/3799#discussion_r3297917327


##########
lang/c++/CMakeLists.txt:
##########
@@ -89,7 +89,7 @@ if (NOT fmt_FOUND)
     FetchContent_Declare(
             fmt
             GIT_REPOSITORY  https://github.com/fmtlib/fmt.git
-            GIT_TAG         10.2.1
+            GIT_TAG         12.1.0

Review Comment:
   The CI checks pass but
   * https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L50
   * https://github.com/fmtlib/fmt/blob/12.1.0/CMakeLists.txt#L71-L72
   say that it needs C++20.
   I guess the build will break with an older C++ compiler (that does not support 20).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on code in PR #3799:
URL: https://github.com/apache/avro/pull/3799#discussion_r3298275525


##########
lang/c++/CMakeLists.txt:
##########
@@ -89,7 +89,7 @@ if (NOT fmt_FOUND)
     FetchContent_Declare(
             fmt
             GIT_REPOSITORY  https://github.com/fmtlib/fmt.git
-            GIT_TAG         10.2.1
+            GIT_TAG         12.1.0

Review Comment:
   me too!
   Just split it in two PRs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac commented on code in PR #3799:
URL: https://github.com/apache/avro/pull/3799#discussion_r3298645968


##########
lang/c++/CMakeLists.txt:
##########
@@ -89,7 +89,7 @@ if (NOT fmt_FOUND)
     FetchContent_Declare(
             fmt
             GIT_REPOSITORY  https://github.com/fmtlib/fmt.git
-            GIT_TAG         10.2.1
+            GIT_TAG         12.1.0

Review Comment:
   Split the C++20 bump first: https://github.com/apache/avro/pull/3800



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] AVRO-4264: [C++] Bump vendored fmt to 12.1.0 [avro]

Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac closed pull request #3799: AVRO-4264: [C++] Bump vendored fmt to 12.1.0
URL: https://github.com/apache/avro/pull/3799


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org