You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rave.apache.org by Erin Noe-Payne <er...@mitre.org> on 2012/10/04 22:45:10 UTC

Review Request: RAVE-808: Add ability to hide / show a widget

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7447/
-----------------------------------------------------------

Review request for rave.


Description
-------

Adds rave.hideWidget and rave.showWidget functions to hide a widget and it's chrome so that it takes up zero space on a page. Also registers these as rpc functions so that a widget can show or hide itself.


This addresses bug RAVE-808.
    https://issues.apache.org/jira/browse/RAVE-808


Diffs
-----

  trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1394161 
  trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js 1394161 

Diff: https://reviews.apache.org/r/7447/diff/


Testing
-------

Chrome, FF, IE 8 / 9


Thanks,

Erin Noe-Payne

Re: Review Request: RAVE-808: Add ability to hide / show a widget

Posted by Anthony Carlucci <ac...@mitre.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7447/#review12193
-----------------------------------------------------------

Ship it!


LGTM

- Anthony Carlucci


On Oct. 4, 2012, 8:45 p.m., Erin Noe-Payne wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7447/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 8:45 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Description
> -------
> 
> Adds rave.hideWidget and rave.showWidget functions to hide a widget and it's chrome so that it takes up zero space on a page. Also registers these as rpc functions so that a widget can show or hide itself.
> 
> 
> This addresses bug RAVE-808.
>     https://issues.apache.org/jira/browse/RAVE-808
> 
> 
> Diffs
> -----
> 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave.js 1394161 
>   trunk/rave-portal-resources/src/main/webapp/static/script/rave_opensocial.js 1394161 
> 
> Diff: https://reviews.apache.org/r/7447/diff/
> 
> 
> Testing
> -------
> 
> Chrome, FF, IE 8 / 9
> 
> 
> Thanks,
> 
> Erin Noe-Payne
> 
>