You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/20 13:23:22 UTC
[GitHub] [arrow] pitrou commented on a change in pull request #6966: ARROW-8497: [Archery] Add missing components to build options
pitrou commented on a change in pull request #6966:
URL: https://github.com/apache/arrow/pull/6966#discussion_r411365701
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
+@click.option("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
+@click.option("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
+@click.option("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
Review comment:
Nit: no need to capitalize "filesystem".
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
Review comment:
"CSV"?
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
Review comment:
Nit: "Toggle"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
Review comment:
"Arrow" everywhere
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
+@click.option("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
Review comment:
"CUDA" (or "Cuda")
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
+@click.option("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
+@click.option("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
+@click.option("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
+@click.option("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
+@click.option("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
-@click.option("--with-plasma", default=False, type=BOOL,
+@click.option("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
+@click.option("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
+@click.option("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
+@click.option("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
Review comment:
"JSON"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
+@click.option("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
+@click.option("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
+@click.option("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
+@click.option("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
+@click.option("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
-@click.option("--with-plasma", default=False, type=BOOL,
+@click.option("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
+@click.option("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
+@click.option("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
+@click.option("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
+@click.option("--with-jni", default=None, type=BOOL,
+ help="Build the arrow JNI lib.")
+@click.option("--with-mimalloc", default=None, type=BOOL,
+ help="Build the arrow mimalloc based allocator.")
+@click.option("--with-parquet", default=None, type=BOOL,
+ help="Build with parquet file support.")
+@click.option("--with-plasma", default=None, type=BOOL,
help="Build with Plasma object store support.")
-@click.option("--with-flight", default=False, type=BOOL,
- help="Build with Flight rpc support.")
-@click.option("--with-compute", default=True, type=BOOL,
- help="Build with compute kernels support.")
-@click.option("--with-dataset", default=False, type=BOOL,
- help="Build with dataset support.")
-@click.option("--use-sanitizers", default=False, type=BOOL,
- help="Toggles ARROW_USE_*SAN sanitizers.")
-@click.option("--with-fuzzing", default=False, type=BOOL,
- help="Toggles ARROW_FUZZING.")
-@click.option("--use-gold-linker", default=True, type=BOOL,
- help="Toggles ARROW_USE_LD_GOLD option.")
+@click.option("--with-python", default=None, type=BOOL,
+ help="Build the arrow CPython extesions.")
+@click.option("--with-r", default=None, type=BOOL,
+ help="Build the arrow R extesions. This is not a cmake option, "
Review comment:
"extensions", "CMake"
##########
File path: dev/archery/archery/cli.py
##########
@@ -134,36 +134,72 @@ def _apply_options(cmd, options):
help="CMake's CMAKE_BUILD_TYPE")
@click.option("--warn-level", default="production", type=warn_level_type,
help="Controls compiler warnings -W(no-)error.")
-# components
+@click.option("--use-gold-linker", default=True, type=BOOL,
+ help="Toggles ARROW_USE_LD_GOLD option.")
+# Tests and benchmarks
@click.option("--with-tests", default=True, type=BOOL,
help="Build with tests.")
-@click.option("--with-benchmarks", default=False, type=BOOL,
+@click.option("--with-benchmarks", default=None, type=BOOL,
help="Build with benchmarks.")
-@click.option("--with-examples", default=False, type=BOOL,
+@click.option("--with-examples", default=None, type=BOOL,
help="Build with examples.")
-@click.option("--with-python", default=False, type=BOOL,
- help="Build with python extension.")
-@click.option("--with-parquet", default=False, type=BOOL,
- help="Build with parquet file support.")
-@click.option("--with-gandiva", default=False, type=BOOL,
+@click.option("--with-integration", default=None, type=BOOL,
+ help="Build with integration test executables.")
+# Static checks
+@click.option("--use-asan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_ASAN sanitizer.")
+@click.option("--use-tsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_TSAN sanitizer.")
+@click.option("--use-ubsan", default=None, type=BOOL,
+ help="Toggles ARROW_USE_UBSAN sanitizer.")
+@click.option("--with-fuzzing", default=None, type=BOOL,
+ help="Toggles ARROW_FUZZING.")
+# Components
+@click.option("--with-compute", default=None, type=BOOL,
+ help="Build the arrow compute module.")
+@click.option("--with-csv", default=None, type=BOOL,
+ help="Build the arrow csv parser module.")
+@click.option("--with-cuda", default=None, type=BOOL,
+ help="Build the arrow cuda parser module.")
+@click.option("--with-dataset", default=None, type=BOOL,
+ help="Build the arrow dataset module.")
+@click.option("--with-filesystem", default=None, type=BOOL,
+ help="Build the arrow FileSystem layer.")
+@click.option("--with-flight", default=None, type=BOOL,
+ help="Build with Flight rpc support.")
+@click.option("--with-gandiva", default=None, type=BOOL,
help="Build with Gandiva expression compiler support.")
-@click.option("--with-plasma", default=False, type=BOOL,
+@click.option("--with-hdfs", default=None, type=BOOL,
+ help="Build the arrow HDFS bridge.")
+@click.option("--with-hiveserver2", default=None, type=BOOL,
+ help="Build the HiveServer2 client and arrow adapater.")
+@click.option("--with-ipc", default=None, type=BOOL,
+ help="Build the arrow IPC extensions.")
+@click.option("--with-json", default=None, type=BOOL,
+ help="Build the arrow json parser module.")
+@click.option("--with-jni", default=None, type=BOOL,
+ help="Build the arrow JNI lib.")
+@click.option("--with-mimalloc", default=None, type=BOOL,
+ help="Build the arrow mimalloc based allocator.")
+@click.option("--with-parquet", default=None, type=BOOL,
+ help="Build with parquet file support.")
Review comment:
"Parquet"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org