You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/03 13:39:00 UTC

[jira] [Commented] (AIRFLOW-6357) Graph UI nodes hightlight is broken when task id contains dots

    [ https://issues.apache.org/jira/browse/AIRFLOW-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17028946#comment-17028946 ] 

ASF subversion and git services commented on AIRFLOW-6357:
----------------------------------------------------------

Commit a2c644fb1a0461c23c4e7d8364b9815526e3be1c in airflow's branch refs/heads/v1-10-test from Igor Khrol
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=a2c644f ]

[AIRFLOW-6357] Highlight nodes in Graph UI if task id contains dots (#6904)


> Graph UI nodes hightlight is broken when task id contains dots
> --------------------------------------------------------------
>
>                 Key: AIRFLOW-6357
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6357
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.7
>            Reporter: Igor Khrol
>            Assignee: Igor Khrol
>            Priority: Minor
>             Fix For: 1.10.8
>
>
> If task id contains a dot, Graph UI highlight is broken.
>  
> ```
> with DAG(dag_id='hightlight_test', start_date=airflow.utils.dates.days_ago(2)) as dag:
>  t1 = DummyOperator(task_id='t1')
>  t2 = DummyOperator(task_id='t2.t2')
>  t3 = DummyOperator(task_id='t3.t3')
>  t1 >> t2
>  t2 >> t3
> ```
>  
> If you hightlight nodes in this DAG the following stacktrace is in JS console:
>  
> graph?dag_id=daily_dag:1246 Uncaught TypeError: Cannot read property 'parentNode' of null
>  at graph?dag_id=daily_dag:1246
>  at Array.forEach (<anonymous>)
>  at highlight_nodes (graph?dag_id=daily_dag:1245)
>  at SVGGElement.<anonymous> (graph?dag_id=daily_dag:1253)
>  at SVGGElement.__onmouseover (d3.min.js:1)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)