You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zml1206 (via GitHub)" <gi...@apache.org> on 2024/11/11 03:07:01 UTC
[PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
zml1206 opened a new pull request, #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891
## What changes were proposed in this pull request?
(Fixes: \#7890)
## How was this patch tested?
local test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 merged PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891#issuecomment-2469439407
I'm not sure on this. @ulysses-you, could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891#issuecomment-2467143116
https://github.com/apache/incubator-gluten/issues/7890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on code in PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891#discussion_r1837396702
##########
gluten-ui/src/main/scala/org/apache/spark/sql/execution/ui/GlutenSQLAppStatusListener.scala:
##########
@@ -52,7 +52,7 @@ private class GlutenSQLAppStatusListener(conf: SparkConf, kvstore: ElementTracki
event.physicalPlanDescription,
event.fallbackNodeToReason.toSeq.sortBy(_._1)
)
- kvstore.write(uiData)
+ kvstore.write(uiData, checkTriggers = true)
Review Comment:
I'm afraid it would introduce overhead for driver since each aqe stage would post one event. I think fire the trigger at `onSQLExecutionStart` is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-7890][UI] Optimize cleanup gluten sql executions ui data [incubator-gluten]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on code in PR #7891:
URL: https://github.com/apache/incubator-gluten/pull/7891#discussion_r1837403851
##########
gluten-ui/src/main/scala/org/apache/spark/sql/execution/ui/GlutenSQLAppStatusListener.scala:
##########
@@ -52,7 +52,7 @@ private class GlutenSQLAppStatusListener(conf: SparkConf, kvstore: ElementTracki
event.physicalPlanDescription,
event.fallbackNodeToReason.toSeq.sortBy(_._1)
)
- kvstore.write(uiData)
+ kvstore.write(uiData, checkTriggers = true)
Review Comment:
That's a good suggestion for me, thank you, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org