You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Madhuvanthi Radhakrishnan <mr...@hortonworks.com> on 2017/03/16 20:55:48 UTC
Review Request 57703: Add a new property to yarn-site.xml
yarn.log.server.web-service.url
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57703/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Bugs: AMBARI-20469
https://issues.apache.org/jira/browse/AMBARI-20469
Repository: ambari
Description
-------
Add a new property to yarn-site.xml yarn.log.server.web-service.url
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4
ambari-server/src/main/resources/stacks/stack_advisor.py 0b81700
Diff: https://reviews.apache.org/r/57703/diff/1/
Testing
-------
From https://reviews.apache.org/r/57672/
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57703: Add a new property to yarn-site.xml
yarn.log.server.web-service.url
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57703/#review169224
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
Lines 466 (patched)
<https://reviews.apache.org/r/57703/#comment241563>
The if should first check the policy value, and then decide if the non-https or https config needs to exist.
This could cause a bug if http is used but the https config doesn't exist.
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py
Lines 1769 (patched)
<https://reviews.apache.org/r/57703/#comment241564>
Let's be robust and use default("...", None)
and explicitly check for == "HTTP" or == "HTTPS"
- Alejandro Fernandez
On March 16, 2017, 9:08 p.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57703/
> -----------------------------------------------------------
>
> (Updated March 16, 2017, 9:08 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20469
> https://issues.apache.org/jira/browse/AMBARI-20469
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a new property to yarn-site.xml yarn.log.server.web-service.url
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f
>
>
> Diff: https://reviews.apache.org/r/57703/diff/2/
>
>
> Testing
> -------
>
> From https://reviews.apache.org/r/57672/
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57703: Add a new property to yarn-site.xml
yarn.log.server.web-service.url
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57703/#review169232
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 17, 2017, 12:24 a.m., Madhuvanthi Radhakrishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57703/
> -----------------------------------------------------------
>
> (Updated March 17, 2017, 12:24 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20469
> https://issues.apache.org/jira/browse/AMBARI-20469
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a new property to yarn-site.xml yarn.log.server.web-service.url
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f
>
>
> Diff: https://reviews.apache.org/r/57703/diff/3/
>
>
> Testing
> -------
>
> From https://reviews.apache.org/r/57672/
>
>
> Thanks,
>
> Madhuvanthi Radhakrishnan
>
>
Re: Review Request 57703: Add a new property to yarn-site.xml
yarn.log.server.web-service.url
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57703/
-----------------------------------------------------------
(Updated March 17, 2017, 12:24 a.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
reviwe comments
Bugs: AMBARI-20469
https://issues.apache.org/jira/browse/AMBARI-20469
Repository: ambari
Description
-------
Add a new property to yarn-site.xml yarn.log.server.web-service.url
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f
Diff: https://reviews.apache.org/r/57703/diff/3/
Changes: https://reviews.apache.org/r/57703/diff/2-3/
Testing
-------
From https://reviews.apache.org/r/57672/
Thanks,
Madhuvanthi Radhakrishnan
Re: Review Request 57703: Add a new property to yarn-site.xml
yarn.log.server.web-service.url
Posted by Madhuvanthi Radhakrishnan <mr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57703/
-----------------------------------------------------------
(Updated March 16, 2017, 9:08 p.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Moved changes from stack_advisor to service_advisor
Bugs: AMBARI-20469
https://issues.apache.org/jira/browse/AMBARI-20469
Repository: ambari
Description
-------
Add a new property to yarn-site.xml yarn.log.server.web-service.url
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/configuration/yarn-site.xml dd5e9a4
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 4fdf84f
Diff: https://reviews.apache.org/r/57703/diff/2/
Changes: https://reviews.apache.org/r/57703/diff/1-2/
Testing
-------
From https://reviews.apache.org/r/57672/
Thanks,
Madhuvanthi Radhakrishnan