You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Varun Ratnakar <va...@gmail.com> on 2014/11/04 23:40:11 UTC

Re: Review Request 15936: OODT 563 - a) Modifying Workflow Manager to allow adding new workflows

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15936/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 10:40 p.m.)


Review request for oodt and Chris Mattmann.


Bugs: OODT-563
    https://issues.apache.org/jira/browse/OODT-563


Repository: oodt


Description
-------

This patch addresses a part of https://issues.apache.org/jira/browse/OODT-563. It provides:

1. Additions to XmlRpcWorkflowManager(Client) to refreshRepository (i.e. reload repository)
2. Modifications to PackagedWorkflowRepository's addWorkflow function to properly deal with added workflows


Diffs (updated)
-----

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java 1636677 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1636677 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1636677 

Diff: https://reviews.apache.org/r/15936/diff/


Testing
-------


Thanks,

Varun Ratnakar


Re: Review Request 15936: OODT 563 - a) Modifying Workflow Manager to allow adding new workflows

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15936/#review60028
-----------------------------------------------------------


Awesome @Varun!

- Chris Mattmann


On Nov. 4, 2014, 11:12 p.m., Varun Ratnakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15936/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:12 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-563
>     https://issues.apache.org/jira/browse/OODT-563
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> This patch addresses a part of https://issues.apache.org/jira/browse/OODT-563. It provides:
> 
> 1. Additions to XmlRpcWorkflowManager(Client) to refreshRepository (i.e. reload repository)
> 2. Modifications to PackagedWorkflowRepository's addWorkflow function to properly deal with added workflows
> 
> 
> Diffs
> -----
> 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java 1636677 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1636677 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1636677 
> 
> Diff: https://reviews.apache.org/r/15936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Varun Ratnakar
> 
>


Re: Review Request 15936: OODT 563 - a) Modifying Workflow Manager to allow adding new workflows

Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15936/#review60026
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Mattmann


On Nov. 4, 2014, 11:12 p.m., Varun Ratnakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15936/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2014, 11:12 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-563
>     https://issues.apache.org/jira/browse/OODT-563
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> This patch addresses a part of https://issues.apache.org/jira/browse/OODT-563. It provides:
> 
> 1. Additions to XmlRpcWorkflowManager(Client) to refreshRepository (i.e. reload repository)
> 2. Modifications to PackagedWorkflowRepository's addWorkflow function to properly deal with added workflows
> 
> 
> Diffs
> -----
> 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java 1636677 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1636677 
>   trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1636677 
> 
> Diff: https://reviews.apache.org/r/15936/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Varun Ratnakar
> 
>


Re: Review Request 15936: OODT 563 - a) Modifying Workflow Manager to allow adding new workflows

Posted by Varun Ratnakar <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15936/
-----------------------------------------------------------

(Updated Nov. 4, 2014, 11:12 p.m.)


Review request for oodt and Chris Mattmann.


Bugs: OODT-563
    https://issues.apache.org/jira/browse/OODT-563


Repository: oodt


Description
-------

This patch addresses a part of https://issues.apache.org/jira/browse/OODT-563. It provides:

1. Additions to XmlRpcWorkflowManager(Client) to refreshRepository (i.e. reload repository)
2. Modifications to PackagedWorkflowRepository's addWorkflow function to properly deal with added workflows


Diffs (updated)
-----

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java 1636677 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1636677 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1636677 

Diff: https://reviews.apache.org/r/15936/diff/


Testing
-------


Thanks,

Varun Ratnakar