You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Jacobo Tarrío <jt...@gmail.com> on 2011/08/25 02:37:01 UTC
Review Request: Generate and check ETags using the proper syntax
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1648/
-----------------------------------------------------------
Review request for shindig and johnfargo.
Summary
-------
According to the RFC, ETags have to be in quote signs. Also, the If-None-Matches header can specify several ETags, separated with commas. This has been added to the ETaggingHttpResponse. No weak ETag generation or checking, though.
Diffs
-----
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java 1161302
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETagFilterTest.java 1161302
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponseTest.java 1161302
Diff: https://reviews.apache.org/r/1648/diff
Testing
-------
Thanks,
Jacobo
Re: Review Request: Generate and check ETags using the proper syntax
Posted by jo...@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1648/#review1623
-----------------------------------------------------------
Ship it!
Good cleanups and fixes. Multiple Etags eh... Etag = the new, lighter cookie.
- johnfargo
On 2011-08-25 00:37:01, Jacobo Tarrío wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1648/
> -----------------------------------------------------------
>
> (Updated 2011-08-25 00:37:01)
>
>
> Review request for shindig and johnfargo.
>
>
> Summary
> -------
>
> According to the RFC, ETags have to be in quote signs. Also, the If-None-Matches header can specify several ETags, separated with commas. This has been added to the ETaggingHttpResponse. No weak ETag generation or checking, though.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java 1161302
> trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETagFilterTest.java 1161302
> trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponseTest.java 1161302
>
> Diff: https://reviews.apache.org/r/1648/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacobo
>
>
Re: Review Request: Generate and check ETags using the proper syntax
Posted by Henry Saputra <he...@gmail.com>.
Hi Jacobo,
Could you please create a JIRA issue for this and attach the patch or
link the review to it.
Thanks,
- Henry
On Wed, Aug 24, 2011 at 5:37 PM, Jacobo Tarrío <jt...@gmail.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1648/
> -----------------------------------------------------------
>
> Review request for shindig and johnfargo.
>
>
> Summary
> -------
>
> According to the RFC, ETags have to be in quote signs. Also, the If-None-Matches header can specify several ETags, separated with commas. This has been added to the ETaggingHttpResponse. No weak ETag generation or checking, though.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponse.java 1161302
> trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETagFilterTest.java 1161302
> trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ETaggingHttpResponseTest.java 1161302
>
> Diff: https://reviews.apache.org/r/1648/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jacobo
>
>