[GitHub] [pinot] richardstartin commented on a change in pull request #7820: push JSON Path evaluation down to storage layer

[GitBox <gi...@apache.org>]

richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r755551967



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##########
@@ -120,6 +121,17 @@ public int getNumDocs() {
     return intValues;
   }
 
+  /**
+   * Get the int values for a single-valued column.
+   *
+   * @param column Column name
+   * @param evaluator JSON path evaluator
+   * @param buffer values to fill
+   */
+  public void fillValues(String column, JsonPathEvaluator evaluator, int[] buffer) {

Review comment:
       I believe in the rule of 3: create a generic abstraction once you have three implementations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org