You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/30 12:51:58 UTC

[GitHub] [superset] villebro commented on a change in pull request #16906: fix: Inclusive sign in time range display

villebro commented on a change in pull request #16906:
URL: https://github.com/apache/superset/pull/16906#discussion_r719372567



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -1035,6 +1035,7 @@ const FiltersConfigForm = (
                     >
                       <DateFilterControl
                         name="time_range"
+                        endpoints={['inclusive', 'exclusive']}

Review comment:
       Do you think it would make sense placing `DEFAULT_TIME_RANGE_ENDPOINTS = ['inclusive', 'exclusive']` under `src/constants.ts` and then using that here and on the other place?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org