[openjpa] 02/04: connection handling fixed

[st...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

struberg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/openjpa.git

commit 5b46dcc191a0cb104013f59c60a61c572bd756f3
Author: Mark Struberg <st...@apache.org>
AuthorDate: Thu Apr 1 16:46:42 2021 +0200

    connection handling fixed
    
    Connection was set to autoCommit, so no commit or rollback possible
---
 .../java/org/apache/openjpa/jdbc/oracle/TestOracleXmlColumn.java     | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/oracle/TestOracleXmlColumn.java b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/oracle/TestOracleXmlColumn.java
index 6dadba3..bb693dc 100644
--- a/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/oracle/TestOracleXmlColumn.java
+++ b/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/jdbc/oracle/TestOracleXmlColumn.java
@@ -32,6 +32,7 @@ import org.apache.openjpa.jdbc.sql.OracleDictionary;
 import org.apache.openjpa.persistence.OpenJPAEntityManagerFactorySPI;
 import org.apache.openjpa.persistence.test.AbstractPersistenceTestCase;
 
+
 public class TestOracleXmlColumn extends AbstractPersistenceTestCase {
 
     private static String projectStr = "project";
@@ -62,14 +63,13 @@ public class TestOracleXmlColumn extends AbstractPersistenceTestCase {
         // the mapping tool doesn't handle creating XML columns that map to strings
         // build table manually
         Connection con = ((DataSource) conf.getConnectionFactory()).getConnection();
+        con.setAutoCommit(true);
         Statement stmt = con.createStatement();
         String ddl = "DROP TABLE XmlColEntity";
         try {
             stmt.execute(ddl);
-            con.commit();
         } catch (SQLException se) {
             // assume the table did not exist.
-            con.rollback();
         }
 
         ddl =
@@ -78,7 +78,6 @@ public class TestOracleXmlColumn extends AbstractPersistenceTestCase {
         stmt.execute(ddl);
         String insertSql = "INSERT into XmlColEntity (ID, XMLCOLUMN, VERSION) VALUES (42, '" + xmlData + "', 1)";
         stmt.execute(insertSql);
-        con.commit();
 
         stmt.close();
         con.close();