You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/30 20:49:21 UTC

[GitHub] [geode-native] mivanac opened a new pull request #736: GEODE-8872: added API impacts to native client

mivanac opened a new pull request #736:
URL: https://github.com/apache/geode-native/pull/736


   Native client impacts for ticket GEODE-8872


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey commented on pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #736:
URL: https://github.com/apache/geode-native/pull/736#issuecomment-830288602


   @mivanac what's the current status of this one?  Looks like Jake's last concern still needs to be addressed, and CI jobs haven't been run.  Pushing an empty commit should wake up CI...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] mivanac commented on pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
mivanac commented on pull request #736:
URL: https://github.com/apache/geode-native/pull/736#issuecomment-830292508


   This PR is currently paused, since PR for java (server) impacts is currently blocked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on a change in pull request #736:
URL: https://github.com/apache/geode-native/pull/736#discussion_r624095113



##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -123,7 +124,8 @@ std::shared_ptr<Serializable> ThinClientLocatorHelper::sendRequest(
     auto conn = createConnection(location);
     auto data =
         m_poolDM->getConnectionManager().getCacheImpl()->createDataOutput();
-    data.writeInt(static_cast<int32_t>(1001));  // GOSSIPVERSION
+    data.writeInt(static_cast<int32_t>(1002));  // GOSSIPVERSION
+    data.writeInt(static_cast<int16_t>(125));   // GEODE 1.14.0

Review comment:
       Reolving - this change has been removed, and the code on `develop` uses `Version::getOrdinal()` as expected.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on a change in pull request #736:
URL: https://github.com/apache/geode-native/pull/736#discussion_r568006417



##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -123,7 +124,8 @@ std::shared_ptr<Serializable> ThinClientLocatorHelper::sendRequest(
     auto conn = createConnection(location);
     auto data =
         m_poolDM->getConnectionManager().getCacheImpl()->createDataOutput();
-    data.writeInt(static_cast<int32_t>(1001));  // GOSSIPVERSION
+    data.writeInt(static_cast<int32_t>(1002));  // GOSSIPVERSION

Review comment:
       Let's move this GOSSIPVERSION to a constant somewhere

##########
File path: clicache/src/PoolFactory.cpp
##########
@@ -425,6 +425,26 @@ namespace Apache
 	   }
 
 
+      PoolFactory^ PoolFactory::SetRequestLocatorInternalAddress( bool requestInternal )
+      {
+			  _GF_MG_EXCEPTION_TRY2/* due to auto replace */

Review comment:
       C++/CLI formatting looks a bit off.

##########
File path: cppcache/src/ThinClientLocatorHelper.cpp
##########
@@ -123,7 +124,8 @@ std::shared_ptr<Serializable> ThinClientLocatorHelper::sendRequest(
     auto conn = createConnection(location);
     auto data =
         m_poolDM->getConnectionManager().getCacheImpl()->createDataOutput();
-    data.writeInt(static_cast<int32_t>(1001));  // GOSSIPVERSION
+    data.writeInt(static_cast<int32_t>(1002));  // GOSSIPVERSION
+    data.writeInt(static_cast<int16_t>(125));   // GEODE 1.14.0

Review comment:
       Use `Version::getOrdinal()`. You will need to update the ordinal to 1.14.0. This also means any protocol changes from 1.0.0, the current value, to 1.14.0 need to be implemented.

##########
File path: cppcache/src/LocatorListRequest.hpp
##########
@@ -34,13 +34,16 @@ class Serializable;
 class LocatorListRequest : public ServerLocationRequest {
  private:
   std::string m_servergroup;
+  bool m_requestInternalAddress;
 
  public:
-  explicit LocatorListRequest(const std::string& servergroup = "");
+  explicit LocatorListRequest(const std::string& servergroup = "",

Review comment:
       I suspect this signature has some really strange undefined behavior and now might be a time to fix it. We should probably go a step further and fix the default value assigned to a `std::string` reference. I think the keyword `explicit` can be dropped now since there is more than one argument. Maybe we default the first argument can convert but.. 🤷  What does clang-tidy say?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] mivanac closed pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
mivanac closed pull request #736:
URL: https://github.com/apache/geode-native/pull/736


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [geode-native] pdxcodemonkey commented on pull request #736: GEODE-8872: added API impacts to native client

Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #736:
URL: https://github.com/apache/geode-native/pull/736#issuecomment-830317968


   Should we close or convert to draft again, then?  I'd like to get to a state where we don't have PRs hanging around for weeks and weeks...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org