You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2016/06/15 13:26:31 UTC
[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/718
TS-4543: Fix core in HttpSM::tunnel_handler_post.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4543
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #718
----
commit 439a20885d6519d6c1508ed96493fa1a33902172
Author: shinrich <sh...@localhost.localdomain>
Date: 2016-06-15T13:24:26Z
TS-4543: Fix core in HttpSM::tunnel_handler_post.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/718#discussion_r67816840
--- Diff: proxy/http/HttpSM.cc ---
@@ -2841,9 +2844,9 @@ HttpSM::tunnel_handler_push(int event, void *data)
ink_assert(data == &tunnel);
// Check to see if the client is still around
- HttpTunnelProducer *ua = tunnel.get_producer(ua_session);
+ HttpTunnelProducer *ua = (ua_session) ? tunnel.get_producer(ua_session) : tunnel.get_producer(HT_HTTP_CLIENT);
- if (!ua->read_success) {
+ if (ua && !ua->read_success) {
--- End diff --
compare to the modify in tunnel_handler_post, can we use "if (!ua || !ua->read_success) {" here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #718: TS-4543: Fix core in HttpSM::tunnel_handler_post.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/718
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/286/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/718
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/718#discussion_r67817437
--- Diff: proxy/http/HttpSM.cc ---
@@ -2722,7 +2722,10 @@ HttpSM::tunnel_handler_post(int event, void *data)
{
STATE_ENTER(&HttpSM::tunnel_handler_post, event);
- HttpTunnelProducer *p = tunnel.get_producer(ua_session);
+ HttpTunnelProducer *p = ua_session != NULL ? tunnel.get_producer(ua_session) : tunnel.get_producer(HT_HTTP_CLIENT);
+ if (!p)
+ return 0; // Cannot do anything if there is no producer
--- End diff --
Do we have to set terminate_sm = true before return 0 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #718: TS-4543: Fix core in HttpSM::tunnel_handler_post.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/718
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/178/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---