[GitHub] [flink] bowenli86 commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…
URL: https://github.com/apache/flink/pull/8312#discussion_r279494274
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/exceptions/PartitionSpecInvalidException.java
 ##########
 @@ -29,15 +29,14 @@
  * when the size of PartitionSpec is 'n' but its keys don't match the first 'n' keys in partition key list.
  */
 public class PartitionSpecInvalidException extends Exception {
-	private static final String MSG = "PartitionSpec %s does not match partition keys %s of table %s in catalog %s.";
+	private static final String MSG = "PartitionSpec %s does not match the partition keys of table %s in catalog %s.";
 
 Review comment:
   how about adding back the partition keys to give use adequate information of why the exception is thrown?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services