You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/29 07:48:34 UTC
[GitHub] [spark] wangyum opened a new pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
wangyum opened a new pull request #30960:
URL: https://github.com/apache/spark/pull/30960
### What changes were proposed in this pull request?
This pr fix remove the CaseWhen if elseValue is empty and other outputs are null because of we should consider deterministic.
### Why are the changes needed?
Fix bug.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752023363
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38072/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751990802
We need to fix https://github.com/apache/spark/pull/30852/files#diff-9723970916a34149cbb2e3a2853614e523a8a00d5a126926c54f23b4b758e3baR96 as well.
To simplify the code, I'd suggest we also turn unspecified else value into false in the rule `ReplaceNullWithFalseInPredicate`. It's idempotent and should not have a real perf impact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752098998
This is definitely not related to Spark R. Mering to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752092506
**[Test build #133483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133483/testReport)** for PR 30960 at commit [`41a8fed`](https://github.com/apache/spark/commit/41a8fed86cddb0ea381aa387de7da7a24ff3fe4b).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752004111
**[Test build #133483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133483/testReport)** for PR 30960 at commit [`41a8fed`](https://github.com/apache/spark/commit/41a8fed86cddb0ea381aa387de7da7a24ff3fe4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752004111
**[Test build #133483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133483/testReport)** for PR 30960 at commit [`41a8fed`](https://github.com/apache/spark/commit/41a8fed86cddb0ea381aa387de7da7a24ff3fe4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752023380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38072/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30960:
URL: https://github.com/apache/spark/pull/30960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752059801
**[Test build #133478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133478/testReport)** for PR 30960 at commit [`4c21e43`](https://github.com/apache/spark/commit/4c21e43ca34c33d1756406c94679f40959171a7d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751991632
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38067/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751991632
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38067/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752066615
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133478/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752015033
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38072/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752093166
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133483/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751990802
We need to fix https://github.com/apache/spark/pull/30852/files#diff-9723970916a34149cbb2e3a2853614e523a8a00d5a126926c54f23b4b758e3baR96 as well.
To simplify the code, I'd suggest we also turn unspecified else value into false in the rule `ReplaceNullWithFalseInPredicate`. It's idempotent and should not have a real perf impact even if there is no following optimizations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752023380
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38072/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752066615
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133478/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751986965
**[Test build #133478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133478/testReport)** for PR 30960 at commit [`4c21e43`](https://github.com/apache/spark/commit/4c21e43ca34c33d1756406c94679f40959171a7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751986965
**[Test build #133478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133478/testReport)** for PR 30960 at commit [`4c21e43`](https://github.com/apache/spark/commit/4c21e43ca34c33d1756406c94679f40959171a7d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-751984460
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30960: [SPARK-33847][SQL][FOLLOWUP] Remove the CaseWhen should consider deterministic
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30960:
URL: https://github.com/apache/spark/pull/30960#issuecomment-752093166
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133483/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org