You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/30 10:53:21 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
jerpelea opened a new pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335
## Summary
This camera example grabs a specified number of pictures
and saves them on the available storage
## Impact
Spresense board
## Testing
built for Spresense board
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-652605913
I restarted the checks multiple times but the issue persists. I pulled this change locally, it builds cleanly. Also my refresh.sh does not produce a different `defconfig`.
But here CONFIG_EXAMPLE_CAMERA is not recognized as new option and removed from this `defconfig` when refresh.sh does `oldconfig`.
And, yes the checks are pulling the latest apps/.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651857422
@Ouss4 the config was updated with savedefconfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651719885
@masayuki2009
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-655859508
Fixed here: #1389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#discussion_r451927390
##########
File path: boards/arm/cxd56xx/spresense/configs/example_camera/defconfig
##########
@@ -0,0 +1,95 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_CXD56_I2C0_SCUSEQ is not set
+# CONFIG_MMCSD_HAVE_WRITEPROTECT is not set
+# CONFIG_MMCSD_SPI is not set
+# CONFIG_MTD_SMART_WEAR_LEVEL is not set
+# CONFIG_STANDARD_SERIAL is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="spresense"
+CONFIG_ARCH_BOARD_SPRESENSE=y
+CONFIG_ARCH_CHIP="cxd56xx"
+CONFIG_ARCH_CHIP_CXD56XX=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_ARMV7M_USEBASEPRI=y
+CONFIG_BOARD_LOOPSPERMSEC=5434
+CONFIG_BOOT_RUNFROMISRAM=y
+CONFIG_BUILTIN=y
+CONFIG_CLOCK_MONOTONIC=y
+CONFIG_CXD56_BINARY=y
+CONFIG_CXD56_CISIF=y
+CONFIG_CXD56_I2C0=y
+CONFIG_CXD56_I2C2=y
+CONFIG_CXD56_I2C=y
+CONFIG_CXD56_SDIO=y
+CONFIG_CXD56_SPI4=y
+CONFIG_CXD56_SPI5=y
+CONFIG_CXD56_SPI=y
+CONFIG_CXD56_USBDEV=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DRIVERS_VIDEO=y
+CONFIG_EXAMPLES_CAMERA=y
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FAT_MAXFNAME=255
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_PROCFS_REGISTER=y
+CONFIG_FS_SMARTFS=y
+CONFIG_HAVE_CXX=y
+CONFIG_HAVE_CXXINITIALIZE=y
+CONFIG_MAX_TASKS=16
+CONFIG_MAX_WDOGPARMS=2
+CONFIG_MMCSD=y
+CONFIG_MMCSD_SDIO=y
+CONFIG_MTD_BYTE_WRITE=y
+CONFIG_MTD_PARTITION=y
+CONFIG_MTD_SMART=y
+CONFIG_MTD_SMART_ENABLE_CRC=y
+CONFIG_MTD_SMART_SECTOR_SIZE=4096
+CONFIG_NAME_MAX=765
+CONFIG_NFILE_DESCRIPTORS=8
+CONFIG_NFILE_STREAMS=8
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_READLINE=y
+CONFIG_PREALLOC_MQ_MSGS=4
+CONFIG_PREALLOC_TIMERS=4
+CONFIG_PREALLOC_WDOGS=16
+CONFIG_RAM_SIZE=1572864
+CONFIG_RAM_START=0x0d000000
+CONFIG_READLINE_CMD_HISTORY=y
+CONFIG_RR_INTERVAL=200
+CONFIG_RTC=y
+CONFIG_RTC_DRIVER=y
+CONFIG_SCHED_WAITPID=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SMARTFS_ALIGNED_ACCESS=y
+CONFIG_SMARTFS_MAXNAMLEN=30
+CONFIG_SMARTFS_MULTI_ROOT_DIRS=y
+CONFIG_SPECIFIC_DRIVERS=y
+CONFIG_SPI=y
+CONFIG_SPRESENSE_EXTENSION=y
+CONFIG_START_DAY=6
+CONFIG_START_MONTH=12
+CONFIG_START_YEAR=2011
+CONFIG_SYSTEM_CLE=y
+CONFIG_SYSTEM_NSH=y
+CONFIG_SYSTEM_NSH_CXXINITIALIZE=y
Review comment:
don't exist any more. Please see this PR:
https://github.com/apache/incubator-nuttx-apps/pull/316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-652107208
> I suspect that if fails because the example app is not merged in the app git
>
> [apache/incubator-nuttx-apps#314](https://github.com/apache/incubator-nuttx-apps/pull/314)
I've just merged the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 merged pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-655860057
>don't exist any more. Please see this PR:
>apache/incubator-nuttx-apps#316
I think so too.
```
$ make savedefconfig
$ diff -c defconfig ./boards/arm/cxd56xx/spresense/configs/example_camera/defconfig
*** defconfig 2020-07-09 11:28:50.523639892 +0900
--- ./boards/arm/cxd56xx/spresense/configs/example_camera/defconfig 2020-07-09 08:00:04.022527937 +0900
***************
*** 81,86 ****
--- 81,87 ----
CONFIG_START_YEAR=2011
CONFIG_SYSTEM_CLE=y
CONFIG_SYSTEM_NSH=y
+ CONFIG_SYSTEM_NSH_CXXINITIALIZE=y
CONFIG_SYSTEM_USBMSC=y
CONFIG_UART1_SERIAL_CONSOLE=y
CONFIG_USBDEV=y
```
I will send a new PR to fix this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-656523188
@xiaoxiang781216 thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-656513972
@masayuki2009 @xiaoxiang781216 thanks for looking into it
I wonder why savedefconfig did not fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-656516121
Because CONFIG_NSH_CXXINITIALIZE is justed remove a few day ago, your local copy mayn't contain this patch:
https://github.com/apache/incubator-nuttx-apps/pull/316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] MasayukiIshikawa removed a comment on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
MasayukiIshikawa removed a comment on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651735386
@jerpelea
Do you know why the build error happened?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651846745
> @jerpelea
> Do you know why the build error happened?
spresense/example_camera defconfig needs to be updated as well, with ./tools/refresh.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-654513883
@jerpelea @btashton What to do here? @jerpelea Would you like to rebase and give it another go?
The PR's change is safe, the rebase would just check if everything is working as supposed to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651736009
@jerpelea
Do you know why the build error happened?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] MasayukiIshikawa commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
MasayukiIshikawa commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651735386
@jerpelea
Do you know why the build error happened?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-652620004
I grabbed the source bundle from the CI and saw a bunch of these errors when running the build arm-01.dat test file. Maybe we can rebase this and see if it passes now that some of the other config flags have been fixed? This last build ran while there were still issues with apps and `CONFIG_SYSTEM_NSH_CXXINITIALIZE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-651846745
> @jerpelea
> Do you know why the build error happened?
spresense/example_camera defconfig needs to be updated as well:
`./tools/refresh.sh --silent spresense:example_camera`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-655809474
FYI, I merged this one to see how it would do once pushed to master and especially in the nightly build. So far not good, the same result in master (actually expected), let's see how things will go at night.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #1335: boards: arm: cxd56xx: enable basic snapshot camera example
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #1335:
URL: https://github.com/apache/incubator-nuttx/pull/1335#issuecomment-655839309
HEAD detached at pull/1388/merge
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: boards/arm/cxd56xx/spresense/configs/example_camera/defconfig
no changes added to commit (use "git add" and/or "git commit -a")
Configuring...
Copy files
Select CONFIG_HOST_LINUX=y
Refreshing...
Disabling CONFIG_ARMV7A_TOOLCHAIN_GNU_EABIL
Enabling CONFIG_ARMV7M_TOOLCHAIN_GNU_EABIL
Building NuttX...
Normalize sabre-6quad/nsh
HEAD detached at pull/1388/merge
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: boards/arm/cxd56xx/spresense/configs/example_camera/defconfig
no changes added to commit (use "git add" and/or "git commit -a")
====================================================================================
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org