[jira] [Comment Edited] (CALCITE-2617) FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down

["Ruben Quesada Lopez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646827#comment-16646827 ] 

Ruben Quesada Lopez edited comment on CALCITE-2617 at 10/11/18 6:00 PM:
------------------------------------------------------------------------

No problem [~zabetak], I can close my PR, your solution looks cleaner.
 As a side note, maybe we could take advantage of your refactoring and remove the
{code:java}
if (RexOver.containsOver(project.getProjects(), null)) 
  return;
{code}
from the {{onMatch}} method as pass it as a default {{projectPredicate}}? 


was (Author: rubenql):
No problem [~zabetak], I can close my PR, your solution looks cleaner

> FilterProjectTransposeRule should allow filter conditions with correlated variables to be pushed down
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-2617
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2617
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> The rule always forbids conditions with correlated variables to be pushed down (as of [CALCITE-769|https://issues.apache.org/jira/browse/CALCITE-769] to avoid certain problems in the decorrelation of the query). However, in the general context of query optimization, it is beneficial to push-down filters and the fact that there is a correlated variable is not a reason to skip this optimization. 
> In order to avoid regressions, and at the same time enable correlated conditions to be pushed down we should make the pushing of correlated variables configurable. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)