[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9058: ARROW-10996: [Rust] change return value type of get_arrow_schema_from_metadata()

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #9058:
URL: https://github.com/apache/arrow/pull/9058#discussion_r550747754



##########
File path: rust/parquet/src/arrow/schema.rs
##########
@@ -42,12 +42,17 @@ pub fn parquet_to_arrow_schema(
     key_value_metadata: &Option<Vec<KeyValue>>,
 ) -> Result<Schema> {
     let mut metadata = parse_key_value_metadata(key_value_metadata).unwrap_or_default();
-    let arrow_schema_metadata = metadata
+    let maybe_schema = metadata
         .remove(super::ARROW_SCHEMA_META_KEY)
         .map(|encoded| get_arrow_schema_from_metadata(&encoded));
 
+    let arrow_schema_metadata = match maybe_schema {

Review comment:
       There may be an idiom for this in rust (that I do not know).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org