You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "chesnokoff (via GitHub)" <gi...@apache.org> on 2026/06/22 14:48:00 UTC

[PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

chesnokoff opened a new pull request, #13266:
URL: https://github.com/apache/ignite/pull/13266

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on PR #13266:
URL: https://github.com/apache/ignite/pull/13266#issuecomment-4808268654

   Confirmed with `./mvnw -f docs/_docs/code-snippets/java/pom.xml compile -B -V`; the snippets compile successfully with `ignite-cloud:2.13.0` and current `ignite-core:2.19.0-SNAPSHOT`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3474643392


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>

Review Comment:
   Yes, `ignite-cloud` was moved from the main Ignite repository to `ignite-extensions` as `ignite-cloud-ext`, but it looks like `ignite-cloud-ext` was never published to Maven Central. As a result, the only resolvable artifact containing `TcpDiscoveryCloudIpFinder` is the legacy `ignite-cloud:2.13.0`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on PR #13266:
URL: https://github.com/apache/ignite/pull/13266#issuecomment-4769910443

   Run 
   ```script
   ./mvnw -f docs/_docs/code-snippets/java/pom.xml compile -B -V
   ```
   to check compilation
   
   Also try to run checks on https://github.com/apache/ignite/pull/13257 before merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3474550963


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>

Review Comment:
   is it from extensions ? if so - why ver is hardcoded ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3480713263


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,48 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <!-- ignite-cloud-ext is not published to Maven Central, so use the last released legacy artifact that still provides TcpDiscoveryCloudIpFinder. -->
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>
+        </dependency>

Review Comment:
   Optional hardening — not blocking, the build is green as-is. `ignite-cloud:2.13.0` also drags a transitive `ignite-core:2.13.0` (plus jclouds 2.0.0 / guava 16.0.1) onto the gate classpath. Maven mediation already prefers the direct 2.19 core, but for a *blocking* gate it's worth excluding it explicitly so a second, 6-year-old core can never shadow 2.19:
   
   ```suggestion
               <exclusions>
                   <!-- Keep only the current ignite-core on the snippets classpath; this
                        legacy artifact otherwise also pulls in ignite-core:2.13.0. -->
                   <exclusion>
                       <groupId>${project.groupId}</groupId>
                       <artifactId>ignite-core</artifactId>
                   </exclusion>
               </exclusions>
           </dependency>
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3476172138


##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/Snapshots.java:
##########
@@ -28,7 +31,7 @@ void configuration() {
         //tag::config[]
         IgniteConfiguration cfg = new IgniteConfiguration();
 
-        File exSnpDir = U.resolveWorkDirectory(U.defaultWorkDirectory(), "ex_snapshots", true);
+        File exSnpDir = new File("work", "ex_snapshots");

Review Comment:
   Small doc-quality nit on the rendered output: this line lives inside `tag::config[]`, so it ships verbatim into `persistence/snapshot-directory.adoc`. `new File("work", "ex_snapshots")` is resolved against the process working directory, which *reads* like Ignite's work dir but isn't guaranteed to be it — the old `U.resolveWorkDirectory(...)` (rightly dropped, internal API) used to make that explicit. A one-line comment keeps the example unambiguous for readers:
   
   ```suggestion
           // Any directory the Ignite process can write to (example value).
           File exSnpDir = new File("work", "ex_snapshots");
   ```



##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/WarmUpStrategy.java:
##########
@@ -14,70 +14,91 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-//tag::warm-all-regions[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+package org.apache.ignite.snippets;
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.configuration.LoadAllWarmUpConfiguration;
+import org.apache.ignite.configuration.NoOpWarmUpConfiguration;
 
-//Changing the default warm-up strategy for all data regions
-storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());
+public class WarmUpStrategy {
+    public void warmAllRegions() {
+        //tag::warm-all-regions[]
+        IgniteConfiguration cfg = new IgniteConfiguration();
 
-cfg.setDataStorageConfiguration(storageCfg);
-//end::warm-all-regions[]
-//tag::warm-specific-region[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+        DataStorageConfiguration storageCfg = new DataStorageConfiguration();
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+        //Changing the default warm-up strategy for all data regions
+        storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());

Review Comment:
   Not introduced by this PR, but flagging since it's the same feature: this snippet is included by `memory-configuration/data-regions.adoc`, whose prose says to "pass the configuration parameter `LoadAllWarmUpStrategy` to `DataStorageConfiguration#setDefaultWarmUpConfiguration`" (and `NoOpWarmUpStrategy` further down). The actual public config — correctly used here — is `LoadAllWarmUpConfiguration` / `NoOpWarmUpConfiguration`. `*WarmUpStrategy` is the (internal) strategy, not what `setDefaultWarmUpConfiguration(WarmUpConfiguration)` accepts. Since the whole point of the ticket is that doc and code agree, worth fixing that prose in the same pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3474852552


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>

Review Comment:
   Started discussion on dev list https://lists.apache.org/thread/d214wbsp84gm6sc93woctf3q68dhrsch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "anton-vinogradov (via GitHub)" <gi...@apache.org>.
anton-vinogradov commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3476132012


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -25,6 +25,7 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <ignite.version>2.19.0-SNAPSHOT</ignite.version>
+        <ignite.extensions.version>1.0.0</ignite.extensions.version>

Review Comment:
   Minor, but worth flagging here: ignite-extensions modules are released **independently** of each other (and of core), so a single `ignite.extensions.version` property is a latent trap — it only works because `ignite-aws-ext`, `ignite-azure-ext`, `ignite-gce-ext` and `ignite-zookeeper-ip-finder-ext` all happen to sit at `1.0.0` today. As soon as one of them publishes a new release, you're either stuck on it for all four or silently compiling against a stale one. Per-artifact version properties (or at least a comment stating the shared value is coincidental) will age better.



##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>
+        </dependency>

Review Comment:
   This is the one dependency that isn't a real extension artifact: `ignite-cloud-ext` was never published to Maven Central, so `ignite-cloud:2.13.0` is a deliberate legacy fallback (the only resolvable artifact that still ships `TcpDiscoveryCloudIpFinder`). Please record that in the POM so the next reader doesn't "fix" it by bumping the version or switching to a non-existent `ignite-cloud-ext`:
   
   ```suggestion
           <dependency>
               <groupId>${project.groupId}</groupId>
               <!-- ignite-cloud-ext (the ignite-extensions successor of this module) is not yet
                    published to Maven Central, so we deliberately fall back to the last released
                    legacy ignite-cloud artifact, which still ships TcpDiscoveryCloudIpFinder.
                    Revisit once ignite-cloud-ext is released (dev-list:
                    https://lists.apache.org/thread/d214wbsp84gm6sc93woctf3q68dhrsch). -->
               <artifactId>ignite-cloud</artifactId>
               <version>2.13.0</version>
           </dependency>
   ```
   
   Also please double-check `2.13.0` actually compiles against `ignite-core:2.19.0-SNAPSHOT` — that's a wide gap on the discovery IP-finder SPI, and it's the dependency most likely to break the gate.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3480427954


##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/WarmUpStrategy.java:
##########
@@ -14,70 +14,91 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-//tag::warm-all-regions[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+package org.apache.ignite.snippets;
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.configuration.LoadAllWarmUpConfiguration;
+import org.apache.ignite.configuration.NoOpWarmUpConfiguration;
 
-//Changing the default warm-up strategy for all data regions
-storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());
+public class WarmUpStrategy {
+    public void warmAllRegions() {
+        //tag::warm-all-regions[]
+        IgniteConfiguration cfg = new IgniteConfiguration();
 
-cfg.setDataStorageConfiguration(storageCfg);
-//end::warm-all-regions[]
-//tag::warm-specific-region[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+        DataStorageConfiguration storageCfg = new DataStorageConfiguration();
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+        //Changing the default warm-up strategy for all data regions
+        storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());

Review Comment:
   Confirmed with `./mvnw -f docs/_docs/code-snippets/java/pom.xml compile -B -V`; the snippets compile successfully with `ignite-cloud:2.13.0` and current `ignite-core:2.19.0-SNAPSHOT`.



##########
docs/_docs/code-snippets/java/src/main/java/org/apache/ignite/snippets/WarmUpStrategy.java:
##########
@@ -14,70 +14,91 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-//tag::warm-all-regions[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+package org.apache.ignite.snippets;
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+import org.apache.ignite.configuration.DataRegionConfiguration;
+import org.apache.ignite.configuration.DataStorageConfiguration;
+import org.apache.ignite.configuration.IgniteConfiguration;
+import org.apache.ignite.configuration.LoadAllWarmUpConfiguration;
+import org.apache.ignite.configuration.NoOpWarmUpConfiguration;
 
-//Changing the default warm-up strategy for all data regions
-storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());
+public class WarmUpStrategy {
+    public void warmAllRegions() {
+        //tag::warm-all-regions[]
+        IgniteConfiguration cfg = new IgniteConfiguration();
 
-cfg.setDataStorageConfiguration(storageCfg);
-//end::warm-all-regions[]
-//tag::warm-specific-region[]
-IgniteConfiguration cfg = new IgniteConfiguration();
+        DataStorageConfiguration storageCfg = new DataStorageConfiguration();
 
-DataStorageConfiguration storageCfg = new DataStorageConfiguration();
+        //Changing the default warm-up strategy for all data regions
+        storageCfg.setDefaultWarmUpConfiguration(new LoadAllWarmUpConfiguration());

Review Comment:
   Confirmed with `./mvnw -f docs/_docs/code-snippets/java/pom.xml compile -B -V`; the snippets compile successfully with `ignite-cloud:2.13.0` and current `ignite-core:2.19.0-SNAPSHOT`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on PR #13266:
URL: https://github.com/apache/ignite/pull/13266#issuecomment-4808306707

   All actionable code comments should be addressed now
   
   For the CI gate: the intended merge order is to land this snippets-fix PR first, then update #13257 on top of it and merge the CI gate immediately after it is green. Merging #13257 first would make master red because the snippets fixes are not there yet


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan merged PR #13266:
URL: https://github.com/apache/ignite/pull/13266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3480420688


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -25,6 +25,7 @@
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <ignite.version>2.19.0-SNAPSHOT</ignite.version>
+        <ignite.extensions.version>1.0.0</ignite.extensions.version>

Review Comment:
   I think keeping a shared property is fine here. This POM is only a compile harness for documentation snippets, not user-facing dependency management. The extension artifacts used here are currently all published as 1.0.0, so a single property avoids repeating the same literal. If these versions diverge later, we can split it into per-artifact properties when updating the affected dependency



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28799 Fix documentation code snippets compilation [ignite]

Posted by "chesnokoff (via GitHub)" <gi...@apache.org>.
chesnokoff commented on code in PR #13266:
URL: https://github.com/apache/ignite/pull/13266#discussion_r3474648408


##########
docs/_docs/code-snippets/java/pom.xml:
##########
@@ -67,12 +68,47 @@
             <artifactId>ignite-zookeeper</artifactId>
             <version>${ignite.version}</version>
         </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-aws-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-azure-ext</artifactId>
+            <version>${ignite.extensions.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>ignite-cloud</artifactId>
+            <version>2.13.0</version>

Review Comment:
   https://central.sonatype.com/search?q=ignite-cloud



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org