[GitHub] dongjoon-hyun edited a comment on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints

[GitBox <gi...@apache.org>]

dongjoon-hyun edited a comment on issue #23759: [SPARK-26840][SQL] Avoid cost-based join reorder in presence of join hints
URL: https://github.com/apache/spark/pull/23759#issuecomment-462166909
 
 
   Hi, @maryannxue . 
   I made a PR to you, https://github.com/maryannxue/spark/pull/1, which replaces all changes in `CostBasedJoinReorder` into the following one-liner. Could you review and merge that?
   ```scala
      private def replaceWithOrderedJoin(plan: LogicalPlan): LogicalPlan = plan match {
   -    case j @ Join(left, right, jt: InnerLike, Some(cond), _) =>
   +    case j @ Join(left, right, jt: InnerLike, Some(cond), JoinHint.NONE) =>
   ```
   cc @gatorsmile 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org