You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/06/29 08:29:39 UTC

[GitHub] [bookkeeper] zymap commented on a change in pull request #2740: Fix Bouncy Castle fips incompatible issue

zymap commented on a change in pull request #2740:
URL: https://github.com/apache/bookkeeper/pull/2740#discussion_r660396852



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tls/TLSContextFactory.java
##########
@@ -130,7 +191,7 @@ private KeyManagerFactory initKeyManagerFactory(String keyStoreType, String keyS
         KeyManagerFactory kmf = null;
 
         if (Strings.isNullOrEmpty(keyStoreLocation)) {
-            LOG.error("Key store location cannot be empty when Mutual Authentication is enabled!");
+            log.error("Key store location cannot be empty when Mutual Authentication is enabled!");

Review comment:
       If we use the slf4j, looks like we can remove line 147?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org