You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/06/23 11:23:53 UTC

[GitHub] [hive] pvary commented on a change in pull request #2418: HIVE-25255: Add support for replace columns

pvary commented on a change in pull request #2418:
URL: https://github.com/apache/hive/pull/2418#discussion_r657001439



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java
##########
@@ -222,6 +223,7 @@ public void commitDropTable(org.apache.hadoop.hive.metastore.api.Table hmsTable,
   }
 
   @Override
+  @SuppressWarnings("checkstyle:CyclomaticComplexity")

Review comment:
       Could we decrease the complexity instead of suppressing?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org