You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by hongbin ma <ma...@apache.org> on 2015/09/01 12:54:28 UTC
Re: Pull Request closed without merge
Looks like asf closed it silently, shall we contact the author? I failed to
find his contact on github
On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
> Hi there,
> I found there's one pull request has been closed by asfgit:
> https://github.com/apache/incubator-kylin/pull/7
> <https://github.com/apache/incubator-kylin/pull/7>
>
> But when I check the code, it looks like not be merged:
>
>
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> <
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> >
>
> Any idea about this?
>
> Thanks.
>
> Best Regards!
> ---------------------
>
> Luke Han
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Pull Request closed without merge
Posted by hongbin ma <ma...@apache.org>.
https://issues.apache.org/jira/browse/INFRA-10233
On Tue, Sep 1, 2015 at 10:30 PM, Luke Han <lu...@gmail.com> wrote:
> @Hongbin, could you please also help to follow up with INFRA to check why
> such PR be
> closed without any notification and merge?
>
> Thanks.
>
>
> Best Regards!
> ---------------------
>
> Luke Han
>
> On Tue, Sep 1, 2015 at 9:02 PM, hongbin ma <ma...@apache.org> wrote:
>
> > please assign me as the assignee, i'll review the patch for you
> >
> > On Tue, Sep 1, 2015 at 7:50 PM, nichunen <ni...@mininglamp.com>
> wrote:
> >
> > > No problem.
> > >
> > >
> > > Best Regards,
> > >
> > >
> > >
> > > George/倪春恩
> > >
> > > Software Engineer/软件工程师
> > >
> > > Mobile:+86-13501723787| Fax:+8610-56842040
> > >
> > > 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
> > >
> > > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
> > >
> > > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> > > District,Beijing,102218
> > >
> > >
> > >
> >
> ----------------------------------------------------------------------------------------------------------------------------
> > >
> > > [image: cid:image003.jpg@01D076E2.04C796E0]
> > >
> > >
> > > *From:* hongbin ma <ma...@apache.org>
> > > *Date:* 2015-09-01 19:26
> > > *To:* dev <de...@kylin.incubator.apache.org>
> > > *Subject:* Re: Re: Pull Request closed without merge
> > > it's a shame that apache ASF silently closed it!
> > >
> > > will you please open a jira ticket and attach a patch against latest
> > > 0.7-stating and 0.8? github is not the right place.
> > >
> > > On Tue, Sep 1, 2015 at 7:16 PM, nichunen <ni...@mininglamp.com>
> > wrote:
> > >
> > > > Hi Hongbin,
> > > >
> > > > The pull request was from me, it's for cleaning the intermediate hive
> > > > tables and cleaning hdfs/hive/hbase intermediate data with uuids.
> > > >
> > > > ------------------------------
> > > >
> > > > Best Regards,
> > > >
> > > >
> > > >
> > > > George/倪春恩
> > > >
> > > > Software Engineer/软件工程师
> > > >
> > > > Mobile:+86-13501723787| Fax:+8610-56842040
> > > >
> > > > 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
> > > >
> > > > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
> > > >
> > > > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> > > > District,Beijing,102218
> > > >
> > > >
> > > >
> > >
> >
> ----------------------------------------------------------------------------------------------------------------------------
> > > >
> > > > [image: cid:image003.jpg@01D076E2.04C796E0]
> > > >
> > > >
> > > > *From:* hongbin ma <ma...@apache.org>
> > > > *Date:* 2015-09-01 18:54
> > > > *To:* dev <de...@kylin.incubator.apache.org>
> > > > *Subject:* Re: Pull Request closed without merge
> > > > Looks like asf closed it silently, shall we contact the author? I
> > failed
> > > to
> > > > find his contact on github
> > > >
> > > >
> > > > On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com>
> wrote:
> > > >
> > > > > Hi there,
> > > > > I found there's one pull request has been closed by asfgit:
> > > > > https://github.com/apache/incubator-kylin/pull/7
> > > > > <https://github.com/apache/incubator-kylin/pull/7>
> > > > >
> > > > > But when I check the code, it looks like not be merged:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > > > >
> > > > >
> > > > > Any idea about this?
> > > > >
> > > > > Thanks.
> > > > >
> > > > > Best Regards!
> > > > > ---------------------
> > > > >
> > > > > Luke Han
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Regards,
> > > >
> > > > *Bin Mahone | 马洪宾*
> > > > Apache Kylin: http://kylin.io
> > > > Github: https://github.com/binmahone
> > > >
> > > >
> > >
> > >
> > > --
> > > Regards,
> > >
> > > *Bin Mahone | 马洪宾*
> > > Apache Kylin: http://kylin.io
> > > Github: https://github.com/binmahone
> > >
> > >
> >
> >
> > --
> > Regards,
> >
> > *Bin Mahone | 马洪宾*
> > Apache Kylin: http://kylin.io
> > Github: https://github.com/binmahone
> >
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Pull Request closed without merge
Posted by Luke Han <lu...@gmail.com>.
@Hongbin, could you please also help to follow up with INFRA to check why
such PR be
closed without any notification and merge?
Thanks.
Best Regards!
---------------------
Luke Han
On Tue, Sep 1, 2015 at 9:02 PM, hongbin ma <ma...@apache.org> wrote:
> please assign me as the assignee, i'll review the patch for you
>
> On Tue, Sep 1, 2015 at 7:50 PM, nichunen <ni...@mininglamp.com> wrote:
>
> > No problem.
> >
> >
> > Best Regards,
> >
> >
> >
> > George/倪春恩
> >
> > Software Engineer/软件工程师
> >
> > Mobile:+86-13501723787| Fax:+8610-56842040
> >
> > 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
> >
> > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
> >
> > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> > District,Beijing,102218
> >
> >
> >
> ----------------------------------------------------------------------------------------------------------------------------
> >
> > [image: cid:image003.jpg@01D076E2.04C796E0]
> >
> >
> > *From:* hongbin ma <ma...@apache.org>
> > *Date:* 2015-09-01 19:26
> > *To:* dev <de...@kylin.incubator.apache.org>
> > *Subject:* Re: Re: Pull Request closed without merge
> > it's a shame that apache ASF silently closed it!
> >
> > will you please open a jira ticket and attach a patch against latest
> > 0.7-stating and 0.8? github is not the right place.
> >
> > On Tue, Sep 1, 2015 at 7:16 PM, nichunen <ni...@mininglamp.com>
> wrote:
> >
> > > Hi Hongbin,
> > >
> > > The pull request was from me, it's for cleaning the intermediate hive
> > > tables and cleaning hdfs/hive/hbase intermediate data with uuids.
> > >
> > > ------------------------------
> > >
> > > Best Regards,
> > >
> > >
> > >
> > > George/倪春恩
> > >
> > > Software Engineer/软件工程师
> > >
> > > Mobile:+86-13501723787| Fax:+8610-56842040
> > >
> > > 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
> > >
> > > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
> > >
> > > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> > > District,Beijing,102218
> > >
> > >
> > >
> >
> ----------------------------------------------------------------------------------------------------------------------------
> > >
> > > [image: cid:image003.jpg@01D076E2.04C796E0]
> > >
> > >
> > > *From:* hongbin ma <ma...@apache.org>
> > > *Date:* 2015-09-01 18:54
> > > *To:* dev <de...@kylin.incubator.apache.org>
> > > *Subject:* Re: Pull Request closed without merge
> > > Looks like asf closed it silently, shall we contact the author? I
> failed
> > to
> > > find his contact on github
> > >
> > >
> > > On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
> > >
> > > > Hi there,
> > > > I found there's one pull request has been closed by asfgit:
> > > > https://github.com/apache/incubator-kylin/pull/7
> > > > <https://github.com/apache/incubator-kylin/pull/7>
> > > >
> > > > But when I check the code, it looks like not be merged:
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > > <
> > > >
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > > >
> > > >
> > > > Any idea about this?
> > > >
> > > > Thanks.
> > > >
> > > > Best Regards!
> > > > ---------------------
> > > >
> > > > Luke Han
> > > >
> > >
> > >
> > >
> > > --
> > > Regards,
> > >
> > > *Bin Mahone | 马洪宾*
> > > Apache Kylin: http://kylin.io
> > > Github: https://github.com/binmahone
> > >
> > >
> >
> >
> > --
> > Regards,
> >
> > *Bin Mahone | 马洪宾*
> > Apache Kylin: http://kylin.io
> > Github: https://github.com/binmahone
> >
> >
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
Re: Re: Pull Request closed without merge
Posted by hongbin ma <ma...@apache.org>.
please assign me as the assignee, i'll review the patch for you
On Tue, Sep 1, 2015 at 7:50 PM, nichunen <ni...@mininglamp.com> wrote:
> No problem.
>
>
> Best Regards,
>
>
>
> George/倪春恩
>
> Software Engineer/软件工程师
>
> Mobile:+86-13501723787| Fax:+8610-56842040
>
> 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
>
> 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
>
> F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> District,Beijing,102218
>
>
> ----------------------------------------------------------------------------------------------------------------------------
>
> [image: cid:image003.jpg@01D076E2.04C796E0]
>
>
> *From:* hongbin ma <ma...@apache.org>
> *Date:* 2015-09-01 19:26
> *To:* dev <de...@kylin.incubator.apache.org>
> *Subject:* Re: Re: Pull Request closed without merge
> it's a shame that apache ASF silently closed it!
>
> will you please open a jira ticket and attach a patch against latest
> 0.7-stating and 0.8? github is not the right place.
>
> On Tue, Sep 1, 2015 at 7:16 PM, nichunen <ni...@mininglamp.com> wrote:
>
> > Hi Hongbin,
> >
> > The pull request was from me, it's for cleaning the intermediate hive
> > tables and cleaning hdfs/hive/hbase intermediate data with uuids.
> >
> > ------------------------------
> >
> > Best Regards,
> >
> >
> >
> > George/倪春恩
> >
> > Software Engineer/软件工程师
> >
> > Mobile:+86-13501723787| Fax:+8610-56842040
> >
> > 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
> >
> > 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
> >
> > F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> > District,Beijing,102218
> >
> >
> >
> ----------------------------------------------------------------------------------------------------------------------------
> >
> > [image: cid:image003.jpg@01D076E2.04C796E0]
> >
> >
> > *From:* hongbin ma <ma...@apache.org>
> > *Date:* 2015-09-01 18:54
> > *To:* dev <de...@kylin.incubator.apache.org>
> > *Subject:* Re: Pull Request closed without merge
> > Looks like asf closed it silently, shall we contact the author? I failed
> to
> > find his contact on github
> >
> >
> > On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
> >
> > > Hi there,
> > > I found there's one pull request has been closed by asfgit:
> > > https://github.com/apache/incubator-kylin/pull/7
> > > <https://github.com/apache/incubator-kylin/pull/7>
> > >
> > > But when I check the code, it looks like not be merged:
> > >
> > >
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > <
> > >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > > >
> > >
> > > Any idea about this?
> > >
> > > Thanks.
> > >
> > > Best Regards!
> > > ---------------------
> > >
> > > Luke Han
> > >
> >
> >
> >
> > --
> > Regards,
> >
> > *Bin Mahone | 马洪宾*
> > Apache Kylin: http://kylin.io
> > Github: https://github.com/binmahone
> >
> >
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Pull Request closed without merge
Posted by nichunen <ni...@mininglamp.com>.
No problem.
Best Regards,
George/倪春恩
Software Engineer/软件工程师
Mobile:+86-13501723787| Fax:+8610-56842040
北京明略软件系统有限公司（www.mininglamp.com）
北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping District,Beijing,102218
----------------------------------------------------------------------------------------------------------------------------
From: hongbin ma
Date: 2015-09-01 19:26
To: dev
Subject: Re: Re: Pull Request closed without merge
it's a shame that apache ASF silently closed it!
will you please open a jira ticket and attach a patch against latest
0.7-stating and 0.8? github is not the right place.
On Tue, Sep 1, 2015 at 7:16 PM, nichunen <ni...@mininglamp.com> wrote:
> Hi Hongbin,
>
> The pull request was from me, it's for cleaning the intermediate hive
> tables and cleaning hdfs/hive/hbase intermediate data with uuids.
>
> ------------------------------
>
> Best Regards,
>
>
>
> George/倪春恩
>
> Software Engineer/软件工程师
>
> Mobile:+86-13501723787| Fax:+8610-56842040
>
> 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
>
> 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
>
> F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> District,Beijing,102218
>
>
> ----------------------------------------------------------------------------------------------------------------------------
>
> [image: cid:image003.jpg@01D076E2.04C796E0]
>
>
> *From:* hongbin ma <ma...@apache.org>
> *Date:* 2015-09-01 18:54
> *To:* dev <de...@kylin.incubator.apache.org>
> *Subject:* Re: Pull Request closed without merge
> Looks like asf closed it silently, shall we contact the author? I failed to
> find his contact on github
>
>
> On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
>
> > Hi there,
> > I found there's one pull request has been closed by asfgit:
> > https://github.com/apache/incubator-kylin/pull/7
> > <https://github.com/apache/incubator-kylin/pull/7>
> >
> > But when I check the code, it looks like not be merged:
> >
> >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > <
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > >
> >
> > Any idea about this?
> >
> > Thanks.
> >
> > Best Regards!
> > ---------------------
> >
> > Luke Han
> >
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Pull Request closed without merge
Posted by hongbin ma <ma...@apache.org>.
it's a shame that apache ASF silently closed it!
will you please open a jira ticket and attach a patch against latest
0.7-stating and 0.8? github is not the right place.
On Tue, Sep 1, 2015 at 7:16 PM, nichunen <ni...@mininglamp.com> wrote:
> Hi Hongbin,
>
> The pull request was from me, it's for cleaning the intermediate hive
> tables and cleaning hdfs/hive/hbase intermediate data with uuids.
>
> ------------------------------
>
> Best Regards,
>
>
>
> George/倪春恩
>
> Software Engineer/软件工程师
>
> Mobile:+86-13501723787| Fax:+8610-56842040
>
> 北京明略软件系统有限公司（www <http://www.semidata.com/>.mininglamp.com）
>
> 北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
>
> F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping
> District,Beijing,102218
>
>
> ----------------------------------------------------------------------------------------------------------------------------
>
> [image: cid:image003.jpg@01D076E2.04C796E0]
>
>
> *From:* hongbin ma <ma...@apache.org>
> *Date:* 2015-09-01 18:54
> *To:* dev <de...@kylin.incubator.apache.org>
> *Subject:* Re: Pull Request closed without merge
> Looks like asf closed it silently, shall we contact the author? I failed to
> find his contact on github
>
>
> On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
>
> > Hi there,
> > I found there's one pull request has been closed by asfgit:
> > https://github.com/apache/incubator-kylin/pull/7
> > <https://github.com/apache/incubator-kylin/pull/7>
> >
> > But when I check the code, it looks like not be merged:
> >
> >
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > <
> >
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> > >
> >
> > Any idea about this?
> >
> > Thanks.
> >
> > Best Regards!
> > ---------------------
> >
> > Luke Han
> >
>
>
>
> --
> Regards,
>
> *Bin Mahone | 马洪宾*
> Apache Kylin: http://kylin.io
> Github: https://github.com/binmahone
>
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone
Re: Re: Pull Request closed without merge
Posted by nichunen <ni...@mininglamp.com>.
Hi Hongbin,
The pull request was from me, it's for cleaning the intermediate hive tables and cleaning hdfs/hive/hbase intermediate data with uuids.
Best Regards,
George/倪春恩
Software Engineer/软件工程师
Mobile:+86-13501723787| Fax:+8610-56842040
北京明略软件系统有限公司（www.mininglamp.com）
北京市昌平区东小口镇中东路398号中煤建设集团大厦1号楼4层
F4,1#,Zhongmei Construction Group Plaza,398# Zhongdong Road,Changping District,Beijing,102218
----------------------------------------------------------------------------------------------------------------------------
From: hongbin ma
Date: 2015-09-01 18:54
To: dev
Subject: Re: Pull Request closed without merge
Looks like asf closed it silently, shall we contact the author? I failed to
find his contact on github
On Fri, Aug 28, 2015 at 10:31 PM, Luke Han <lu...@gmail.com> wrote:
> Hi there,
> I found there's one pull request has been closed by asfgit:
> https://github.com/apache/incubator-kylin/pull/7
> <https://github.com/apache/incubator-kylin/pull/7>
>
> But when I check the code, it looks like not be merged:
>
>
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> <
> https://github.com/apache/incubator-kylin/blob/master/job/src/main/java/org/apache/kylin/job/hadoop/cube/StorageCleanupJob.java
> >
>
> Any idea about this?
>
> Thanks.
>
> Best Regards!
> ---------------------
>
> Luke Han
>
--
Regards,
*Bin Mahone | 马洪宾*
Apache Kylin: http://kylin.io
Github: https://github.com/binmahone