You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2016/03/12 03:04:26 UTC
Review Request 44751: RANGER-878: Improve error logging and Ranger UI
error message when test connection and lookup is done for Services
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44751/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Madhan Neethiraj, and Velmurugan Periasamy.
Repository: ranger
Description
-------
RANGER-878: Improve error logging and Ranger UI error message when test connection and lookup is done for Services
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 0242caa
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java 1ab2d4b
hbase-agent/src/main/java/org/apache/ranger/services/hbase/RangerServiceHBase.java 9832991
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java f28a598
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java 094385c
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java 5f07740
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java 57b260d
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java 400a379
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsResourceMgr.java 5bce2cd
hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java fa006ef
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 84f4d9b
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java b51a0c1
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 094226d
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java 0a06190
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 7950439
security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java 643d882
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 84c2ebf
Diff: https://reviews.apache.org/r/44751/diff/
Testing
-------
Test connection for HDFS service in Ranger UI after bringing down Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
Test connection for HBASE service in Ranger UI after bringing down HBASE master / regionserver / Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
Test connection for HIVE service in Ranger UI after bringing down HiveServer2 / Namenode and see that error message is detailed in the UI dialog box. Check in xa_portal.log stack trace is logged.
Thanks,
Ramesh Mani
Re: Review Request 44751: RANGER-878: Improve error logging and
Ranger UI
error message when test connection and lookup is done for Services
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44751/#review123514
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 14, 2016, 9:21 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44751/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 9:21 p.m.)
>
>
> Review request for ranger, Alok Lal, Madhan Neethiraj, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-878: Improve error logging and Ranger UI error message when test connection and lookup is done for Services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 0242caa
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java 1ab2d4b
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/RangerServiceHBase.java 9832991
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java f28a598
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java 094385c
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java 5f07740
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java 57b260d
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java 400a379
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsResourceMgr.java 5bce2cd
> hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java fa006ef
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 84f4d9b
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java b51a0c1
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 094226d
> plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java 0a06190
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 7950439
> security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java 643d882
> storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 84c2ebf
>
> Diff: https://reviews.apache.org/r/44751/diff/
>
>
> Testing
> -------
>
> Test connection for HDFS service in Ranger UI after bringing down Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
> Test connection for HBASE service in Ranger UI after bringing down HBASE master / regionserver / Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
> Test connection for HIVE service in Ranger UI after bringing down HiveServer2 / Namenode and see that error message is detailed in the UI dialog box. Check in xa_portal.log stack trace is logged.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 44751: RANGER-878: Improve error logging and
Ranger UI
error message when test connection and lookup is done for Services
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44751/
-----------------------------------------------------------
(Updated March 14, 2016, 9:21 p.m.)
Review request for ranger, Alok Lal, Madhan Neethiraj, and Velmurugan Periasamy.
Changes
-------
Fixed review comments
Repository: ranger
Description
-------
RANGER-878: Improve error logging and Ranger UI error message when test connection and lookup is done for Services
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 0242caa
agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java 1ab2d4b
hbase-agent/src/main/java/org/apache/ranger/services/hbase/RangerServiceHBase.java 9832991
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java f28a598
hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java 094385c
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java 5f07740
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java 57b260d
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java 400a379
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsResourceMgr.java 5bce2cd
hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java fa006ef
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 84f4d9b
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java b51a0c1
knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 094226d
plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java 0a06190
security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 7950439
security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java 643d882
storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 84c2ebf
Diff: https://reviews.apache.org/r/44751/diff/
Testing
-------
Test connection for HDFS service in Ranger UI after bringing down Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
Test connection for HBASE service in Ranger UI after bringing down HBASE master / regionserver / Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
Test connection for HIVE service in Ranger UI after bringing down HiveServer2 / Namenode and see that error message is detailed in the UI dialog box. Check in xa_portal.log stack trace is logged.
Thanks,
Ramesh Mani
Re: Review Request 44751: RANGER-878: Improve error logging and
Ranger UI
error message when test connection and lookup is done for Services
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44751/#review123273
-----------------------------------------------------------
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java (line 166)
<https://reviews.apache.org/r/44751/#comment185486>
This catch block simply rethrows the exception. Is this necessary?
hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java (line 96)
<https://reviews.apache.org/r/44751/#comment185487>
The exception is caught, but not rethrown. Does the error message in the exception get sent to the REST API caller?
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 55)
<https://reviews.apache.org/r/44751/#comment185484>
This catch block simply rethrows the exception. Is this necessary?
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 66)
<https://reviews.apache.org/r/44751/#comment185485>
This catch block simply rethrows the exception. Is this necessary?
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 80)
<https://reviews.apache.org/r/44751/#comment185483>
This catch block and the one below simply rethrow the exception. Are these necessary?
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 99)
<https://reviews.apache.org/r/44751/#comment185482>
This catch block and the one below simply rethrow the exception. Are these necessary?
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 656)
<https://reviews.apache.org/r/44751/#comment185481>
consider replacing try/catch with try/finally here, since the catch simply rethrows after doing cleanup.
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 663)
<https://reviews.apache.org/r/44751/#comment185480>
testResult is used only within the following try block. Consider moving this to inside that try block.
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java (line 680)
<https://reviews.apache.org/r/44751/#comment185479>
consider replacing try/catch with try/finally here, since the catch simply rethrows after doing cleanup.
- Madhan Neethiraj
On March 12, 2016, 2:04 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44751/
> -----------------------------------------------------------
>
> (Updated March 12, 2016, 2:04 a.m.)
>
>
> Review request for ranger, Alok Lal, Madhan Neethiraj, and Velmurugan Periasamy.
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-878: Improve error logging and Ranger UI error message when test connection and lookup is done for Services
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/client/BaseClient.java 0242caa
> agents-common/src/main/java/org/apache/ranger/plugin/client/HadoopException.java 1ab2d4b
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/RangerServiceHBase.java 9832991
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseClient.java f28a598
> hbase-agent/src/main/java/org/apache/ranger/services/hbase/client/HBaseResourceMgr.java 094385c
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/RangerServiceHdfs.java 5f07740
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java 57b260d
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsConnectionMgr.java 400a379
> hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsResourceMgr.java 5bce2cd
> hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java fa006ef
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java 84f4d9b
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveResourceMgr.java b51a0c1
> knox-agent/src/main/java/org/apache/ranger/services/knox/client/KnoxClient.java 094226d
> plugin-yarn/src/main/java/org/apache/ranger/services/yarn/client/YarnClient.java 0a06190
> security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 7950439
> security-admin/src/main/java/org/apache/ranger/common/TimedExecutor.java 643d882
> storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 84c2ebf
>
> Diff: https://reviews.apache.org/r/44751/diff/
>
>
> Testing
> -------
>
> Test connection for HDFS service in Ranger UI after bringing down Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
> Test connection for HBASE service in Ranger UI after bringing down HBASE master / regionserver / Namenode and see that error message is detailed in UI dialog box. Check in xa_portal.log stack trace is logged.
> Test connection for HIVE service in Ranger UI after bringing down HiveServer2 / Namenode and see that error message is detailed in the UI dialog box. Check in xa_portal.log stack trace is logged.
>
>
> Thanks,
>
> Ramesh Mani
>
>