You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/04 09:03:16 UTC
[GitHub] [skywalking-satellite] mrproliu opened a new pull request #49: Support generate plugin list index config in menu file
mrproliu opened a new pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49
* Support generate plugin list index to `menu.yml`
* Fix wrong contribute plugin docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645439362
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
> > Is this for satellite runtime? If not, we don't need the license.
>
> It's built into the binary, although we only use it to generate docs
Also, the other PR #42 will use this (v2) at runtime, I think it's ok to have this license for now, no matter which PR gets merged first. We should pick only one version after either PR gets merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng merged pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645437746
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
Is this for satellite runtime? If not, we don't need the license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645436929
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
Thx, have added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645431587
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
Usually , a new item in `go.mod` requires a new item in `LICENSE` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645451017
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
> Should I need to use the YAML framework v2 version? I have checked, the result basically the same.
Let's use v3, I think newer version is preferable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645437857
##########
File path: LICENSE
##########
@@ -215,6 +215,7 @@ Apache 2.0 licenses
The following components are provided under the Apache License. See project link for details.
The text of each license is the standard Apache 2.0 license.
+go-yaml (yaml) v3.0.0: https://github.com/go-yaml/yaml Apache 2.0
Review comment:
This is binary dependency, should be in `dist/LICENSE` file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645450379
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
Should I need to use the YAML framework v2 version? I have checked, the result basically the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645438583
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
> Is this for satellite runtime? If not, we don't need the license.
It's built into the binary, although we only use it to generate docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #49: Support generate plugin list index config in menu file
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #49:
URL: https://github.com/apache/skywalking-satellite/pull/49#discussion_r645439362
##########
File path: go.mod
##########
@@ -15,5 +15,6 @@ require (
go.uber.org/automaxprocs v1.4.0
google.golang.org/grpc v1.38.0
google.golang.org/protobuf v1.26.0
+ gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b
Review comment:
> > Is this for satellite runtime? If not, we don't need the license.
>
> It's built into the binary, although we only use it to generate docs
Also, the other PR #42 will use this at runtime, I think it's ok to have this license for now, no matter which PR gets merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org