You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Mat Mannion (JIRA)" <ji...@apache.org> on 2010/11/22 12:15:14 UTC
[jira] Created: (SHINDIG-1474) Relax field and constructor
modifiers in GadgetSpec to make it easier to extend
Relax field and constructor modifiers in GadgetSpec to make it easier to extend
-------------------------------------------------------------------------------
Key: SHINDIG-1474
URL: https://issues.apache.org/jira/browse/SHINDIG-1474
Project: Shindig
Issue Type: Improvement
Components: Java
Affects Versions: 2.0.2
Reporter: Mat Mannion
Fix For: 3.0.0
In our application, we have a requirement to extend GadgetSpec so that we can parse a custom namespace on the gadget XML that provides extra information to the spec about (e.g.) validation of UserPrefs.
Unfortunately, it isn't possible to directly extend GadgetSpec at the moment, because the substitute() method creates a new instance of the GadgetSpec (not the extended class). It isn't possible to extend the substitute() method because it calls a private constructor and sets private fields on GadgetSpec that can't be set from a subclass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1474) Relax field and constructor
modifiers in GadgetSpec to make it easier to extend
Posted by "Mat Mannion (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mat Mannion updated SHINDIG-1474:
---------------------------------
Attachment: shindig-1474.diff
Attached patch relaxes field modifiers from private to protected to allow a custom substitute() method to be written in a superclass that will set the fields.
> Relax field and constructor modifiers in GadgetSpec to make it easier to extend
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-1474
> URL: https://issues.apache.org/jira/browse/SHINDIG-1474
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Mat Mannion
> Fix For: 3.0.0
>
> Attachments: shindig-1474.diff
>
>
> In our application, we have a requirement to extend GadgetSpec so that we can parse a custom namespace on the gadget XML that provides extra information to the spec about (e.g.) validation of UserPrefs.
> Unfortunately, it isn't possible to directly extend GadgetSpec at the moment, because the substitute() method creates a new instance of the GadgetSpec (not the extended class). It isn't possible to extend the substitute() method because it calls a private constructor and sets private fields on GadgetSpec that can't be set from a subclass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1474) Relax field and constructor
modifiers in GadgetSpec to make it easier to extend
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1474.
-----------------------------------
Resolution: Fixed
thanks!
> Relax field and constructor modifiers in GadgetSpec to make it easier to extend
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-1474
> URL: https://issues.apache.org/jira/browse/SHINDIG-1474
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Mat Mannion
> Fix For: 3.0.0
>
> Attachments: shindig-1474.diff
>
>
> In our application, we have a requirement to extend GadgetSpec so that we can parse a custom namespace on the gadget XML that provides extra information to the spec about (e.g.) validation of UserPrefs.
> Unfortunately, it isn't possible to directly extend GadgetSpec at the moment, because the substitute() method creates a new instance of the GadgetSpec (not the extended class). It isn't possible to extend the substitute() method because it calls a private constructor and sets private fields on GadgetSpec that can't be set from a subclass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (SHINDIG-1474) Relax field and constructor
modifiers in GadgetSpec to make it easier to extend
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1474.
---------------------------------
part of 2.5.0-beta1 release.
> Relax field and constructor modifiers in GadgetSpec to make it easier to extend
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-1474
> URL: https://issues.apache.org/jira/browse/SHINDIG-1474
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Mat Mannion
> Fix For: 2.5.0-beta1
>
> Attachments: shindig-1474.diff
>
>
> In our application, we have a requirement to extend GadgetSpec so that we can parse a custom namespace on the gadget XML that provides extra information to the spec about (e.g.) validation of UserPrefs.
> Unfortunately, it isn't possible to directly extend GadgetSpec at the moment, because the substitute() method creates a new instance of the GadgetSpec (not the extended class). It isn't possible to extend the substitute() method because it calls a private constructor and sets private fields on GadgetSpec that can't be set from a subclass.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (SHINDIG-1474) Relax field and constructor
modifiers in GadgetSpec to make it easier to extend
Posted by "Mat Mannion (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934438#action_12934438 ]
Mat Mannion commented on SHINDIG-1474:
--------------------------------------
Reviewable at http://codereview.appspot.com/3255041/
> Relax field and constructor modifiers in GadgetSpec to make it easier to extend
> -------------------------------------------------------------------------------
>
> Key: SHINDIG-1474
> URL: https://issues.apache.org/jira/browse/SHINDIG-1474
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.0.2
> Reporter: Mat Mannion
> Fix For: 3.0.0
>
> Attachments: shindig-1474.diff
>
>
> In our application, we have a requirement to extend GadgetSpec so that we can parse a custom namespace on the gadget XML that provides extra information to the spec about (e.g.) validation of UserPrefs.
> Unfortunately, it isn't possible to directly extend GadgetSpec at the moment, because the substitute() method creates a new instance of the GadgetSpec (not the extended class). It isn't possible to extend the substitute() method because it calls a private constructor and sets private fields on GadgetSpec that can't be set from a subclass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.