You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/03/17 00:01:28 UTC
[PR] fix(tests): restore 100% TypeScript coverage for core packages [superset]
rusackas opened a new pull request, #38682:
URL: https://github.com/apache/superset/pull/38682
### SUMMARY
The `codecov/project/core-packages-ts` check has been failing on every PR since [#38361](https://github.com/apache/superset/pull/38361), which added the `GranularExportControls` feature flag to the `FeatureFlag` enum but didn't add corresponding tests. This caused the coverage to drop from 100% to 99.92%.
This follows the same pattern as #38518 (which previously achieved 100% coverage): add explicit tests for any new feature flag enum members to keep the `core-packages-ts` coverage check green.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
- Run `npm run core:cover` in `superset-frontend/` — should pass with 100% coverage
- The `codecov/project/core-packages-ts` CI check should go back to 100%
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): restore 100% TypeScript coverage for core packages [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38682:
URL: https://github.com/apache/superset/pull/38682#issuecomment-4071411733
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): restore 100% TypeScript coverage for core packages [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #38682:
URL: https://github.com/apache/superset/pull/38682#issuecomment-4071429654
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 4c78ae908e425e91cde3a67ad976e89b4dc2125c |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/69b899d965bff800089b5cc2 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-38682--superset-docs-preview.netlify.app](https://deploy-preview-38682--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-38682--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): restore 100% TypeScript coverage for core packages [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #38682:
URL: https://github.com/apache/superset/pull/38682#issuecomment-4071415378
## **Sequence Diagram**
This PR adds targeted unit tests for the new GranularExportControls feature flag. The tests verify both the enum string mapping and that the flag is recognized as enabled when present in window feature flags, restoring full TypeScript coverage.
```mermaid
sequenceDiagram
participant TestRunner
participant FeatureFlagEnum
participant BrowserWindow
participant FeatureCheck
TestRunner->>FeatureFlagEnum: Read GranularExportControls value
FeatureFlagEnum-->>TestRunner: GRANULAR_EXPORT_CONTROLS
TestRunner->>BrowserWindow: Set featureFlags with GRANULAR_EXPORT_CONTROLS true
TestRunner->>FeatureCheck: Call isFeatureEnabled with GranularExportControls
FeatureCheck->>BrowserWindow: Read feature flag state
FeatureCheck-->>TestRunner: Return true and assertion passes
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org