You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/12/20 08:47:35 UTC
[GitHub] [incubator-tubemq] gosonzhang opened a new pull request #356: [TUBEMQ-452]Optimize rebalance performance
gosonzhang opened a new pull request #356:
URL: https://github.com/apache/incubator-tubemq/pull/356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] yuanboliu commented on pull request #356: [TUBEMQ-452]Optimize rebalance performance
Posted by GitBox <gi...@apache.org>.
yuanboliu commented on pull request #356:
URL: https://github.com/apache/incubator-tubemq/pull/356#issuecomment-748580684
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io edited a comment on pull request #356: [TUBEMQ-452]Optimize rebalance performance
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #356:
URL: https://github.com/apache/incubator-tubemq/pull/356#issuecomment-748580213
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=h1) Report
> Merging [#356](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=desc) (e307364) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/a2e5f524b29391d9b900df937ec4a821106ec1c9?el=desc) (a2e5f52) will **increase** coverage by `0.00%`.
> The diff coverage is `1.28%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #356 +/- ##
=========================================
Coverage 7.78% 7.79%
- Complexity 469 471 +2
=========================================
Files 261 261
Lines 28002 28134 +132
Branches 4597 4658 +61
=========================================
+ Hits 2181 2193 +12
- Misses 25350 25459 +109
- Partials 471 482 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tubemq/server/master/TMaster.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvVE1hc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/nodemanage/nodeconsumer/ConsumerInfoHolder.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlY29uc3VtZXIvQ29uc3VtZXJJbmZvSG9sZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/tubemq/server/master/MasterConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvTWFzdGVyQ29uZmlnLmphdmE=) | `34.95% <16.66%> (-0.37%)` | `27.00 <0.00> (ø)` | |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `51.42% <0.00%> (-4.00%)` | `14.00% <0.00%> (ø%)` | |
| [.../apache/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `38.88% <0.00%> (-1.12%)` | `8.00% <0.00%> (-1.00%)` | |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `43.98% <0.00%> (-0.59%)` | `34.00% <0.00%> (-1.00%)` | |
| [.../apache/tubemq/client/config/TubeClientConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9jb25maWcvVHViZUNsaWVudENvbmZpZy5qYXZh) | `12.63% <0.00%> (-0.39%)` | `3.00% <0.00%> (ø%)` | |
| [...tubemq/server/master/web/action/screen/Master.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvd2ViL2FjdGlvbi9zY3JlZW4vTWFzdGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../flink/connectors/tubemq/TubemqSourceFunction.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbGluay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmxpbmsvY29ubmVjdG9ycy90dWJlbXEvVHViZW1xU291cmNlRnVuY3Rpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/tubemq/corebase/utils/AddressUtils.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS91dGlscy9BZGRyZXNzVXRpbHMuamF2YQ==) | `15.30% <0.00%> (+4.59%)` | `7.00% <0.00%> (+2.00%)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=footer). Last update [a2e5f52...e307364](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] codecov-io commented on pull request #356: [TUBEMQ-452]Optimize rebalance performance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #356:
URL: https://github.com/apache/incubator-tubemq/pull/356#issuecomment-748580213
# [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=h1) Report
> Merging [#356](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=desc) (e307364) into [master](https://codecov.io/gh/apache/incubator-tubemq/commit/a2e5f524b29391d9b900df937ec4a821106ec1c9?el=desc) (a2e5f52) will **decrease** coverage by `0.03%`.
> The diff coverage is `1.28%`.
[](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #356 +/- ##
===========================================
- Coverage 7.78% 7.74% -0.04%
+ Complexity 469 466 -3
===========================================
Files 261 261
Lines 28002 28017 +15
Branches 4597 4603 +6
===========================================
- Hits 2181 2171 -10
- Misses 25350 25371 +21
- Partials 471 475 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/tubemq/server/master/TMaster.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvVE1hc3Rlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...er/nodemanage/nodeconsumer/ConsumerInfoHolder.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvbm9kZW1hbmFnZS9ub2RlY29uc3VtZXIvQ29uc3VtZXJJbmZvSG9sZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../org/apache/tubemq/server/master/MasterConfig.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL3NlcnZlci9tYXN0ZXIvTWFzdGVyQ29uZmlnLmphdmE=) | `34.95% <16.66%> (-0.37%)` | `27.00 <0.00> (ø)` | |
| [.../java/org/apache/flume/sink/tubemq/TubemqSink.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvbm5lY3RvcnMvdHViZW1xLWNvbm5lY3Rvci1mbHVtZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZmx1bWUvc2luay90dWJlbXEvVHViZW1xU2luay5qYXZh) | `51.42% <0.00%> (-4.00%)` | `14.00% <0.00%> (ø%)` | |
| [.../apache/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `38.88% <0.00%> (-1.12%)` | `8.00% <0.00%> (-1.00%)` | |
| [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `43.98% <0.00%> (-0.59%)` | `34.00% <0.00%> (-1.00%)` | |
| [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-tubemq/pull/356/diff?src=pr&el=tree#diff-dHViZW1xLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.70% <0.00%> (-0.40%)` | `21.00% <0.00%> (-1.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=footer). Last update [a2e5f52...e307364](https://codecov.io/gh/apache/incubator-tubemq/pull/356?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tubemq] gosonzhang merged pull request #356: [TUBEMQ-452]Optimize rebalance performance
Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #356:
URL: https://github.com/apache/incubator-tubemq/pull/356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org