You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/07/12 10:29:30 UTC

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

GitHub user paul-guo- opened a pull request:

    https://github.com/apache/incubator-hawq/pull/788

    HAWQ-915. RAT is failing on the latest master

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-guo-/incubator-hawq rat2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/788.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #788
    
----
commit 0c825258cc886917477b60f706a87e7d3dd831f4
Author: Paul Guo <pa...@gmail.com>
Date:   2016-07-12T10:27:26Z

    HAWQ-915. RAT is failing on the latest master

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/788


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70552418
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    --- End diff --
    
    PKG-INFO is wrong (just noticed).
    
    tools/bin/pythonSrc/unittest2-0.5.1]$ head setup.py
    
    #! /usr/bin/env python
    # setup.py
    # Install script for unittest2
    # Copyright (C) 2010 Michael Foord
    # E-mail: fuzzyman AT voidspace DOT org DOT uk
    
    # This software is licensed under the terms of the BSD license.
    # http://www.voidspace.org.uk/python/license.shtml
    
    import os
    
    2016-07-13 7:58 GMT+08:00 Roman V Shaposhnik <no...@github.com>:
    
    > In pom.xml
    > <https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327>:
    >
    > >                <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    > > +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    > > +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    > > +              <!-- BSD license for open-source python modules -->
    > > +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    > > +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    >
    > unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support
    > for your claim that this is a BSD licensed code.
    >
    > \u2014
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/incubator-hawq/pull/788/files/0c825258cc886917477b60f706a87e7d3dd831f4#r70544327>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe/AHI5jGA59Fdr2gVGgdY5tZOVHFkHDYy_ks5qVCo7gaJpZM4JKQQE>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/788
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544564
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pycrypto-2.0.1/**</exclude>
    +              <!-- Apache compatible open-source python modules under other directories -->
    +              <exclude>tools/bin/ext/**</exclude>
    +
    +              <!-- Apache license for open-source thrift  -->
    +              <exclude>depends/thirdparty/thrift/**</exclude>
    --- End diff --
    
    What exactly is RAT complaining about? For ASF code this should not be a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544521
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pycrypto-2.0.1/**</exclude>
    +              <!-- Apache compatible open-source python modules under other directories -->
    +              <exclude>tools/bin/ext/**</exclude>
    --- End diff --
    
    I am no comfortable with bulk exclusion here, especially since the code is Crypto related in one of the folders


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the issue:

    https://github.com/apache/incubator-hawq/pull/788
  
    @rvs to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544439
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    --- End diff --
    
    I am not sure this is ASF compatible since this code basically has no OSI-approved license attached to it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/788
  
    @radarwave Could you please take a look at the patch also?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/788
  
    Thanks @rvs , I've made a lot of further changes.
    
    Removed some deleted files in pom.xml
    Added header info into more files after discussing with related developers.
    Classified and double-confirmed licenses for opensource python modules under tools/bin.
    
    Just one thing, pygresql is said to be Python Software Foundation License (https://pypi.python.org/pypi/PyGreSQL/4.0) (Note Python license is deprecated one according to https://en.wikipedia.org/wiki/Python_Software_Foundation_License, so Python license != Python Software Foundation License) but the code & doc (docs/readme.txt & pgmodule.c) shows it is with postgresql license. I'm really confused. Fortunately it seems that both licenses are friendly to ASF license.
    
    I'm classifying pygresql as Python Software Foundation License in this patch, since this is not a big issue. We could keep the issue open and make the change if necessary.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544706
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pycrypto-2.0.1/**</exclude>
    +              <!-- Apache compatible open-source python modules under other directories -->
    +              <exclude>tools/bin/ext/**</exclude>
    +
    +              <!-- Apache license for open-source thrift  -->
    +              <exclude>depends/thirdparty/thrift/**</exclude>
    +
    +              <!-- BSD license for open-source googletest -->
    +              <exclude>depends/thirdparty/googletest/**</exclude>
     
                   <!-- BSD license -->
                   <exclude>depends/libyarn/CMake/FindBoost.cmake</exclude>
                   <exclude>depends/libyarn/CMake/FindGSasl.cmake</exclude>
                   <exclude>depends/libyarn/CMake/FindKERBEROS.cmake</exclude>
    +			  <exclude>depends/libyarn/CMake/FindGoogleTest.cmake</exclude>
     			  <exclude>depends/libhdfs3/CMake/FindBoost.cmake</exclude>
    +			  <exclude>depends/libhdfs3/CMake/FindGoogleTest.cmake</exclude>
    --- End diff --
    
    Where did this file come from? If you wrote it, please add AL header to it. If not -- indicate where it came from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544031
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    --- End diff --
    
    For all these new additions don't forget to update the NOTICE file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544691
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pycrypto-2.0.1/**</exclude>
    +              <!-- Apache compatible open-source python modules under other directories -->
    +              <exclude>tools/bin/ext/**</exclude>
    +
    +              <!-- Apache license for open-source thrift  -->
    +              <exclude>depends/thirdparty/thrift/**</exclude>
    +
    +              <!-- BSD license for open-source googletest -->
    +              <exclude>depends/thirdparty/googletest/**</exclude>
     
                   <!-- BSD license -->
                   <exclude>depends/libyarn/CMake/FindBoost.cmake</exclude>
                   <exclude>depends/libyarn/CMake/FindGSasl.cmake</exclude>
                   <exclude>depends/libyarn/CMake/FindKERBEROS.cmake</exclude>
    +			  <exclude>depends/libyarn/CMake/FindGoogleTest.cmake</exclude>
    --- End diff --
    
    Where did this file come from? If you wrote it, please add AL header to it. If not -- indicate where it came from.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544327
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    --- End diff --
    
    unittest2-0.5.1/PKG-INFO says License is unknown. Please provide support for your claim that this is a BSD licensed code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544736
  
    --- Diff: pom.xml ---
    @@ -112,6 +130,10 @@
                        however it is tricky to maintain headers in them -->
                   <exclude>depends/libyarn/test/data/*</exclude>
     
    +              <!-- Files which are not easy to have license headers. -->
    +              <exclude>depends/libhdfs3/test/data/*</exclude>
    +              <exclude> depends/libhdfs3/debian/**</exclude>
    --- End diff --
    
    a small nit: please fix a spurious whitespace


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70544369
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    +              <!-- exclude open-source python modules -->
    +              <!-- MIT license for open-source python modules -->
                   <exclude>tools/bin/pythonSrc/PyGreSQL-4.0/**</exclude>
    +              <exclude>tools/bin/pythonSrc/PSI-0.3b2_gp/**</exclude>
    +              <exclude>tools/bin/pythonSrc/lockfile-0.9.1/**</exclude>
    +              <!-- BSD license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pychecker-0.8.18/**</exclude>
    +              <exclude>tools/bin/pythonSrc/unittest2-0.5.1/**</exclude>
    +              <!-- apache compatible license for open-source python modules -->
    +              <exclude>tools/bin/pythonSrc/pycrypto-2.0.1/**</exclude>
    --- End diff --
    
    At this point the agreement is that we're not distributing crypto code with HAWQ


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #788: HAWQ-915. RAT is failing on the latest master

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on the issue:

    https://github.com/apache/incubator-hawq/pull/788
  
    @paul-guo- great sleuthing! The patch looks good to me now. Can you please commit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #788: HAWQ-915. RAT is failing on the latest mas...

Posted by rvs <gi...@git.apache.org>.
Github user rvs commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/788#discussion_r70543816
  
    --- Diff: pom.xml ---
    @@ -37,14 +37,32 @@
                   <!-- stream benchmark under BSD-like license with a few exceptions around benchmarking results -->
                   <exclude>tools/bin/src/stream/*</exclude> 
     
    -              <!-- PyGreSQL an open-source Python module that interfaces to a PostgreSQL database under the Python license -->
    --- End diff --
    
    Please leave this comment near PyGreSQL entry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---