You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/08/06 11:08:04 UTC
[jira] [Commented] (FLINK-2490) Remove unwanted boolean check in
function SocketTextStreamFunction.streamFromSocket
[ https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14659712#comment-14659712 ]
ASF GitHub Bot commented on FLINK-2490:
---------------------------------------
GitHub user HuangWHWHW opened a pull request:
https://github.com/apache/flink/pull/992
[FLINK-2490][FIX]Remove the retryForever check in function streamFrom…
In the class SocketTextStreamFunction, the var retryForever only be set in the line "this.retryForever = maxRetry < 0;"(SocketTextStreamFunction.java:54).
When the program executes this “while (retry < maxRetry && !success) ” it means the maxRetry > 0 and the retryForever will always be false.
So it`s unnecessary to judge whether retryForever be false.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HuangWHWHW/flink FLINK-2490
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/992.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #992
----
commit 25a41d0f462add2f11c6830ec8db518702f8dbb5
Author: HuangWHWHW <40...@qq.com>
Date: 2015-08-06T08:55:24Z
[FLINK-2490][FIX]Remove the retryForever check in function streamFromSocket
----
> Remove unwanted boolean check in function SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
> Key: FLINK-2490
> URL: https://issues.apache.org/jira/browse/FLINK-2490
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)