[arrow] branch master updated: ARROW-5325: [Archery][Benchmark] Output properly formatted jsonlines from benchmark diff cli command

[ks...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kszucs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 68329e7  ARROW-5325: [Archery][Benchmark] Output properly formatted jsonlines from benchmark diff cli command
68329e7 is described below

commit 68329e728c5356f85c4a492c9749ea9125b06993
Author: Krisztián Szűcs <sz...@gmail.com>
AuthorDate: Tue May 21 16:16:56 2019 +0200

    ARROW-5325: [Archery][Benchmark] Output properly formatted jsonlines from benchmark diff cli command
    
    Author: Krisztián Szűcs <sz...@gmail.com>
    
    Closes #4274 from kszucs/hook-test and squashes the following commits:
    
    2be809892 <Krisztián Szűcs> remove arm intrinsics headers
    3c8deb184 <Krisztián Szűcs> __ARM_NEON__ is legacy
    20e485000 <Krisztián Szűcs> clang-format
    55d2c77f1 <Krisztián Szűcs> intrinsics
    29bded608 <Krisztián Szűcs> clang format
    f1f4f9203 <Krisztián Szűcs> remove intrinsics include
    35f64689a <Krisztián Szűcs> arm intrinsics
    de8389d1e <Krisztián Szűcs> write line separator to output properly formatted jsonlines
---
 cpp/src/arrow/compute/kernels/aggregate-benchmark.cc | 14 ++++----------
 dev/archery/archery/cli.py                           |  3 +++
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/cpp/src/arrow/compute/kernels/aggregate-benchmark.cc b/cpp/src/arrow/compute/kernels/aggregate-benchmark.cc
index bbc923f..085843e 100644
--- a/cpp/src/arrow/compute/kernels/aggregate-benchmark.cc
+++ b/cpp/src/arrow/compute/kernels/aggregate-benchmark.cc
@@ -18,22 +18,16 @@
 #include "benchmark/benchmark.h"
 
 #include <vector>
-#ifdef _MSC_VER
-#include <intrin.h>
-#else
-#include <immintrin.h>
-#endif
 
 #include "arrow/builder.h"
-#include "arrow/memory_pool.h"
-#include "arrow/testing/gtest_util.h"
-#include "arrow/testing/random.h"
-#include "arrow/util/bit-util.h"
-
 #include "arrow/compute/benchmark-util.h"
 #include "arrow/compute/context.h"
 #include "arrow/compute/kernel.h"
 #include "arrow/compute/kernels/sum.h"
+#include "arrow/memory_pool.h"
+#include "arrow/testing/gtest_util.h"
+#include "arrow/testing/random.h"
+#include "arrow/util/bit-util.h"
 
 namespace arrow {
 namespace compute {
diff --git a/dev/archery/archery/cli.py b/dev/archery/archery/cli.py
index b7b077a..0178d58 100644
--- a/dev/archery/archery/cli.py
+++ b/dev/archery/archery/cli.py
@@ -352,9 +352,12 @@ def benchmark_diff(ctx, src, preserve, suite_filter, benchmark_filter,
 
         regressions = 0
         runner_comp = RunnerComparator(runner_cont, runner_base, threshold)
+
+        # TODO(kszucs): test that the output is properly formatted jsonlines
         for comparator in runner_comp.comparisons:
             regressions += comparator.regression
             json.dump(comparator, output, cls=JsonEncoder)
+            output.write('\n')
 
         sys.exit(regressions)